Tricks of the Trade (ToT)
Leafkiller
I had a request to add ToT support to my Ovale script. I see that it
is a selectable buff in Mew, but there is no API support to query it.
Since it is similar to TF in that it gives 15% more damage for 6
seconds (without the energy gain) it is possible that we should not
pool energy with the buff up, not to mention casting Ravage! if the
Stampede buff is present.
If you find yourself bored sometime, any chance you could add some API
support for ToT?
In the long term, we may want to be able to test for the presence of
other periodic buffs such as trinket procs - so maybe you can think
about a way to make more of these accessible in the API. That or you
could be working on your chess game ;)
Yawning Angel
> If you find yourself bored sometime, any chance you could add some API
> support for ToT?
Done. Not tested but it's a trivial change so I doubt I screwed it
up. See r945.
> In the long term, we may want to be able to test for the presence of
> other periodic buffs such as trinket procs - so maybe you can think
> about a way to make more of these accessible in the API. That or you
> could be working on your chess game ;)
You already can. Search the script for mUnheededWarning (Code
commented out, but should work fine. Left it in as an example.).
Regards,
Yawning
Leafkiller
raid buffs.
If I add a conditional to the Shred code to keep shredding with ToTT
up I see about a 30 dps increase (no energy pooling)
I did not see any improvement adding it to Stampede/Ravage, but I did
not test mid-encounter Ravages. Obviously I did not test it with the
T13 4 piece since that will always have TF up.
I did not see any improvement when I tried to refresh a Rake early
although the difficulty there is refreshing too often since I don't
have a check for the Rake having been ToTTed (similar to isRakeTFed).
I am guessing that ToTT will be applied every 30 seconds in Mew, while
TF is in the 31-32 second range, so ToTT will go first with TF
probably overlapping a little and then drifting further away. This
would result in Rakes being refreshed by both, losing energy and
causing a dps decrease. Even if I check for both conditions to fix
this, I am not sure how I would be able to deal with this in game. My
Ovale code only works because I check a 9 second window on Rake which
guarantees it was refreshed before TF.
Leafkiller
calls to let me explicitly know if Rip/Rake were cast with TF/ToTT up.
If I get this enhancement, then it might be worth it (for the Ovale
users at least) to test the complex conditions around clipping such as
what to do if both buffs are present etc. Of course, this is
predicated on having ToTT cast on us...
Yawning Angel
It's sort of unlikely to begin with since most Rogues tend to circlejerk ToTT.
It's trivial to add conditionals on my end, but it would be fairly
annoying to tell from an addon if TF or ToTT were up when certain
buffs/debuffs were cast (You'd need to keep tracks of targets present
and their debuffs which is a lot of work in the
COMBAT_LOG_EVENT_UNFILTERED handler).
If there's sufficient demand for it, I could certainly add
conditionals to query ToTT DoTs, but if it's something that's
difficult to take advantage of in practice, I don't see much point to
it. Additionally Mew is most definitely overvaluing ToTT since most
people won't manage to consistently cast it on cooldown.
Regards,
Yawning
Leafkiller
I agree that ToTT is being overvalued. I know when I play my rogue I
am pretty sloppy about hitting it on cooldown. Of course I don't raid
on my rogue...
It is possible that Gabrielz will add something in Ovale to make this
possible as he responded to my ticket with the start of a workable
solution: http://wow.curseforge.com/addons/ovale/tickets/100-checking-if-rake-rip-were-cast-during-tf-or-tott/
The multi-target issue is an interesting question - one I did not
consider from an addon perspective.