BMO test triggers

[Lennart Jern]

Hi contributors!

We are working on getting rid of a deprecated jenkins plugin used to trigger some of our tests. As part of this I have switched the BMO e2e tests to be triggered in a slightly different way.

TL;DR:

• Old trigger comment: /metal3-bmo-e2e-test
  

• New trigger comment: /test metal3-bmo-e2e-test-pull
  

The status context shows the correct name but you have to put `/test ` in front (note the space after /test)

I also want to highlight that we are starting to split up the e2e suite in two separate jobs. The one above is for required tests that are expected to pass on all PRs. There is another optional job that can be triggered on PRs when deemed useful. Currently it runs BMO upgrade tests.

You can trigger it with /test metal3-bmo-e2e-optional-test

Here is a PR adding info about the triggers to the readme: https://github.com/metal3-io/baremetal-operator/pull/1525

Best regards,

Lennart

P.S.
An added benefit of the new trigger system is that you can get help on what tests are available and the commands for triggering them with a simple `/test ?`.

[Lennart Jern]

And of course I managed to get a typo in that email...

The correct trigger for the new optional test is

/test metal3-bmo-e2e-test-optional-pull

Lennart

---

From: metal...@googlegroups.com <metal...@googlegroups.com> on behalf of Lennart Jern <lennar...@est.tech>
Sent: Friday, January 19, 2024 13:27
To: Metal3 Dev <metal...@googlegroups.com>
Subject: [metal3-dev] BMO test triggers

 

--
You received this message because you are subscribed to the Google Groups "Metal3 Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to metal3-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/metal3-dev/HE1P189MB04752BCCB17ACC7A2C9A019AFF702%40HE1P189MB0475.EURP189.PROD.OUTLOOK.COM.

[Riccardo Pittau]

Hi Lennart,

thank you for this!

Maybe it's a bit too late but just wondering if we could rename the optional job adding the "upgrade" word to be more explicit.
Unless the plan is to add more tests to the same command, then scratch that.

Cheers
Riccardo

To view this discussion on the web visit https://groups.google.com/d/msgid/metal3-dev/HE1P189MB0475A77794EB9DB487367B55FF702%40HE1P189MB0475.EURP189.PROD.OUTLOOK.COM.

[Lennart Jern]

Hi!

Yes, the plan is to add more tests to this optional suite!

I suspect we may even want to make some of the currently required tests optional by moving them there.

Until now we just had one job so everything was added there. Now when I compare what we used to have as required in the CAPM3-based jobs we require way more in BMO e2e! Not necessarily a bad thing, but something to think about if the tests start to take too long.

Lennart

---

From: Riccardo Pittau <elfo...@gmail.com>
Sent: Friday, January 19, 2024 15:40
To: Lennart Jern <lennar...@est.tech>
Cc: Metal3 Dev <metal...@googlegroups.com>
Subject: Re: [metal3-dev] Re: BMO test triggers