Cluster API Provider Metal3 v1.1.1 released!

17 views
Skip to first unread message

Furkat Gofurov

unread,
Mar 24, 2022, 5:37:49 AM3/24/22
to Metal3 Development List
Hi folks,

The new version of Cluster API Provider Metal3, CAPM3 v1.1.1 is out now! 🎉

Thanks to all our contributors! 😊

Best regards,
Furkat

Dmitry Tantsur

unread,
Mar 24, 2022, 6:58:46 AM3/24/22
to Furkat Gofurov, Metal3 Development List
Hi!

Could you remind me, what's our versioning policy? I would expect dropping an API version to justify at least 1.2.0.

--
You received this message because you are subscribed to the Google Groups "Metal3 Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to metal3-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/metal3-dev/PAXP189MB161578FCB267405C27D1B872ED199%40PAXP189MB1615.EURP189.PROD.OUTLOOK.COM.


--
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill

Furkat Gofurov

unread,
Mar 24, 2022, 7:12:14 AM3/24/22
to Dmitry Tantsur, Metal3 Development List
Hi Dmitry,

Sure, we are trying to follow closely the Cluster API release process, as described in https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/VERSIONING.md

From: Dmitry Tantsur <dtan...@redhat.com>
Sent: Thursday, March 24, 2022 12:58 PM
To: Furkat Gofurov <furkat....@est.tech>
Cc: Metal3 Development List <metal...@googlegroups.com>
Subject: Re: [metal3-dev] Cluster API Provider Metal3 v1.1.1 released!
 

Dmitry Tantsur

unread,
Mar 24, 2022, 7:14:12 AM3/24/22
to Furkat Gofurov, Metal3 Development List
Per this document we should have had a 2.0.0 since we have a breaking change.

Furkat Gofurov

unread,
Mar 24, 2022, 7:23:02 AM3/24/22
to Dmitry Tantsur, Metal3 Development List
Agree, I believe that breaking change was included in this release mainly because, the v1alpha4 API version of CAPM3 is
compatible with Cluster API v1alpha3 API version, where support for latter stopped starting from 2022-02-23 as per: https://github.com/kubernetes-sigs/cluster-api/blob/main/CONTRIBUTING.md#support-and-guarantees

Best regards,
Furkat

From: Dmitry Tantsur <dtan...@redhat.com>
Sent: Thursday, March 24, 2022 1:13 PM

Kashif Khan

unread,
Mar 24, 2022, 7:24:48 AM3/24/22
to Dmitry Tantsur, Furkat Gofurov, Metal3 Development List
I believe we are not introducing any breaking change for beta API itself. The breaking change heading for removing v1a4 api types perhaps was not needed. 

BR
Kashif 
From: metal...@googlegroups.com <metal...@googlegroups.com> on behalf of Dmitry Tantsur <dtan...@redhat.com>
Sent: Thursday, March 24, 2022 1:13 PM

Dmitry Tantsur

unread,
Mar 24, 2022, 7:59:17 AM3/24/22
to Kashif Khan, Furkat Gofurov, Metal3 Development List
I interpret the guidelines as applying to the whole project, not to the most recent API version. At least this is how semantic versioning is commonly applied.

Kashif Khan

unread,
Mar 24, 2022, 8:21:59 AM3/24/22
to Dmitry Tantsur, Furkat Gofurov, Metal3 Development List
I agree with you. Whats your suggestion regarding the current release ?

BR
Kashif 
Sent: Thursday, March 24, 2022 1:58 PM
To: Kashif Khan <kashi...@est.tech>
Cc: Furkat Gofurov <furkat....@est.tech>; Metal3 Development List <metal...@googlegroups.com>

Dmitry Tantsur

unread,
Mar 24, 2022, 10:11:33 AM3/24/22
to Kashif Khan, Furkat Gofurov, Metal3 Development List
I'd probably re-release it as 1.2.0 (not 2.0.0 only because the deleted API was alpha) to avoid confusion. I'd probably not delete the already created tag to avoid issues for forks.

Kashif Khan

unread,
Mar 24, 2022, 1:26:37 PM3/24/22
to Dmitry Tantsur, Furkat Gofurov, Metal3 Development List
Yes that is an option, but that would be an issue to keep CAPM3 minor versioning synced with CAPI as a provider. Its not strictly necessary to follow the version as CAPI but that's the norm most of the providers follow I believe. 

On the contrary, we can actually remove the commit from breaking change and add it to the other changes without deleting the current tag. Would that make sense ?

Best Regards,
Kashif 
From: Dmitry Tantsur <dtan...@redhat.com>
Sent: Thursday, March 24, 2022 4:11 PM

Kashif Khan

unread,
Mar 24, 2022, 1:59:00 PM3/24/22
to Fox, Kevin M, Dmitry Tantsur, Furkat Gofurov, Metal3 Development List
What I meant is the following release-note in the v1.1.1 release is updatable. So the following would be the updated release note if we agree for the update and this would not require any new tag for the release.

Personally, I don't think the commit in question should be listed under breaking changes.

BR
Kashif 

Changes since v1.1.0

warning Breaking Changes

sparkles New Features

  • Introduce an additional providerID format and set providerID from nodes when noCloudProvider is set to false (#563)

bug Bug Fixes

  • Fix node reuse test for e2e ephemeral cluster tests (#574)
  • Replace update taints with patch node taints (#539)
  • Fix bmhID parsing when providerid is set on the node directly. (#560)

book Documentation

  • Document e2e tests (#553)
  • Add creation of BMO namespace in root README instructions (#544)
  • Update root README file (#541)
  • Update ubuntu based e2e tests trigger phrases (#536)

seedling Others

  • Uplift IPAM in gomod and kustomize files (#579)
  • Remove golint linter from golangci.yaml and rename golint hack script to golangci-lint (#577)
  • Add concurrency parameter in gosec (#571)
  • Add e2e tests for ephemeral cluster (#568)
  • Add mboukhalfa as reviewer (#569)
  • Allow kubectl caching after cluster creation (#552)
  • Uplift CAPI version in e2e tests to 1.1.3 and 0.4.8 and CAPI go modules to 1.1.3 (#558)
  • Introduce gosec file for go security checks and related changes (#547)
  • Remove hardys from OWNERS (#555)
  • Change dev-env default branch from master to main in e2e script (#556)
  • Add v1alpha5 to v1beta e2e upgrade tests (#466)
  • Parameterize namespace name in tests (#549)
  • Uplift containerd CRI plugin (#551)
  • Generate templates from e2e (#537)
  • Remove tilt_modules (#534)
  • Add unit tests for metal3MachineTemplate reconciliation (#540)
  • Uplift e2e test module to v1.1.2 in go mod and e2e conf file (#538)
  • Uplift BMO modules to latest (March 2022) (#576)
  • [Part2] Add more linters into golangci.yml (#522)
  • Add providerid field metadata (#548)
  • Remove new provideruid format (#492)
  • Remove providerID field from m3mdata (#491)
  • Drop CAPM3 v1alpha4 support from main branch (#509)

From: Fox, Kevin M <Kevi...@pnnl.gov>
Sent: Thursday, March 24, 2022 7:34 PM
To: Kashif Khan <kashi...@est.tech>; Dmitry Tantsur <dtan...@redhat.com>

Cc: Furkat Gofurov <furkat....@est.tech>; Metal3 Development List <metal...@googlegroups.com>
Subject: Re: [metal3-dev] Cluster API Provider Metal3 v1.1.1 released!
 
Remove the binaries, leave the tag, commit a new patch to the tag saying, don't use, and cut a 1.2.0?

________________________________________
From: metal...@googlegroups.com <metal...@googlegroups.com> on behalf of Kashif Khan <kashi...@est.tech>
Sent: Thursday, March 24, 2022 10:26 AM
To: Dmitry Tantsur
Cc: Furkat Gofurov; Metal3 Development List

Subject: Re: [metal3-dev] Cluster API Provider Metal3 v1.1.1 released!

Check twice before you click! This email originated from outside PNNL.


Yes that is an option, but that would be an issue to keep CAPM3 minor versioning synced with CAPI as a provider. Its not strictly necessary to follow the version as CAPI but that's the norm most of the providers follow I believe.

On the contrary, we can actually remove the commit from breaking change and add it to the other changes without deleting the current tag. Would that make sense ?

Best Regards,
Kashif
________________________________
From: Dmitry Tantsur <dtan...@redhat.com>
Sent: Thursday, March 24, 2022 4:11 PM
To: Kashif Khan <kashi...@est.tech>
Cc: Furkat Gofurov <furkat....@est.tech>; Metal3 Development List <metal...@googlegroups.com>
Subject: Re: [metal3-dev] Cluster API Provider Metal3 v1.1.1 released!

I'd probably re-release it as 1.2.0 (not 2.0.0 only because the deleted API was alpha) to avoid confusion. I'd probably not delete the already created tag to avoid issues for forks.

On Thu, Mar 24, 2022 at 1:22 PM Kashif Khan <kashi...@est.tech> wrote:
I agree with you. Whats your suggestion regarding the current release ?

BR
Kashif
________________________________

Sent: Thursday, March 24, 2022 1:58 PM
To: Kashif Khan <kashi...@est.tech>
Cc: Furkat Gofurov <furkat....@est.tech>; Metal3 Development List <metal...@googlegroups.com<mailto:metal...@googlegroups.com>>

Subject: Re: [metal3-dev] Cluster API Provider Metal3 v1.1.1 released!

I interpret the guidelines as applying to the whole project, not to the most recent API version. At least this is how semantic versioning is commonly applied.

On Thu, Mar 24, 2022 at 12:24 PM Kashif Khan <kashi...@est.tech> wrote:
I believe we are not introducing any breaking change for beta API itself. The breaking change heading for removing v1a4 api types perhaps was not needed.

BR
Kashif
________________________________

Sent: Thursday, March 24, 2022 1:13 PM
To: Furkat Gofurov <furkat....@est.tech>
Cc: Metal3 Development List <metal...@googlegroups.com<mailto:metal...@googlegroups.com>>

Subject: Re: [metal3-dev] Cluster API Provider Metal3 v1.1.1 released!

Per this document we should have had a 2.0.0 since we have a breaking change.

On Thu, Mar 24, 2022 at 12:12 PM Furkat Gofurov <furkat....@est.tech> wrote:
Hi Dmitry,


Sent: Thursday, March 24, 2022 12:58 PM
To: Furkat Gofurov <furkat....@est.tech>
Cc: Metal3 Development List <metal...@googlegroups.com<mailto:metal...@googlegroups.com>>

Subject: Re: [metal3-dev] Cluster API Provider Metal3 v1.1.1 released!

Hi!

Could you remind me, what's our versioning policy? I would expect dropping an API version to justify at least 1.2.0.

On Thu, Mar 24, 2022 at 10:38 AM Furkat Gofurov <furkat....@est.tech> wrote:
Hi folks,

The new version of Cluster API Provider Metal3, CAPM3 v1.1.1 is out now! 🎉


Thanks to all our contributors! 😊

Best regards,
Furkat

--
You received this message because you are subscribed to the Google Groups "Metal3 Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to metal3-dev+...@googlegroups.com<mailto:metal3-dev+...@googlegroups.com>.
To view this discussion on the web visit https://groups.google.com/d/msgid/metal3-dev/PAXP189MB161578FCB267405C27D1B872ED199%40PAXP189MB1615.EURP189.PROD.OUTLOOK.COM<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fd%2Fmsgid%2Fmetal3-dev%2FPAXP189MB161578FCB267405C27D1B872ED199%2540PAXP189MB1615.EURP189.PROD.OUTLOOK.COM%3Futm_medium%3Demail%26utm_source%3Dfooter&data=04%7C01%7CKevin.Fox%40pnnl.gov%7C61c72ad0ee5f42ec4f3708da0dbbe5c4%7Cd6faa5f90ae240338c0130048a38deeb%7C0%7C0%7C637837397919892396%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=oGF7D8qLTQTgWqwHYqVy0RSR7jrwoOyMy68gkaF4G2Q%3D&reserved=0>.


--
Red Hat GmbH, https://de.redhat.com/<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fde.redhat.com%2F&data=04%7C01%7CKevin.Fox%40pnnl.gov%7C61c72ad0ee5f42ec4f3708da0dbbe5c4%7Cd6faa5f90ae240338c0130048a38deeb%7C0%7C0%7C637837397919892396%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Yl4PORq%2FhV0ieM%2BdBjksE31WHK8Xkyob7426%2FAR%2FSuI%3D&reserved=0> , Registered seat: Grasbrunn,

Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill


--

Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill

--
You received this message because you are subscribed to the Google Groups "Metal3 Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to metal3-dev+...@googlegroups.com<mailto:metal3-dev+...@googlegroups.com>.
To view this discussion on the web visit https://groups.google.com/d/msgid/metal3-dev/CACNgkFwaA56G0oRM-n25Xat0Z22Wn%3Dw8o9%2BLTkRs4q7u5ipajQ%40mail.gmail.com<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fd%2Fmsgid%2Fmetal3-dev%2FCACNgkFwaA56G0oRM-n25Xat0Z22Wn%253Dw8o9%252BLTkRs4q7u5ipajQ%2540mail.gmail.com%3Futm_medium%3Demail%26utm_source%3Dfooter&data=04%7C01%7CKevin.Fox%40pnnl.gov%7C61c72ad0ee5f42ec4f3708da0dbbe5c4%7Cd6faa5f90ae240338c0130048a38deeb%7C0%7C0%7C637837397919892396%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=UVJPg2vIHbMyMAJJN3oHCKRVCRxp4rpH0tJpzeqVYKI%3D&reserved=0>.


--
Red Hat GmbH, https://de.redhat.com/<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fde.redhat.com%2F&data=04%7C01%7CKevin.Fox%40pnnl.gov%7C61c72ad0ee5f42ec4f3708da0dbbe5c4%7Cd6faa5f90ae240338c0130048a38deeb%7C0%7C0%7C637837397919892396%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Yl4PORq%2FhV0ieM%2BdBjksE31WHK8Xkyob7426%2FAR%2FSuI%3D&reserved=0> , Registered seat: Grasbrunn,

Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill

--
You received this message because you are subscribed to the Google Groups "Metal3 Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to metal3-dev+...@googlegroups.com<mailto:metal3-dev+...@googlegroups.com>.
To view this discussion on the web visit https://groups.google.com/d/msgid/metal3-dev/CACNgkFyKxxbXO6HAo9TFVk_QmKyBJgkTXWUAAjxTkaFTw9asKw%40mail.gmail.com<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fd%2Fmsgid%2Fmetal3-dev%2FCACNgkFyKxxbXO6HAo9TFVk_QmKyBJgkTXWUAAjxTkaFTw9asKw%2540mail.gmail.com%3Futm_medium%3Demail%26utm_source%3Dfooter&data=04%7C01%7CKevin.Fox%40pnnl.gov%7C61c72ad0ee5f42ec4f3708da0dbbe5c4%7Cd6faa5f90ae240338c0130048a38deeb%7C0%7C0%7C637837397919892396%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=30S0%2BsxbQ5uga1nK9Zbc3ee4v0n7TjnoWnW6QmSm7T0%3D&reserved=0>.


--
Red Hat GmbH, https://de.redhat.com/<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fde.redhat.com%2F&data=04%7C01%7CKevin.Fox%40pnnl.gov%7C61c72ad0ee5f42ec4f3708da0dbbe5c4%7Cd6faa5f90ae240338c0130048a38deeb%7C0%7C0%7C637837397919892396%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Yl4PORq%2FhV0ieM%2BdBjksE31WHK8Xkyob7426%2FAR%2FSuI%3D&reserved=0> , Registered seat: Grasbrunn,

Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill

--
You received this message because you are subscribed to the Google Groups "Metal3 Development List" group.
To unsubscribe from this group and stop receiving emails from it, send an email to metal3-dev+...@googlegroups.com<mailto:metal3-dev+...@googlegroups.com>.
To view this discussion on the web visit https://groups.google.com/d/msgid/metal3-dev/HE1P189MB0395C18F659554BC8183040090199%40HE1P189MB0395.EURP189.PROD.OUTLOOK.COM<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fd%2Fmsgid%2Fmetal3-dev%2FHE1P189MB0395C18F659554BC8183040090199%2540HE1P189MB0395.EURP189.PROD.OUTLOOK.COM%3Futm_medium%3Demail%26utm_source%3Dfooter&data=04%7C01%7CKevin.Fox%40pnnl.gov%7C61c72ad0ee5f42ec4f3708da0dbbe5c4%7Cd6faa5f90ae240338c0130048a38deeb%7C0%7C0%7C637837397919892396%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=clJG7FrWZKo3JdZPD8YQ8eKs%2BhPNAZeWTKpXlCta1F8%3D&reserved=0>.

Furkat Gofurov

unread,
Mar 24, 2022, 2:27:31 PM3/24/22
to Kashif Khan, Fox, Kevin M, Dmitry Tantsur, Metal3 Development List
I went through the CAPI, and it turned out that our VERSIONING.md is quite outdated in regards to 
what kind of changes can be included in releases. So, minor releases can include breaking changes as per [1]
while our docs currently do not outline it. We should definitely update our versioning document in that regard.

Also, the commit dropping the API version in the main branch, which is meant for v1beta1 API should not be
considered as "breaking change" since the support for compatible API in CAPI is stopped and we do
only support that API from the stable release branch (release-0.4).
All in all, I would also suggest updating the current release notes if everyone agrees.

Best regards,
Furkat

[1] https://github.com/kubernetes-sigs/cluster-api/blob/main/CONTRIBUTING.md#versioning
Top-level fields in status must always have the +optional annotation. If we want the field to be always visible even if it has the zero value, it must not have the omitempty JSON tag, e.g.:. Replica counters like availableReplicas in the MachineDeployment; Flags expressing progress in the object lifecycle like infrastructureReady in Machine; CRD additionalPrinterColumns




From: Kashif Khan <kashi...@est.tech>
Sent: Thursday, March 24, 2022 7:58 PM
To: Fox, Kevin M <Kevi...@pnnl.gov>; Dmitry Tantsur <dtan...@redhat.com>

Dmitry Tantsur

unread,
Mar 25, 2022, 5:57:26 AM3/25/22
to Furkat Gofurov, Kashif Khan, Fox, Kevin M, Metal3 Development List
Note that a minor version is still 1.2.0, not 1.1.1.
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,

Furkat Gofurov

unread,
Mar 25, 2022, 8:39:21 AM3/25/22
to Dmitry Tantsur, Kashif Khan, Fox, Kevin M, Metal3 Development List
Yeah, that is right, I was referring to your previous statement regarding the need for 2.0.0 release 🙂


Best,
Furkat


From: Dmitry Tantsur <dtan...@redhat.com>
Sent: Friday, March 25, 2022 11:57 AM
To: Furkat Gofurov <furkat....@est.tech>
Cc: Kashif Khan <kashi...@est.tech>; Fox, Kevin M <Kevi...@pnnl.gov>; Metal3 Development List <metal...@googlegroups.com>
Reply all
Reply to author
Forward
0 new messages