On 7/04/21 3:04 pm, Noor Muhammad Malik wrote:
> @zane I agree with what you've said, doing both looks straightforward
> from the CRD perspective.
> And no we don't need a video call to discuss it :D Let's just say we're
> going to keep the discussion going here, till the poll ends, and once we
> decide upon a time for the meeting, if there are any discussion items
> left, we can move onto a meeting to further dissect this. Really
> appreciate the timely response! :)
++
> @bob thanks for the application, yes it should be a series of clean
> steps needed to accomplish it all. Let's see what dmitry has to say
> about this.
After seeing Bob's response and realising that they are both using the
same cleaning step, I looked at the proposed PR and I see that we are
effectively requiring the bmc driver to tell us how to map from the
limited options that we are specifying directly in the BMC to the
'apply_configuration' settings. That means that even in the worst case
scenario (that ironic cannot handle multiple 'apply_configuration' clean
steps), we do have enough information in the baremetal-operator to merge
these correctly.
So given that we know there is at least one way to implement a sane
interface that includes both, for my vote I don't see this being an
obstacle to making progress on the small number of vendor-neutral
options that have been proposed. (However, I'm definitely against adding
any vendor-specific fields until we have at least reconciled that with
the bulk set proposal. imho the bulk set proposal is superior to adding
vendor-specific options with a formal schema, and should probably
replace that idea.)
We should update
https://github.com/metal3-io/metal3-docs/pull/173 with
the priority order:
1. FirmwareConfig
2. bulk settings
3. whatever is currently configured
cheers,
Zane.
>
> Warm regards,
>
> Noor Muhammad Malik
> Assistant Manager
> xFlow Research Inc.
>
+92 310 5382448 (GMT +5)
>
noor.m...@xflowresearch.com <mailto:
noor.m...@xflowresearch.com>
>
www.xflowresearch.com <
http://www.xflowresearch.com>
> <
https://docs.openstack.org/ironic/rocky/admin/bios.html>)
>
> So if the individual set was a clean step after the bulk set we
> would end up with the value
> from the individual set. (Dmitry - correct me if that's not right).
>
> Bob
>
>
> Conversely, if it would require multiple passes of manual
> cleaning or
> understanding of the format of the bulk config data then we have
> some
> thinking to do.
>
> cheers,
> Zane.
>
> --
> You received this message because you are subscribed to the
> Google Groups "Metal3 Development List" group.
> To unsubscribe from this group and stop receiving emails from
> it, send an email to
metal3-dev+...@googlegroups.com
> <mailto:
metal3-dev%2Bunsu...@googlegroups.com>.
> <
https://groups.google.com/d/msgid/metal3-dev/8c476ad0-4411-a007-d282-becb9aaac374%40redhat.com>.
>
> --
> You received this message because you are subscribed to the Google
> Groups "Metal3 Development List" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to
metal3-dev+...@googlegroups.com
> <mailto:
metal3-dev+...@googlegroups.com>.
> To view this discussion on the web visit
>
https://groups.google.com/d/msgid/metal3-dev/CAMnktEC92fEes0VbRjVnEVNCF%3Dv7HZzn4-4pvfbq5ho2nv26DQ%40mail.gmail.com
> <
https://groups.google.com/d/msgid/metal3-dev/CAMnktEC92fEes0VbRjVnEVNCF%3Dv7HZzn4-4pvfbq5ho2nv26DQ%40mail.gmail.com?utm_medium=email&utm_source=footer>.
>