On 25/01/21 9:26 am, Dmitry Tantsur wrote:
> Hi all,
>
> This idea came to me after reviewing
>
https://github.com/metal3-io/ironic-inspector-image/pull/70
> <
https://github.com/metal3-io/ironic-inspector-image/pull/70> which
> introduces an httpd process for ironic-inspector. As you know, we
> already have an httpd process for ironic, and that caused me to think
> about merging the two repositories together. Other considerations:
> 1) ironic and ironic-inspector share most of their Python dependencies,
> by using one base container we can reduce the disk usage
> 2) the separation is already vague: the httpd and dnsmasq containers
> from ironic-image have ironic-inspector configuration (e.g. kernel
> parameters)
> 2.1) ... and we have to keep them in sync manually
> 3) having only one copy of ironic-common.sh
> 3.1) overall simpler maintenance
>
> If we go with this plan, we'll build a single ironic-image container,
> from which several (5-6?) entry points will be used to start different
> services (similarly to how it's done for ironic already).
>
> Slightly tangential, but we should likely separate the mariadb/mysql
> container since it shares nearly nothing with other services.
>
> Thoughts?
From a maintenance perspective, it's a pain having these in two
separate repos and constantly copying fixes between them, so +1 to
combining them.
It's possible to build multiple images from a single Dockerfile, so if
we combine the repos it would be possible to still build separate images
(such that all the tooling that is currently using them wouldn't even
have to change) that nevertheless share the layer with all the Python
dependencies (which would be cached so they didn't have to be downloaded
twice). That might offer the best cost/benefit.
cheers,
Zane.