[meta-fsl-arm][PATCH V2] udev: Use oe_filter_out to switch to git source

[Andrei Gherzan]

Don't redefine SRC_URI just to replace source. We can use oe_filter_out
and have this done in one line.
Don't append FILESEXTRAPATHS as we don't yet use any local files.

Signed-off-by: Andrei Gherzan <and...@gherzan.ro>
---
recipes-core/udev/udev_173.bbappend | 23 ++++-------------------
1 file changed, 4 insertions(+), 19 deletions(-)

diff --git a/recipes-core/udev/udev_173.bbappend b/recipes-core/udev/udev_173.bbappend
index 080f6b7..29b20bd 100644
--- a/recipes-core/udev/udev_173.bbappend
+++ b/recipes-core/udev/udev_173.bbappend
@@ -1,23 +1,8 @@
-# Freescale imx extra configuration udev rules
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
-
-PRINC := "${@int(PRINC) + 1}"
+PRINC := "${@int(PRINC) + 2}"

+# Switch to git source
# 173 tag
SRCREV = "ad667dff51711fed763a23283d973486de3cd6b5"
-
-# version specific SRC_URI
-SRC_URI = "git://git.kernel.org/pub/scm/linux/hotplug/udev.git;protocol=git \
- file://0001-rip-put-doc-generation-it-depends-on-a-working-docto.patch \
- file://gtk-doc.make"
-
-# generic SRC_URI
-SRC_URI += " \
- file://touchscreen.rules \
- file://modprobe.rules \
- file://default \
- file://init \
- file://cache \
-"
-
+SRC_URI := "${@oe_filter_out('${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.bz2', '${SRC_URI}', d)}"
+SRC_URI_prepend = "git://git.kernel.org/pub/scm/linux/hotplug/udev.git;protocol=git "
S = "${WORKDIR}/git"
--
1.7.9.5

[Andrei Gherzan]

Added PRINC bump.

[Otavio Salvador]

On Sun, Oct 21, 2012 at 9:07 PM, Andrei Gherzan <and...@gherzan.ro> wrote:
> Don't redefine SRC_URI just to replace source. We can use oe_filter_out
> and have this done in one line.
> Don't append FILESEXTRAPATHS as we don't yet use any local files.
>
> Signed-off-by: Andrei Gherzan <and...@gherzan.ro>

Applied to denzil and master.

--
Otavio Salvador O.S. Systems
E-mail: ota...@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br

[Daiane Angolini]

Is it a bug fix?

Why did you applied to denzil?


Daiane

[Otavio Salvador]

On Mon, Oct 22, 2012 at 10:10 AM, Daiane Angolini <daian...@gmail.com> wrote:
> Is it a bug fix?
>
> Why did you applied to denzil?

We where overriding all the fields so if something where change in
meta-oe udev we'd not get it. That's why I applied it onto denzil.

[Daiane Angolini]

> We where overriding all the fields so if something where change in
> meta-oe udev we'd not get it. That's why I applied it onto denzil.

Ok thanks for info.


Daiane

[Vijay Raju]

Hi Andrei,

I seem seem to be having trouble building with this patch. The oe_filter_out doesn't seem to work and the do_fetch tries to pull the tar from the kernel org mirror where udev-173.tar.bz2 does not exist. 

-Vijay

[Vijay Raju]

Hi Andrei,

I guess the the line should be:

"${@oe_filter_out('${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.gz', '${SRC_URI}', d)}"

".tar.gz" instead of ".tar.bz2"

-Vijay

[Otavio Salvador]

On Wed, Oct 31, 2012 at 12:56 PM, Vijay Raju <vijay...@gmail.com> wrote:

Hi Andrei,

I guess the the line should be:

"${@oe_filter_out('${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.gz', '${SRC_URI}', d)}"

".tar.gz" instead of ".tar.bz2"

Can you prepare a proper patch for it?

 

[Andrei Gherzan]

I will fix it tonight.

ag

--
--
OpenEmbedded/Yocto Freescale ARM BSP - meta-f...@googlegroups.com
 
Source code of the BSP: http://github.com/Freescale/meta-fsl-arm
 
To cancel your subscription in this group send an e-mail to meta-fsl-arm...@googlegroups.com
For more options go to http://groups.google.com/group/meta-fsl-arm

[Andrei Gherzan]

On Wed, Oct 31, 2012 at 4:56 PM, Vijay Raju <vijay...@gmail.com> wrote:

Hi Andrei,

I guess the the line should be:

"${@oe_filter_out('${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.gz', '${SRC_URI}', d)}"

".tar.gz" instead of ".tar.bz2"

-Vijay

That is an append for the version from meta-oe not for the one in oe-core. That version is 173 and the SRC_URI there is this:

# version specific SRC_URI

SRC_URI = "${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.bz2 \

           file://0001-rip-put-doc-generation-it-depends-on-a-working-docto.patch \

           file://gtk-doc.make

So this append  should be OK.

Now on kernel.org i can't find the specified version of udev. So, it worked for me because this probably used a mirror where the bz2 archive was found. As i see it, this is a meta-oe issue now.

ag

[Otavio Salvador]

On Wed, Oct 31, 2012 at 8:21 PM, Andrei Gherzan <and...@gherzan.ro> wrote:

On Wed, Oct 31, 2012 at 4:56 PM, Vijay Raju <vijay...@gmail.com> wrote:

Hi Andrei,

I guess the the line should be:

"${@oe_filter_out('${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.gz', '${SRC_URI}', d)}"

".tar.gz" instead of ".tar.bz2"

-Vijay

That is an append for the version from meta-oe not for the one in oe-core. That version is 173 and the SRC_URI there is this:

# version specific SRC_URI

SRC_URI = "${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.bz2 \

           file://0001-rip-put-doc-generation-it-depends-on-a-working-docto.patch \

           file://gtk-doc.make

So this append  should be OK.

Now on kernel.org i can't find the specified version of udev. So, it worked for me because this probably used a mirror where the bz2 archive was found. As i see it, this is a meta-oe issue now.

I think I agree it needs to be fixed in meta-oe; are you going to take this one for fixing?

 

[Andrei Gherzan]

On Thu, Nov 1, 2012 at 12:06 PM, Otavio Salvador <ota...@ossystems.com.br> wrote:

On Wed, Oct 31, 2012 at 8:21 PM, Andrei Gherzan <and...@gherzan.ro> wrote:

On Wed, Oct 31, 2012 at 4:56 PM, Vijay Raju <vijay...@gmail.com> wrote:

Hi Andrei,

I guess the the line should be:

"${@oe_filter_out('${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.gz', '${SRC_URI}', d)}"

".tar.gz" instead of ".tar.bz2"

-Vijay

That is an append for the version from meta-oe not for the one in oe-core. That version is 173 and the SRC_URI there is this:

# version specific SRC_URI

SRC_URI = "${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.bz2 \

           file://0001-rip-put-doc-generation-it-depends-on-a-working-docto.patch \

           file://gtk-doc.make

So this append  should be OK.

Now on kernel.org i can't find the specified version of udev. So, it worked for me because this probably used a mirror where the bz2 archive was found. As i see it, this is a meta-oe issue now.

I think I agree it needs to be fixed in meta-oe; are you going to take this one for fixing?

Yes. Added in queue. 

ag 

[Otavio Salvador]

When sending it please add Eric in Cc so he can queue it to denzil as well.

 

[Andrei Gherzan]

On Thu, Nov 1, 2012 at 12:19 PM, Otavio Salvador <ota...@ossystems.com.br> wrote:

On Thu, Nov 1, 2012 at 8:15 AM, Andrei Gherzan <and...@gherzan.ro> wrote:

On Thu, Nov 1, 2012 at 12:06 PM, Otavio Salvador <ota...@ossystems.com.br> wrote:

On Wed, Oct 31, 2012 at 8:21 PM, Andrei Gherzan <and...@gherzan.ro> wrote:

On Wed, Oct 31, 2012 at 4:56 PM, Vijay Raju <vijay...@gmail.com> wrote:

Hi Andrei,

I guess the the line should be:

"${@oe_filter_out('${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.gz', '${SRC_URI}', d)}"

".tar.gz" instead of ".tar.bz2"

-Vijay

That is an append for the version from meta-oe not for the one in oe-core. That version is 173 and the SRC_URI there is this:

# version specific SRC_URI

SRC_URI = "${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.bz2 \

           file://0001-rip-put-doc-generation-it-depends-on-a-working-docto.patch \

           file://gtk-doc.make

So this append  should be OK.

Now on kernel.org i can't find the specified version of udev. So, it worked for me because this probably used a mirror where the bz2 archive was found. As i see it, this is a meta-oe issue now.

I think I agree it needs to be fixed in meta-oe; are you going to take this one for fixing?

Yes. Added in queue. 

When sending it please add Eric in Cc so he can queue it to denzil as well.

Found this as an old email that i forgot to look into. So udev was removed from meta-oe and oe-core uses the correct package source.

ag