Warnings in memcachepp 0.12.1 (-Wall)

[Maxim Perenesenko]

Hi,

There are a lot of minor warnings during building current version of
memcache++, like the attached below.

As the library is a header-only, any cpp file, which uses it,
generates a lot of output and locating real errors and warnings is
becoming a very hard and tedious task.

BTW, these warnings are very easy to fix. I would fix them easy.
However, I am not very familiar with git and do not know formal
procedure of committing into the project as well.

Using: g++ (Ubuntu 4.4.3-4ubuntu5) 4.4.3, -Wall

./extern/memcachepp/memcachepp/memcache/detail/tags.hpp
17: warning: extra ‘;’
19: warning: extra ‘;’
21: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/detail/directives/server.hpp
31: warning: extra ‘;’
36: warning: extra ‘;’ 36: warning: extra ‘;’
42: warning: extra ‘;’ 42: warning: extra ‘;’
44: warning: extra ‘;’ 44: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/tags.hpp
19: warning: extra ‘;’
21: warning: extra ‘;’ 21: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/server_pool.hpp
39: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/detail/directives/pool.hpp
41: warning: extra ‘;’
46: warning: extra ‘;’ 46: warning: extra ‘;’
71: warning: extra ‘;’ 71: warning: extra ‘;’
96: warning: extra ‘;’ 96: warning: extra ‘;’
99: warning: extra ‘;’ 99: warning: extra ‘;’
104: warning: extra ‘;’ 104: warning: extra ‘;’
108: warning: extra ‘;’ 108: warning: extra ‘;’
113: warning: extra ‘;’ 113: warning: extra ‘;’
115: warning: extra ‘;’ 115: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/detail/directives/get.hpp
30: warning: extra ‘;’
38: warning: extra ‘;’ 38: warning: extra ‘;’
43: warning: extra ‘;’ 43: warning: extra ‘;’
45: warning: extra ‘;’ 45: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/detail/expiration.hpp
21: warning: extra ‘;’
28: warning: extra ‘;’ 28: warning: extra ‘;’
35: warning: extra ‘;’ 35: warning: extra ‘;’
37: warning: extra ‘;’ 37: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/detail/directives/set.hpp
34: warning: extra ‘;’
45: warning: extra ‘;’ 45: warning: extra ‘;’
50: warning: extra ‘;’ 50: warning: extra ‘;’
55: warning: extra ‘;’ 55: warning: extra ‘;’
60: warning: extra ‘;’ 60: warning: extra ‘;’
65: warning: extra ‘;’ 65: warning: extra ‘;’
67: warning: extra ‘;’ 67: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/detail/directives/add.hpp
46: warning: extra ‘;’
51: warning: extra ‘;’ 51: warning: extra ‘;’
56: warning: extra ‘;’ 56: warning: extra ‘;’
61: warning: extra ‘;’ 61: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/detail/directives/replace.hpp
46: warning: extra ‘;’
51: warning: extra ‘;’ 51: warning: extra ‘;’
56: warning: extra ‘;’ 56: warning: extra ‘;’
61: warning: extra ‘;’ 61: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/detail/directives/raw_get.hpp
30: warning: extra ‘;’
38: warning: extra ‘;’ 38: warning: extra ‘;’
43: warning: extra ‘;’ 43: warning: extra ‘;’
45: warning: extra ‘;’ 45: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/detail/directives/raw_set.hpp
34: warning: extra ‘;’
45: warning: extra ‘;’ 45: warning: extra ‘;’
50: warning: extra ‘;’ 50: warning: extra ‘;’
72: warning: extra ‘;’ 72: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/detail/directives/
raw_append.hpp
31: warning: extra ‘;’
46: warning: extra ‘;’ 46: warning: extra ‘;’
51: warning: extra ‘;’ 51: warning: extra ‘;’
56: warning: extra ‘;’ 56: warning: extra ‘;’
61: warning: extra ‘;’ 61: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/detail/directives/
raw_prepend.hpp
31: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/detail/directives/raw_add.hpp
33: warning: extra ‘;’
48: warning: extra ‘;’ 48: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/detail/directives/
raw_replace.hpp
31: warning: extra ‘;’
46: warning: extra ‘;’ 46: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/detail/directives/delete.hpp
27: warning: extra ‘;’
34: warning: extra ‘;’ 34: warning: extra ‘;’
39: warning: extra ‘;’ 39: warning: extra ‘;’
41: warning: extra ‘;’ 41: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/detail/directives/connect.hpp
15: warning: extra ‘;’
26: warning: extra ‘;’ 26: warning: extra ‘;’
32: warning: extra ‘;’ 32: warning: extra ‘;’
34: warning: extra ‘;’ 34: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/detail/directives/commit.hpp
15: warning: extra ‘;’
26: warning: extra ‘;’ 26: warning: extra ‘;’
32: warning: extra ‘;’ 32: warning: extra ‘;’
34: warning: extra ‘;’ 34: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/detail/read_handler.hpp
71: warning: extra ‘;’
73: warning: extra ‘;’ 73: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/detail/deserializer.hpp
32: warning: extra ‘;’
34: warning: extra ‘;’ 34: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/parser.hpp
173: warning: extra ‘;’
175: warning: extra ‘;’ 175: warning: extra ‘;’
177: warning: extra ‘;’ 177: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/policies/tags.hpp
15: warning: extra ‘;’
17: warning: extra ‘;’ 17: warning: extra ‘;’
19: warning: extra ‘;’ 19: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/policies/default_threading.hpp
25: warning: extra ‘;’
27: warning: extra ‘;’ 27: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/policies/boost_threading.hpp
44: warning: extra ‘;’
46: warning: extra ‘;’ 46: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/policies/default_hash.hpp
26: warning: extra ‘;’
28: warning: extra ‘;’ 28: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/policies/
binary_interchange.hpp
27: warning: extra ‘;’
29: warning: extra ‘;’ 29: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/policies/text_interchange.hpp
26: warning: extra ‘;’
28: warning: extra ‘;’ 28: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/policies/string_preserve.hpp
37: warning: extra ‘;’
48: warning: extra ‘;’ 48: warning: extra ‘;’
63: warning: extra ‘;’ 63: warning: extra ‘;’
65: warning: extra ‘;’ 65: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/handle.hpp
117: warning: extra ‘;’
161: warning: extra ‘;’ 161: warning: extra ‘;’
205: warning: extra ‘;’ 205: warning: extra ‘;’
228: warning: extra ‘;’ 228: warning: extra ‘;’
381: warning: extra ‘;’ 381: warning: extra ‘;’
393: warning: extra ‘;’ 393: warning: extra ‘;’
596: warning: extra ‘;’ 596: warning: extra ‘;’
779: warning: extra ‘;’ 779: warning: extra ‘;’
976: warning: extra ‘;’ 976: warning: extra ‘;’
1093: warning: extra ‘;’ 1093: warning: extra ‘;’
1099: warning: extra ‘;’ 1099: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/request.hpp
33: warning: extra ‘;’
171: warning: extra ‘;’
177: warning: extra ‘;’ 177: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/fluent/wrap.hpp
39: warning: extra ‘;’
59: warning: extra ‘;’ 59: warning: extra ‘;’
61: warning: extra ‘;’ 61: warning: extra ‘;’
63: warning: extra ‘;’ 63: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/fluent/get.hpp
35: warning: extra ‘;’
46: warning: extra ‘;’ 46: warning: extra ‘;’
48: warning: extra ‘;’ 48: warning: extra ‘;’
50: warning: extra ‘;’ 50: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/fluent/key.hpp
106: warning: extra ‘;’
192: warning: extra ‘;’ 192: warning: extra ‘;’
198: warning: extra ‘;’ 198: warning: extra ‘;’
200: warning: extra ‘;’ 200: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache.hpp
57: warning: extra ‘;’
./extern/memcachepp/memcachepp/memcache/parser.hpp
157: warning: unused variable ‘ok’

--
Maxim

[Dean Michael Berris]

Hi Maxim,

On Oct 13, 7:03 pm, Maxim Perenesenko <171...@gmail.com> wrote:
>
> There are a lot of minor warnings during building current version of
> memcache++, like the attached below.
>

Oh boy, you're right. I haven't been testing with -Wall, I should do
that from now on.

> As the library is a header-only, any cpp file, which uses it,
> generates a lot of output and locating real errors and warnings is
> becoming a very hard and tedious task.
>
> BTW, these warnings are very easy to fix. I would fix them easy.
> However, I am not very familiar with git and do not know formal
> procedure of committing into the project as well.
>

It's really very easy, you can go to http://github.com/mikhailberis/memcachepp
and create a fork. This requires that you have a GitHub account set up
correctly.

Once you have your fork of the project, you can clone it to your local
machine and start hacking on it locally. Once you've committed your
changes locally, you can then push your changes to your fork in
GitHub. When you're ready to have your changes merged to my
repository, you can go ahead and submit a pull request.

You can read more about forking here:

http://help.github.com/forking

And submitting pull requests here:

http://help.github.com/pull-requests

Thanks for trying it out -- let me know how things go.

[snip warnings output]

--
Dean Michael Berris
deanberris.com