Shaded kryo

[Bruce Ritchie]

Hi all,

First, much appreciate the work put into this project! I'm just getting started with testing it in the new system arch I'm helping implement into AWS and so far it seems to work as advertised.

Has there been any thought put into potential conflicts between the version of kryo the msm depends on and potentially different versions within webapps under tomcat 8.0? My understanding is that libraries under /lib are shared (parent classloader or similar) into the classloader(s) used to load jars in webapp/WEB-INF/lib. I'm hesitant to push the latest msm version because of potential kryo conflicts (and it's dependencies such as asm, etc) between 4.0.0 and earlier versions.

A shaded kryo dependency might be a good solution to this potential issue. I saw there is a shaded kryo jar in the kryo project but that one just shades it's asm dependency, not kryo itself.

Thanks!

Bruce

[Martin Grotzke]

Hi Bruce,

you're right, if the application uses a different kryo version this will cause issues. It should be possible that msm provides msm-kryo-serializer with shaded kryo (and dependencies). Do you want to submit a pull request?

Cheers,
Martin

--

---
You received this message because you are subscribed to the Google Groups "memcached-session-manager" group.
To unsubscribe from this group and stop receiving emails from it, send an email to memcached-session-...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Bruce Ritchie]

Thanks for the reply Martin. I'll try and find some time to put together a pom that shades kryo and dependencies and submit a pull request. Hopefully in the next week or two :)

Bruce