Screen sharing extension for chrome

[William MANCON]

Hi !
Is the Janus extension provided by the team is open source ? I can't find the github project.

[Lorenzo Miniero]

No it's not part of the project.

Lorenzo

[William MANCON]

Ok, can I add an open source extension to the project ?

On an old version of firefox (Linux) I can use screen sharing without extension, but on a recent windows version, il fail with "webrtc error :{}". I'm goin to look deeper for what reason.
But i think it is usefull to have a firefox extension too, to select the tab, window, or screen we want to share.

WM.

[Lorenzo Miniero]

You can use whatever custom extension you want on the client side; janus.js uses the one we conceived with its specific semantics, and so using a different one there would mean changing the code in janus.js accordingly. We won't include any extension code as part of the github project, sorry, that's a client side matter.

About Firefox, it doesn't make use of extensions as Chrome for ScreenSharing. They employ a whitelist that can be used to identify website that can start a screensharing session: AFAIK this whitelist is both global (they populate a list of "good" services, if you ask them) and local, meaning each browser user needs to add the website to their about:config. Not sure how this works, though, you'll have to look around.

Lorenzo

[William MANCON]

Ok, as usual, thank you for your answer :)

[sol....@rise.tech]

Hey, this is also an issue for us, we want to provide screensharing but cannot expect our users to provide a non-branded extension that does not have tight origin controls.

Migrating from licode we already have matching extension with a slightly different API, so our only concern is that we would like not to modify our janus.js so that we don't have to keep the patch alive.

Would you mind a PR for janus.js that basically exposes the screensharing-extension parts (Janus.isExtensionEnabled, https://github.com/meetecho/janus-gateway/blob/master/html/janus.js#L1974-L1984, https://github.com/meetecho/janus-gateway/blob/master/html/janus.js#L2024-L2062) so that they can be overloaded either with a callback passed in the Janus constructor or with something like Janus.isExtensionEnabled = ...; Janus.extensionGetSourceId = ...?
The fallback would be current code/behaviour of course.

[Lorenzo Miniero]

Of course, if you can provide a PR we'd certainly consider it. Please no further additions to the constructor, though: use the existing dependencies mechanism for that (which means putting the current approach in useDefaultDependencies).

L.