Changes in GROParser to make it cythonized

[f201...@goa.bits-pilani.ac.in]

Hello,

I have made changes in the GROParser and created a cythonized version(very basic changes). It gives an improvement of 0.05 seconds on average on a 2mb gro file. This is not much given that cythonization is not extensively done. I want some tips and suggestions to make it more cythonized, so should I send a PR to review the changes?

[Oliver Beckstein]

Yes, please create a PR. This is the easiest way for us to look at code and to keep a focused discussion in one place. 

Oliver

--

Oliver Beckstein

email: orbe...@gmail.com

Am Mar 27, 2019 um 09:08 schrieb f201...@goa.bits-pilani.ac.in:

Hello,

I have made changes in the GROParser and created a cythonized version(very basic changes). It gives an improvement of 0.05 seconds on average on a 2mb gro file. This is not much given that cythonization is not extensively done. I want some tips and suggestions to make it more cythonized, so should I send a PR to review the changes?

--
You received this message because you are subscribed to the Google Groups "MDnalysis discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mdnalysis-discus...@googlegroups.com.
To post to this group, send email to mdnalysis-...@googlegroups.com.
Visit this group at https://groups.google.com/group/mdnalysis-discussion.
For more options, visit https://groups.google.com/d/optout.

[Fenil Suchak]

Done @Oliver Beckstein.