[Midnight Commander] #4560: Segfault when attempt to enter deleted archive (in extfs_open_and_read_archive())
Ticket System
extfs_open_and_read_archive())
--------------------------+------------------------------
Reporter: cieply | Type: defect
Status: new | Priority: major
Milestone: | Component: mc-vfs
Version: 4.8.31 | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------+------------------------------
I stumbled upon this error when mc segfaulted when tried to open/enter
archive.
Turned out the archive was deleted in other terminal but still was on the
screen of mc in the first one.
Same crash happens with zip, 7z, rar but not with tar. The latter shows
error box: \`Cannot open tar archive\n /path/to/file'.
To reproduce one needs to put archive (any, but tar) somewhere, switch to
another terminal and delete that file. Then switch back to the first mc
and enter the archive.
According to gdb it happens in extfs_open_and_read_archive() function (log
attached).
--
Ticket URL: <http://www.midnight-commander.org/ticket/4560>
Midnight Commander <https://midnight-commander.org>
Midnight Development Center
Ticket System
extfs_open_and_read_archive())
Reporter: cieply | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.32
Component: mc-vfs | Version: 4.8.31
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: on review | Votes for changeset:
--------------------------+--------------------------------
Changes (by andrew_b):
* status: new => accepted
* owner: => andrew_b
* branch_state: no branch => on review
* milestone: => 4.8.32
Comment:
Branch: 4560_extfs_open_deleted_archive
changeset:f3a936d9a52582f6f7bcf0e2a8313682705a2b35
--
Ticket URL: <http://www.midnight-commander.org/ticket/4560#comment:1>
Ticket System
extfs_open_and_read_archive())
Reporter: cieply | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.32
Component: mc-vfs | Version: 4.8.31
Blocked By: | Blocking:
Branch state: on review | Votes for changeset:
--------------------------+--------------------------------
Comment (by cieply):
Checked that patch - it works.
--
Ticket URL: <http://www.midnight-commander.org/ticket/4560#comment:2>
Ticket System
extfs_open_and_read_archive())
Reporter: cieply | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.32
Component: mc-vfs | Version: 4.8.31
Blocked By: | Blocking:
Branch state: approved | Votes for changeset: cieply andrew_b
-------------------------+---------------------------------------
Changes (by andrew_b):
* votes: => cieply andrew_b
* branch_state: on review => approved
Comment:
Thanks!
--
Ticket URL: <http://www.midnight-commander.org/ticket/4560#comment:3>
Ticket System
extfs_open_and_read_archive())
Reporter: cieply | Owner: andrew_b
Type: defect | Status: testing
Priority: major | Milestone: 4.8.32
Component: mc-vfs | Version: 4.8.31
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
-----------------------+----------------------------------------
Changes (by andrew_b):
* status: accepted => testing
* votes: cieply andrew_b => committed-master
* resolution: => fixed
* branch_state: approved => merged
Comment:
Merged to master: [b68243df1e9d0fbba578e015eb0ac71e7b5a7d93].
--
Ticket URL: <http://www.midnight-commander.org/ticket/4560#comment:4>
Ticket System
extfs_open_and_read_archive())
Reporter: cieply | Owner: andrew_b
Priority: major | Milestone: 4.8.32
Component: mc-vfs | Version: 4.8.31
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
-----------------------+----------------------------------------
Changes (by andrew_b):
* status: testing => closed
--
Ticket URL: <http://www.midnight-commander.org/ticket/4560#comment:5>