[Midnight Commander] #4463: ncurses library is duplicated in MCLIBS

1 view
Skip to first unread message

Ticket System

unread,
May 19, 2023, 2:19:33 PM5/19/23
to karl...@gmail.com, mc-...@googlegroups.com
#4463: ncurses library is duplicated in MCLIBS
--------------------------------+-----------------------------------
Reporter: karlson2k | Type: defect
Status: new | Priority: major
Milestone: Future Releases | Component: compilation
Version: master | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------------+-----------------------------------
AC_SEARCH_LIBS macro adds required library to 'LIBS' variable.
Currently 'LIBS' could be appended to 'MCLIBS' several times leading to
duplication of found values.

The suggested patches fix duplication for 'stdscr' function detection.
Additionally patches fix potential problematic situation when 'addwstr' or
'has_colors' detected in one ncurses library (for example 'ncurses'),
while 'stdscr' detected in other ncurses library (for example 'curses').
Such combination leads to problems.

The fix: https://github.com/MidnightCommander/mc/pull/187

--
Ticket URL: <http://www.midnight-commander.org/ticket/4463>
Midnight Commander <https://midnight-commander.org>
Midnight Development Center

Ticket System

unread,
May 19, 2023, 2:44:16 PM5/19/23
to karl...@gmail.com, andrew....@gmail.com, mc-...@googlegroups.com
#4463: ncurses library is duplicated in MCLIBS
----------------------------+--------------------------------
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Resolution: | Keywords:

Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
----------------------------+--------------------------------
Changes (by andrew_b):

* owner: => andrew_b
* status: new => accepted
* milestone: Future Releases => 4.8.30


--
Ticket URL: <http://www.midnight-commander.org/ticket/4463#comment:1>

Ticket System

unread,
May 19, 2023, 2:49:30 PM5/19/23
to karl...@gmail.com, andrew....@gmail.com, mc-...@googlegroups.com
#4463: ncurses library is duplicated in MCLIBS
----------------------------+--------------------------------
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Resolution: | Keywords:

Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
----------------------------+--------------------------------

Comment (by andrew_b):

Related to #3628.

--
Ticket URL: <http://www.midnight-commander.org/ticket/4463#comment:2>

Ticket System

unread,
May 20, 2023, 2:00:01 PM5/20/23
to karl...@gmail.com, andrew....@gmail.com, mc-...@googlegroups.com
#4463: ncurses library is duplicated in MCLIBS
----------------------------+--------------------------------
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: on review | Votes for changeset:
----------------------------+--------------------------------
Changes (by andrew_b):

* branch_state: no branch => on review


Comment:

Thanks for the patch!

Branch: 4463_ncurses_libs
changeset:92ae4c6b2027315d32059e8fed2c601a0dff1070

--
Ticket URL: <http://www.midnight-commander.org/ticket/4463#comment:3>

Ticket System

unread,
May 20, 2023, 2:00:26 PM5/20/23
to karl...@gmail.com, andrew....@gmail.com, mc-...@googlegroups.com
#4463: ncurses library is duplicated in MCLIBS
----------------------------+--------------------------------
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: approved | Votes for changeset: andrew_b
----------------------------+--------------------------------
Changes (by andrew_b):

* votes: => andrew_b
* branch_state: on review => approved


--
Ticket URL: <http://www.midnight-commander.org/ticket/4463#comment:4>

Ticket System

unread,
May 20, 2023, 2:01:28 PM5/20/23
to karl...@gmail.com, andrew....@gmail.com, mc-...@googlegroups.com
#4463: ncurses library is duplicated in MCLIBS
----------------------------+----------------------------------------
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: testing

Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Resolution: fixed | Keywords:
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------
Changes (by andrew_b):

* status: accepted => testing
* votes: andrew_b => committed-master
* resolution: => fixed
* branch_state: approved => merged


Comment:

Merged to master: [f17ebfd2a5c0f7e8a1284e2f1dc9119cfa0a1304].

--
Ticket URL: <http://www.midnight-commander.org/ticket/4463#comment:5>

Ticket System

unread,
May 20, 2023, 2:02:17 PM5/20/23
to karl...@gmail.com, andrew....@gmail.com, mc-...@googlegroups.com
#4463: ncurses library is duplicated in MCLIBS
----------------------------+----------------------------------------
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: closed

Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Resolution: fixed | Keywords:
Blocked By: | Blocking:

Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------
Changes (by andrew_b):

* status: testing => closed


--
Ticket URL: <http://www.midnight-commander.org/ticket/4463#comment:6>

Reply all
Reply to author
Forward
0 new messages