`po` directory needs to be treated specially. It does not fully use
automake macros and `SED` is not substituted in generated Makefiles.
The only way to add new automatically substituted variable to the Makefile
is to add it to Makefile.in.in, however this file is replaced
automatically by `autopoint` (with `-f` flag).
All other files, like `Makevars` or `Rules-pot-defaults`, are not
processed by configure for variable substitution.
The best way to use `sed` command in this dir is to rely on shell
automatic substitution. It does not use `sed` found by `configure`, but
the script is portable enough, so with the suggest patch "make dist" works
without overcomplication.
The suggested fix: https://github.com/MidnightCommander/mc/pull/191
--
Ticket URL: <http://www.midnight-commander.org/ticket/4466>
Midnight Commander <https://midnight-commander.org>
Midnight Development Center
* owner: => andrew_b
* status: new => accepted
* milestone: Future Releases => 4.8.30
--
Ticket URL: <http://www.midnight-commander.org/ticket/4466#comment:1>
* branch_state: no branch => on review
Comment:
Branch: 4466_sed.
changeset:1d7d9a832eddd7e9813919744d03f4e00ab8d68d
--
Ticket URL: <http://www.midnight-commander.org/ticket/4466#comment:2>
* votes: => andrew_b
* branch_state: on review => approved
--
Ticket URL: <http://www.midnight-commander.org/ticket/4466#comment:3>
* status: accepted => testing
* votes: andrew_b => committed-master
* resolution: => fixed
* branch_state: approved => merged
Comment:
Thanks!
Merged to master: [ec3f142b86a1d900587798c0e649216fc1db1d2a].
--
Ticket URL: <http://www.midnight-commander.org/ticket/4466#comment:4>
* status: testing => closed
--
Ticket URL: <http://www.midnight-commander.org/ticket/4466#comment:5>
Comment (by karlson2k):
You are welcome.
I've tested the git master. Now `dist` could be made (tested on Debian
Sid) and then mc could be built on Solaris.
However, there are a few compiler warnings, including the warning
introduced by this patch:
{{{
info.c: In function ‘info_show_info’:
info.c:264:27: warning: unused variable ‘attr’ [-Wunused-variable]
264 | unsigned long attr;
| ^~~~
}}}
The alternative patch could fix this warning as well.
--
Ticket URL: <http://www.midnight-commander.org/ticket/4466#comment:6>