[Midnight Commander] #4466: "make dist" failed with error in "po" dir

0 views
Skip to first unread message

Ticket System

unread,
May 21, 2023, 10:20:02 AM5/21/23
to karl...@gmail.com, mc-...@googlegroups.com
#4466: "make dist" failed with error in "po" dir
--------------------------------+-----------------------------------
Reporter: karlson2k | Type: defect
Status: new | Priority: major
Milestone: Future Releases | Component: compilation
Version: master | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------------+-----------------------------------
This is a follow-up for #4459.

`po` directory needs to be treated specially. It does not fully use
automake macros and `SED` is not substituted in generated Makefiles.
The only way to add new automatically substituted variable to the Makefile
is to add it to Makefile.in.in, however this file is replaced
automatically by `autopoint` (with `-f` flag).
All other files, like `Makevars` or `Rules-pot-defaults`, are not
processed by configure for variable substitution.
The best way to use `sed` command in this dir is to rely on shell
automatic substitution. It does not use `sed` found by `configure`, but
the script is portable enough, so with the suggest patch "make dist" works
without overcomplication.

The suggested fix: https://github.com/MidnightCommander/mc/pull/191

--
Ticket URL: <http://www.midnight-commander.org/ticket/4466>
Midnight Commander <https://midnight-commander.org>
Midnight Development Center

Ticket System

unread,
May 21, 2023, 12:40:49 PM5/21/23
to karl...@gmail.com, andrew....@gmail.com, mc-...@googlegroups.com
#4466: "make dist" failed with error in "po" dir
----------------------------+--------------------------------
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Resolution: | Keywords:

Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
----------------------------+--------------------------------
Changes (by andrew_b):

* owner: => andrew_b
* status: new => accepted
* milestone: Future Releases => 4.8.30


--
Ticket URL: <http://www.midnight-commander.org/ticket/4466#comment:1>

Ticket System

unread,
May 21, 2023, 1:26:36 PM5/21/23
to karl...@gmail.com, andrew....@gmail.com, mc-...@googlegroups.com
#4466: "make dist" failed with error in "po" dir
----------------------------+--------------------------------
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: on review | Votes for changeset:
----------------------------+--------------------------------
Changes (by andrew_b):

* branch_state: no branch => on review


Comment:

Branch: 4466_sed.
changeset:1d7d9a832eddd7e9813919744d03f4e00ab8d68d

--
Ticket URL: <http://www.midnight-commander.org/ticket/4466#comment:2>

Ticket System

unread,
May 21, 2023, 1:27:04 PM5/21/23
to karl...@gmail.com, andrew....@gmail.com, mc-...@googlegroups.com
#4466: "make dist" failed with error in "po" dir
----------------------------+--------------------------------
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: approved | Votes for changeset: andrew_b
----------------------------+--------------------------------
Changes (by andrew_b):

* votes: => andrew_b
* branch_state: on review => approved


--
Ticket URL: <http://www.midnight-commander.org/ticket/4466#comment:3>

Ticket System

unread,
May 21, 2023, 1:27:55 PM5/21/23
to karl...@gmail.com, andrew....@gmail.com, mc-...@googlegroups.com
#4466: "make dist" failed with error in "po" dir
----------------------------+----------------------------------------
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: testing

Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Resolution: fixed | Keywords:
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------
Changes (by andrew_b):

* status: accepted => testing
* votes: andrew_b => committed-master
* resolution: => fixed
* branch_state: approved => merged


Comment:

Thanks!

Merged to master: [ec3f142b86a1d900587798c0e649216fc1db1d2a].

--
Ticket URL: <http://www.midnight-commander.org/ticket/4466#comment:4>

Ticket System

unread,
May 21, 2023, 1:28:34 PM5/21/23
to karl...@gmail.com, andrew....@gmail.com, mc-...@googlegroups.com
#4466: "make dist" failed with error in "po" dir
----------------------------+----------------------------------------
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: closed

Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Resolution: fixed | Keywords:
Blocked By: | Blocking:

Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------
Changes (by andrew_b):

* status: testing => closed


--
Ticket URL: <http://www.midnight-commander.org/ticket/4466#comment:5>

Ticket System

unread,
May 22, 2023, 3:21:43 AM5/22/23
to karl...@gmail.com, andrew....@gmail.com, mc-...@googlegroups.com
#4466: "make dist" failed with error in "po" dir
----------------------------+----------------------------------------
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: closed
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Resolution: fixed | Keywords:
Blocked By: | Blocking:

Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------

Comment (by karlson2k):

You are welcome.

I've tested the git master. Now `dist` could be made (tested on Debian
Sid) and then mc could be built on Solaris.

However, there are a few compiler warnings, including the warning
introduced by this patch:

{{{
info.c: In function ‘info_show_info’:
info.c:264:27: warning: unused variable ‘attr’ [-Wunused-variable]
264 | unsigned long attr;
| ^~~~
}}}
The alternative patch could fix this warning as well.

--
Ticket URL: <http://www.midnight-commander.org/ticket/4466#comment:6>

Reply all
Reply to author
Forward
0 new messages