[Midnight Commander] #4462: Build failed if ncurses used without --with-ncurses-includes= configure parameter

1 view
Skip to first unread message

Ticket System

unread,
May 19, 2023, 2:11:43 PM5/19/23
to karl...@gmail.com, mc-...@googlegroups.com
#4462: Build failed if ncurses used without --with-ncurses-includes= configure
parameter
--------------------------------+-------------------------------
Reporter: karlson2k | Type: defect
Status: new | Priority: major
Milestone: Future Releases | Component: mc-core
Version: master | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------------+-------------------------------
If ncurses location is not specified by configure parameters like '--with-
ncurses-includes=/some/dir' then automatic detection at compiler/system
default location is used in configure.
With automatic detection the header 'ncurses/term.h' is not checked
therefore macro HAVE_NCURSES_TERM_H is not defined.

This leads to inclusion of system <term.h> which is not compatible with
ncurses headers.

The simple fix is just addition of ncurses/term.h header detection to
configure.

The suggested fix: https://github.com/MidnightCommander/mc/pull/186

--
Ticket URL: <http://www.midnight-commander.org/ticket/4462>
Midnight Commander <https://midnight-commander.org>
Midnight Development Center

Ticket System

unread,
May 19, 2023, 2:15:57 PM5/19/23
to karl...@gmail.com, andrew....@gmail.com, mc-...@googlegroups.com
#4462: Build failed if ncurses used without --with-ncurses-includes= configure
parameter
----------------------------+--------------------------------
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Resolution: | Keywords:

Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
----------------------------+--------------------------------
Changes (by andrew_b):

* status: new => accepted
* owner: => andrew_b
* component: mc-core => compilation
* milestone: Future Releases => 4.8.30


--
Ticket URL: <http://www.midnight-commander.org/ticket/4462#comment:1>

Ticket System

unread,
May 20, 2023, 1:48:05 PM5/20/23
to karl...@gmail.com, andrew....@gmail.com, mc-...@googlegroups.com
#4462: Build failed if ncurses used without --with-ncurses-includes= configure
parameter
----------------------------+--------------------------------
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: on review | Votes for changeset:
----------------------------+--------------------------------
Changes (by andrew_b):

* branch_state: no branch => on review


Comment:

Thanks for the patch!

Branch: 4462_ncurses_includes
changeset:1f732f0a140cb069d9477ef4c094330b7e6d2162

--
Ticket URL: <http://www.midnight-commander.org/ticket/4462#comment:2>

Ticket System

unread,
May 20, 2023, 1:48:30 PM5/20/23
to karl...@gmail.com, andrew....@gmail.com, mc-...@googlegroups.com
#4462: Build failed if ncurses used without --with-ncurses-includes= configure
parameter
----------------------------+--------------------------------
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: approved | Votes for changeset: andrew_b
----------------------------+--------------------------------
Changes (by andrew_b):

* votes: => andrew_b
* branch_state: on review => approved


--
Ticket URL: <http://www.midnight-commander.org/ticket/4462#comment:3>

Ticket System

unread,
May 20, 2023, 1:50:05 PM5/20/23
to karl...@gmail.com, andrew....@gmail.com, mc-...@googlegroups.com
#4462: Build failed if ncurses used without --with-ncurses-includes= configure
parameter
----------------------------+----------------------------------------
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: testing

Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Resolution: fixed | Keywords:
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------
Changes (by andrew_b):

* status: accepted => testing
* votes: andrew_b => committed-master
* resolution: => fixed
* branch_state: approved => merged


Comment:

Merged to master: [5c9a145c3d76e560323e8e24c597fd8965af3099].

--
Ticket URL: <http://www.midnight-commander.org/ticket/4462#comment:4>

Ticket System

unread,
May 20, 2023, 1:51:30 PM5/20/23
to karl...@gmail.com, andrew....@gmail.com, mc-...@googlegroups.com
#4462: Build failed if ncurses used without --with-ncurses-includes= configure
parameter
----------------------------+----------------------------------------
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: closed

Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Resolution: fixed | Keywords:
Blocked By: | Blocking:

Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------
Changes (by andrew_b):

* status: testing => closed


--
Ticket URL: <http://www.midnight-commander.org/ticket/4462#comment:5>

Reply all
Reply to author
Forward
0 new messages