[Midnight Commander] #4426: Prepare for release mc-4.8.30
Ticket System
-------------------------------+--------------------------
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.30
Component: adm | Version:
Keywords: | Blocked By:
Blocking: | Branch state: no branch
Votes for changeset: |
-------------------------------+--------------------------
--
Ticket URL: <http://www.midnight-commander.org/ticket/4426>
Midnight Commander <https://midnight-commander.org>
Midnight Development Center
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.30
Component: adm | Version:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Comment (by andrew_b):
Branch: 4426_cleanup
Initial changeset:70a4ff6d55c074929cf239acfd9ba5acbf343cad
--
Ticket URL: <http://www.midnight-commander.org/ticket/4426#comment:1>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.30
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Changes (by andrew_b):
* version: => master
Comment:
Merged to master: [8a91de70c4e7aba2dd01218c416f4135d049e1a4].
{{{
git log pretty=oneline a01fe3889..8a91de70c
}}}
--
Ticket URL: <http://www.midnight-commander.org/ticket/4426#comment:2>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.30
Resolution: | Keywords:
Branch state: no branch | Votes for changeset:
Comment (by andrew_b):
mc-4426-fix-implicit-function-declaration-warning.patch: applied.
Branch: 4426_cleanup
Initial changeset:728f5c1b0d5619b9599470b298b2198e899146b3
--
Ticket URL: <http://www.midnight-commander.org/ticket/4426#comment:4>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.30
Resolution: | Keywords:
Blocked By: | Blocking: 4438
Comment (by andrew_b):
Merge to master: [be3822cafab16519bf6934ebb594261c618080bb].
{{{
git log --pretty=oneline d845d0dc..be3822caf
}}}
--
Ticket URL: <http://www.midnight-commander.org/ticket/4426#comment:5>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.30
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Comment (by andrew_b):
Branch: 4426_cleanup
Initial changeset:8f4f2ffbb4f2959de37c91002d97effc1dd9c9f4
--
Ticket URL: <http://www.midnight-commander.org/ticket/4426#comment:7>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.30
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Comment (by zaytsev):
Added patch from closed GitHub PR.
--
Ticket URL: <http://www.midnight-commander.org/ticket/4426#comment:8>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.30
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Comment (by andrew_b):
pr-164-add-dylib-support.patch: applied.
--
Ticket URL: <http://www.midnight-commander.org/ticket/4426#comment:9>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.30
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Comment (by zaytsev):
Two more trivial patches from GitHub added.
--
Ticket URL: <http://www.midnight-commander.org/ticket/4426#comment:10>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.30
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Comment (by andrew_b):
pr-182-syntax-update-1.patch: applied
pr-181-syntax-update-2.patch: applied
--
Ticket URL: <http://www.midnight-commander.org/ticket/4426#comment:11>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.30
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Comment (by zaytsev):
Added a patch from GitHub to highlight *.zsh files as shell scripts.
--
Ticket URL: <http://www.midnight-commander.org/ticket/4426#comment:14>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.30
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Comment (by andrew_b):
pr-168.patch: applied.
--
Ticket URL: <http://www.midnight-commander.org/ticket/4426#comment:15>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.30
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset: committed-master
--------------------------+----------------------------------------
Changes (by andrew_b):
* votes: => committed-master
Comment:
Merged to master: [04b37639a9139921cf26c766e361c9546ed14541].
{{{
git log --oneline 7111f8aa3..04b37639a
}}}
--
Ticket URL: <http://www.midnight-commander.org/ticket/4426#comment:16>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.30
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset: committed-master
--------------------------+----------------------------------------
Comment (by zaytsev):
Got two warnings during the build on master:
{{{
../../../lib/tty/color-internal.c: In function
'tty_color_get_name_by_index':
../../../lib/tty/color-internal.c:187:34: warning: '%d' directive writing
between 1 and 11 bytes into a region of size 4 [-Wformat-overflow=]
187 | sprintf (name, "color%d", idx);
| ^~
../../../lib/tty/color-internal.c:187:28: note: directive argument in the
range [-2147483648, 255]
187 | sprintf (name, "color%d", idx);
| ^~~~~~~~~
../../../lib/tty/color-internal.c:187:13: note: 'sprintf' output between 7
and 17 bytes into a destination of size 9
187 | sprintf (name, "color%d", idx);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../../src/vfs/tar/tar-sparse.c: In function 'pax_decode_header':
../../../../src/vfs/tar/tar.c: In function 'tar_free_inode':
../../../../src/vfs/tar/tar.c:522:35: warning: unused parameter 'me'
[-Wunused-parameter]
522 | tar_free_inode (struct vfs_class *me, struct vfs_s_inode *ino)
| ~~~~~~~~~~~~~~~~~~^~
../../../../src/vfs/tar/tar-sparse.c:697:50: warning: comparison of
integer expressions of different signedness: '__off_t' {aka 'long int'}
and 'long unsigned int' [-Wsign-compare]
697 | || file->stat_info->stat.st_size < sp.offset + u)
|
--
Ticket URL: <http://www.midnight-commander.org/ticket/4426#comment:17>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.30
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset: committed-master
--------------------------+----------------------------------------
Comment (by zaytsev):
Built and pushed rc1 tarball. We really need to do something about Travis
now :( noticed that CI hasn't been run since January...
--
Ticket URL: <http://www.midnight-commander.org/ticket/4426#comment:18>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.30
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset: committed-master
--------------------------+----------------------------------------
Comment (by andrew_b):
Replying to [comment:17 zaytsev]:
> Got two warnings during the build on master:
Will be fixed in the next cleanup after release.
--
Ticket URL: <http://www.midnight-commander.org/ticket/4426#comment:19>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.30
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset: committed-master
--------------------------+----------------------------------------
Comment (by zaytsev):
I've got reply from support and hopefully Travis builds will be working
again, but now it complains about 1) warnings and 2) indentation. See
screenshot.
--
Ticket URL: <http://www.midnight-commander.org/ticket/4426#comment:20>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.30
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset: committed-master
--------------------------+----------------------------------------
Comment (by andrew_b):
{{{
CC tar-sparse.lo
../../../../src/vfs/tar/tar-sparse.c: In function ‘pax_decode_header’:
../../../../src/vfs/tar/tar-sparse.c:102:55: error: comparison of unsigned
expression < 0 is always false [-Werror=type-limits]
#define EXPR_SIGNED(e) (_GL_INT_NEGATE_CONVERT (e, 1) < 0)
^
../../../../src/vfs/tar/tar-sparse.c:156:6: note: in definition of macro
‘_GL_ADD_OVERFLOW’
((min) < 0 ? INT_ADD_RANGE_OVERFLOW (a, b, min, max) \
^
../../../../src/vfs/tar/tar-sparse.c:110:6: note: in expansion of macro
‘EXPR_SIGNED’
(EXPR_SIGNED (e) \
^
../../../../src/vfs/tar/tar-sparse.c:124:23: note: in expansion of macro
‘_GL_INT_MINIMUM’
_GL_INT_MINIMUM (_GL_INT_CONVERT (a, b)), \
^
../../../../src/vfs/tar/tar-sparse.c:182:5: note: in expansion of macro
‘_GL_BINARY_OP_OVERFLOW’
_GL_BINARY_OP_OVERFLOW (a, b, _GL_ADD_OVERFLOW)
^
../../../../src/vfs/tar/tar-sparse.c:699:66: note: in expansion of macro
‘INT_ADD_OVERFLOW’
if (!decode_num (&u, nbuf, TYPE_MAXIMUM (size_t)) ||
INT_ADD_OVERFLOW (sp.offset, u)
^
../../../../src/vfs/tar/tar-sparse.c:156:11: error: comparison of unsigned
expression < 0 is always false [-Werror=type-limits]
((min) < 0 ? INT_ADD_RANGE_OVERFLOW (a, b, min, max) \
^
../../../../src/vfs/tar/tar-sparse.c:123:3: note: in expansion of macro
‘_GL_ADD_OVERFLOW’
op_result_overflow (a, b, \
^
../../../../src/vfs/tar/tar-sparse.c:182:5: note: in expansion of macro
‘_GL_BINARY_OP_OVERFLOW’
_GL_BINARY_OP_OVERFLOW (a, b, _GL_ADD_OVERFLOW)
^
../../../../src/vfs/tar/tar-sparse.c:699:66: note: in expansion of macro
‘INT_ADD_OVERFLOW’
if (!decode_num (&u, nbuf, TYPE_MAXIMUM (size_t)) ||
INT_ADD_OVERFLOW (sp.offset, u)
^
../../../../src/vfs/tar/tar-sparse.c:128:10: error: comparison of unsigned
expression < 0 is always false [-Werror=type-limits]
((b) < 0 \
^
../../../../src/vfs/tar/tar-sparse.c:156:17: note: in expansion of macro
‘INT_ADD_RANGE_OVERFLOW’
((min) < 0 ? INT_ADD_RANGE_OVERFLOW (a, b, min, max) \
^
../../../../src/vfs/tar/tar-sparse.c:123:3: note: in expansion of macro
‘_GL_ADD_OVERFLOW’
op_result_overflow (a, b, \
^
../../../../src/vfs/tar/tar-sparse.c:182:5: note: in expansion of macro
‘_GL_BINARY_OP_OVERFLOW’
_GL_BINARY_OP_OVERFLOW (a, b, _GL_ADD_OVERFLOW)
^
../../../../src/vfs/tar/tar-sparse.c:699:66: note: in expansion of macro
‘INT_ADD_OVERFLOW’
if (!decode_num (&u, nbuf, TYPE_MAXIMUM (size_t)) ||
INT_ADD_OVERFLOW (sp.offset, u)
^
../../../../src/vfs/tar/tar-sparse.c:102:55: error: comparison of unsigned
expression < 0 is always false [-Werror=type-limits]
#define EXPR_SIGNED(e) (_GL_INT_NEGATE_CONVERT (e, 1) < 0)
^
../../../../src/vfs/tar/tar-sparse.c:129:18: note: in definition of macro
‘INT_ADD_RANGE_OVERFLOW’
? (a) < (min) - (b) \
^
../../../../src/vfs/tar/tar-sparse.c:123:3: note: in expansion of macro
‘_GL_ADD_OVERFLOW’
op_result_overflow (a, b, \
^
../../../../src/vfs/tar/tar-sparse.c:110:6: note: in expansion of macro
‘EXPR_SIGNED’
(EXPR_SIGNED (e) \
^
../../../../src/vfs/tar/tar-sparse.c:124:23: note: in expansion of macro
‘_GL_INT_MINIMUM’
_GL_INT_MINIMUM (_GL_INT_CONVERT (a, b)), \
^
../../../../src/vfs/tar/tar-sparse.c:182:5: note: in expansion of macro
‘_GL_BINARY_OP_OVERFLOW’
_GL_BINARY_OP_OVERFLOW (a, b, _GL_ADD_OVERFLOW)
^
../../../../src/vfs/tar/tar-sparse.c:699:66: note: in expansion of macro
‘INT_ADD_OVERFLOW’
if (!decode_num (&u, nbuf, TYPE_MAXIMUM (size_t)) ||
INT_ADD_OVERFLOW (sp.offset, u)
^
../../../../src/vfs/tar/tar-sparse.c:102:55: error: comparison of unsigned
expression < 0 is always false [-Werror=type-limits]
#define EXPR_SIGNED(e) (_GL_INT_NEGATE_CONVERT (e, 1) < 0)
^
../../../../src/vfs/tar/tar-sparse.c:130:12: note: in definition of macro
‘INT_ADD_RANGE_OVERFLOW’
: (max) - (b) < (a))
^
../../../../src/vfs/tar/tar-sparse.c:123:3: note: in expansion of macro
‘_GL_ADD_OVERFLOW’
op_result_overflow (a, b, \
^
../../../../src/vfs/tar/tar-sparse.c:114:6: note: in expansion of macro
‘EXPR_SIGNED’
(EXPR_SIGNED (e) \
^
../../../../src/vfs/tar/tar-sparse.c:125:23: note: in expansion of macro
‘_GL_INT_MAXIMUM’
_GL_INT_MAXIMUM (_GL_INT_CONVERT (a, b)))
^
../../../../src/vfs/tar/tar-sparse.c:182:5: note: in expansion of macro
‘_GL_BINARY_OP_OVERFLOW’
_GL_BINARY_OP_OVERFLOW (a, b, _GL_ADD_OVERFLOW)
^
../../../../src/vfs/tar/tar-sparse.c:699:66: note: in expansion of macro
‘INT_ADD_OVERFLOW’
if (!decode_num (&u, nbuf, TYPE_MAXIMUM (size_t)) ||
INT_ADD_OVERFLOW (sp.offset, u)
^
../../../../src/vfs/tar/tar-sparse.c:158:11: error: comparison of unsigned
expression < 0 is always false [-Werror=type-limits]
: (b) < 0 ? (a) <= (a) + (b) \
^
../../../../src/vfs/tar/tar-sparse.c:123:3: note: in expansion of macro
‘_GL_ADD_OVERFLOW’
op_result_overflow (a, b, \
^
../../../../src/vfs/tar/tar-sparse.c:182:5: note: in expansion of macro
‘_GL_BINARY_OP_OVERFLOW’
_GL_BINARY_OP_OVERFLOW (a, b, _GL_ADD_OVERFLOW)
^
../../../../src/vfs/tar/tar-sparse.c:699:66: note: in expansion of macro
‘INT_ADD_OVERFLOW���
if (!decode_num (&u, nbuf, TYPE_MAXIMUM (size_t)) ||
INT_ADD_OVERFLOW (sp.offset, u)
^
cc1: all warnings being treated as errors
}}}
I don't want modify the code from GNU tar and gnulib to pacify GCC. What
about of use
{{{
#pragma GCC diagnostic ignored "-Wtype-limits"
}}}
in tar-sparse.c?
--
Ticket URL: <http://www.midnight-commander.org/ticket/4426#comment:21>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.30
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset: committed-master
--------------------------+----------------------------------------
Comment (by zaytsev):
Well, one could try to send a path to tar and gnulib people, but if you
can't be bothered, then I think a pragma is OK to silence warnings for
stolen code. If we start modifying it again, then updating will become
more difficult... I think that it was quite a lot of work for you already
to bring our tar implementation up to date.
--
Ticket URL: <http://www.midnight-commander.org/ticket/4426#comment:22>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: closed
Priority: major | Milestone: 4.8.30
Component: adm | Version: master
Resolution: fixed | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset: committed-master
--------------------------+----------------------------------------
Changes (by zaytsev):
* status: new => closed
* resolution: => fixed
Comment:
> prepare repository for release
> download PO-translations from Transifex
> store translations in git repo
> download the hint translations from Transifex
> store translations in git repo
done
> create new NEWS wiki page
[[NEWS-4.8.31]]
> add content of current NEWS wiki page to the doc/NEWS
> new version in Trac
> new milestone in Trac
> create new tag in git
> create tar.(bz2|xz) package files
> make checksums for archives
> upload source packages and checksums
> run ssh midnightcommander@...
> update Wiki start page with latest release number
> write an announcement
> close ticket for release
> close current milestone
done
> create new ticket
#4490
--
Ticket URL: <http://www.midnight-commander.org/ticket/4426#comment:23>