[Midnight Commander] #4493: mc-4.8.30 fails to build on FreeBSD with ext2fs attribute support

7 views
Skip to first unread message

Ticket System

unread,
Aug 18, 2023, 8:48:20 PM8/18/23
to phil....@gmail.com, mc-...@googlegroups.com
#4493: mc-4.8.30 fails to build on FreeBSD with ext2fs attribute support
--------------------------+-----------------------------------
Reporter: phil | Type: defect
Status: new | Priority: major
Milestone: 4.8.31 | Component: compilation
Version: 4.8.30 | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------+-----------------------------------


--
Ticket URL: <http://www.midnight-commander.org/ticket/4493>
Midnight Commander <https://midnight-commander.org>
Midnight Development Center

Ticket System

unread,
Aug 19, 2023, 2:19:45 AM8/19/23
to phil....@gmail.com, mc-...@googlegroups.com
#4493: mc-4.8.30 fails to build on FreeBSD with ext2fs attribute support
----------------------------+------------------------------
Reporter: phil | Owner:

Type: defect | Status: new
Priority: major | Milestone: 4.8.31
Component: compilation | Version: 4.8.30
Resolution: | Keywords:

Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
----------------------------+------------------------------

Comment (by andrew_b):

There is no such issue on Linux. Please show config.log and output of
make.

--
Ticket URL: <http://www.midnight-commander.org/ticket/4493#comment:1>

Ticket System

unread,
Aug 19, 2023, 6:32:35 AM8/19/23
to phi...@krylov.eu, mc-...@googlegroups.com
#4493: mc-4.8.30 fails to build on FreeBSD with ext2fs attribute support
----------------------------+------------------------------
Reporter: phil | Owner:

Type: defect | Status: new
Priority: major | Milestone: 4.8.31
Component: compilation | Version: 4.8.30
Resolution: | Keywords:

Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
----------------------------+------------------------------

Comment (by phil):

Attached `config.log`. Relevant output of `make`:
{{{
Making all in local
gmake[6]: Entering directory '/usr/home/phil/freebsd-
ports/misc/mc/work/mc-4.8.30/src/vfs/local'
/bin/sh ../../../libtool --tag=CC --mode=compile cc -DHAVE_CONFIG_H -I.
-I../../.. -I/usr/local/include/glib-2.0
-I/usr/local/lib/glib-2.0/include -I/usr/
local/include -I../../.. -I/usr/local/include -DLIBICONV_PLUG
-I/usr/local/include -I/usr/local/include -I/usr/local/include -Wassign-
enum -Wbad-function-
cast -Wcomment -Wconditional-uninitialized -Wdeclaration-after-statement
-Wfloat-conversion -Wfloat-equal -Wformat -Wformat-security -Wimplicit
-Wimplicit-fal
lthrough -Wignored-qualifiers -Wlogical-not-parentheses -Wmissing-braces
-Wmissing-declarations -Wmissing-field-initializers -Wmissing-format-
attribute -Wmiss
ing-prototypes -Wmissing-variable-declarations -Wnested-externs -Wno-long-
long -Wno-unreachable-code -Wparentheses -Wpointer-arith -Wpointer-sign
-Wredundant-decls -Wreturn-type -Wsequence-point -Wshadow -Wsign-compare
-Wstrict-prototypes -Wswitch -Wswitch-default -Wtype-limits -Wundef
-Wuninitialized -Wunreachable-code -Wunused-but-set-variable -Wunused-
function -Wunused-label -Wunused-parameter -Wunused-result -Wunused-value
-Wunused-variable -Wwrite-strings -O2 -pipe -DLIBICONV_PLUG -fstack-
protector-strong -fno-strict-aliasing -MT local.lo -MD -MP -MF
.deps/local.Tpo -c -o local.lo local.c
libtool: compile: cc -DHAVE_CONFIG_H -I. -I../../..
-I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include
-I/usr/local/include -I../../.. -I/usr/local/include -DLIBICONV_PLUG
-I/usr/local/include -I/usr/local/include -I/usr/local/include -Wassign-
enum -Wbad-function-cast -Wcomment -Wconditional-uninitialized
-Wdeclaration-after-statement -Wfloat-conversion -Wfloat-equal -Wformat
-Wformat-security -Wimplicit -Wimplicit-fallthrough -Wignored-qualifiers
-Wlogical-not-parentheses -Wmissing-braces -Wmissing-declarations
-Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-
prototypes -Wmissing-variable-declarations -Wnested-externs -Wno-long-long
-Wno-unreachable-code -Wparentheses -Wpointer-arith -Wpointer-sign
-Wredundant-decls -Wreturn-type -Wsequence-point -Wshadow -Wsign-compare
-Wstrict-prototypes -Wswitch -Wswitch-default -Wtype-limits -Wundef
-Wuninitialized -Wunreachable-code -Wunused-but-set-variable -Wunused-
function -Wunused-label -Wunused-parameter -Wunused-result -Wunused-value
-Wunused-variable -Wwrite-strings -O2 -pipe -DLIBICONV_PLUG -fstack-
protector-strong -fno-strict-aliasing -MT local.lo -MD -MP -MF
.deps/local.Tpo -c local.c -fPIC -DPIC -o .libs/local.o
local.c:35:10: fatal error: 'e2p/e2p.h' file not found
#include <e2p/e2p.h> /* fgetflags(), fsetflags() */
^~~~~~~~~~~
1 error generated.
gmake[6]: *** [Makefile:513: local.lo] Error 1
}}}

--
Ticket URL: <http://www.midnight-commander.org/ticket/4493#comment:2>

Ticket System

unread,
Aug 19, 2023, 6:35:51 AM8/19/23
to phi...@krylov.eu, mc-...@googlegroups.com
#4493: mc-4.8.30 fails to build on FreeBSD with ext2fs attribute support
----------------------------+------------------------------
Reporter: phil | Owner:

Type: defect | Status: new
Priority: major | Milestone: 4.8.31
Component: compilation | Version: 4.8.30
Resolution: | Keywords:

Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
----------------------------+------------------------------

Comment (by phil):

I simply copied the fix from the other piece of code that uses `e2p`,
`src/filemanager/Makefile.am`.

--
Ticket URL: <http://www.midnight-commander.org/ticket/4493#comment:3>

Ticket System

unread,
Aug 19, 2023, 10:09:45 AM8/19/23
to phi...@krylov.eu, mc-...@googlegroups.com
#4493: mc-4.8.30 fails to build on FreeBSD with ext2fs attribute support
----------------------------+------------------------------
Reporter: phil | Owner:

Type: defect | Status: new
Priority: major | Milestone: 4.8.31
Component: compilation | Version: 4.8.30
Resolution: | Keywords:

Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
----------------------------+------------------------------

Comment (by phil):

Replying to [comment:4 andrew_b]:
> Please test the attached 4493_ext2fs_cppflags.patch.
Thanks, your patch also works fine.

--
Ticket URL: <http://www.midnight-commander.org/ticket/4493#comment:5>

Ticket System

unread,
Aug 19, 2023, 1:56:40 PM8/19/23
to phi...@krylov.eu, andrew....@gmail.com, mc-...@googlegroups.com
#4493: mc-4.8.30 fails to build on FreeBSD with ext2fs attribute support
----------------------------+--------------------------------
Reporter: phil | Owner: andrew_b
Type: defect | Status: accepted

Priority: major | Milestone: 4.8.31
Component: compilation | Version: 4.8.30
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: on review | Votes for changeset:
----------------------------+--------------------------------
Changes (by andrew_b):

* owner: => andrew_b
* status: new => accepted
* branch_state: no branch => on review


Comment:

Branch: 4493_FTBFS_FreeBSD.
changeset:9688e7d015d1744e3d22d2ec64ae56222eb9259d

--
Ticket URL: <http://www.midnight-commander.org/ticket/4493#comment:6>

Ticket System

unread,
Aug 19, 2023, 1:57:50 PM8/19/23
to phi...@krylov.eu, andrew....@gmail.com, mc-...@googlegroups.com
#4493: mc-4.8.30 fails to build on FreeBSD with ext2fs attribute support
----------------------------+-------------------------------------

Reporter: phil | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.31
Component: compilation | Version: 4.8.30
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: approved | Votes for changeset: phil andrew_b
----------------------------+-------------------------------------
Changes (by andrew_b):

* votes: => phil andrew_b
* branch_state: on review => approved


--
Ticket URL: <http://www.midnight-commander.org/ticket/4493#comment:7>

Ticket System

unread,
Aug 19, 2023, 1:58:55 PM8/19/23
to phi...@krylov.eu, andrew....@gmail.com, mc-...@googlegroups.com
#4493: mc-4.8.30 fails to build on FreeBSD with ext2fs attribute support
----------------------------+----------------------------------------
Reporter: phil | Owner: andrew_b
Type: defect | Status: testing

Priority: major | Milestone: 4.8.31
Component: compilation | Version: 4.8.30
Resolution: fixed | Keywords:
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------
Changes (by andrew_b):

* status: accepted => testing
* votes: phil andrew_b => committed-master
* resolution: => fixed
* branch_state: approved => merged


Comment:

Merged to master: [c56c4f63ccb245eb5e25d71230b906f6b852b92d].

--
Ticket URL: <http://www.midnight-commander.org/ticket/4493#comment:8>

Reply all
Reply to author
Forward
0 new messages