[Midnight Commander] #4459: Usage of 'sed' in build system/makefiles is not portable
Ticket System
--------------------------------+-------------------------------
Reporter: karlson2k | Type: defect
Status: new | Priority: major
Milestone: Future Releases | Component: mc-core
Version: master | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------------+-------------------------------
In the build system the sed command used with unportable "inplace" options
("-i").
The leads to build failures on some platforms, like Solaris, and reduces
portability in general.
Similar issues were fixed already in the past: https://midnight-
commander.org/ticket/3479
The configure script is already detecting suitable sed command in
'''LT_INIT''' macro, so it worth to use the result of this detection to
reduce portability problems.
On the other hand, workaround for "inplace" use is very simple and
straightforward, so for the best portability it would be better to avoid
unportable sed commands.
POSIX sed specification:
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html
Suggested fix: https://github.com/MidnightCommander/mc/pull/184
--
Ticket URL: <http://www.midnight-commander.org/ticket/4459>
Midnight Commander <https://midnight-commander.org>
Midnight Development Center
Ticket System
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Changes (by andrew_b):
* owner: => andrew_b
* status: new => accepted
* component: mc-core => compilation
* milestone: Future Releases => 4.8.30
--
Ticket URL: <http://www.midnight-commander.org/ticket/4459#comment:1>
Ticket System
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Blocked By: | Blocking:
Branch state: on review | Votes for changeset:
----------------------------+--------------------------------
Changes (by andrew_b):
* branch_state: no branch => on review
Comment:
Branch: 4459_sed
Initial changeset:054a051b427d7fab879b596f953265e764ee03d2
--
Ticket URL: <http://www.midnight-commander.org/ticket/4459#comment:2>
Ticket System
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Blocked By: | Blocking:
Branch state: approved | Votes for changeset: andrew_b
----------------------------+--------------------------------
Changes (by andrew_b):
* votes: => andrew_b
* branch_state: on review => approved
--
Ticket URL: <http://www.midnight-commander.org/ticket/4459#comment:3>
Ticket System
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: testing
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------
Changes (by andrew_b):
* status: accepted => testing
* votes: andrew_b => committed-master
* resolution: => fixed
* branch_state: approved => merged
Comment:
Merged to master: [2e3e3a377570570394850ca04069894ca1ffaf79].
{{{
git log --pretty=oneline e5911c1ef..2e3e3a377
}}}
--
Ticket URL: <http://www.midnight-commander.org/ticket/4459#comment:4>
Ticket System
Reporter: karlson2k | Owner: andrew_b
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------
Changes (by andrew_b):
* status: testing => closed
Comment:
Thanks for the patches!
--
Ticket URL: <http://www.midnight-commander.org/ticket/4459#comment:5>