[Midnight Commander] #4498: Ascii mode broken by change to lines.c mc_tty_frm mc_skin_lines_load_frm

3 views
Skip to first unread message

Ticket System

unread,
Aug 21, 2023, 4:17:23 PM8/21/23
to mc.se...@spamgourmet.com, mc-...@googlegroups.com
#4498: Ascii mode broken by change to lines.c mc_tty_frm mc_skin_lines_load_frm
--------------------------------+-------------------------------
Reporter: severach | Type: defect
Status: new | Priority: minor
Milestone: Future Releases | Component: mc-core
Version: master | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------------+-------------------------------
`mc -a` shows ^@ for most box drawing elements. Some drawing elements only
show as ^ as the @ is overwritten by other characters. "|" and "-" seem to
be right but they aren't because they should show those ASCII characters
instead of the UTF-8 characters showing now.

Problem fixed by.

git revert -n '6d639ce942db508e9cf20b6e4b446e46d6d05ce0'

--
Ticket URL: <http://www.midnight-commander.org/ticket/4498>
Midnight Commander <https://midnight-commander.org>
Midnight Development Center

Ticket System

unread,
Aug 21, 2023, 4:25:24 PM8/21/23
to mc.se...@spamgourmet.com, mc-...@googlegroups.com
#4498: Ascii mode broken by change to lines.c mc_tty_frm mc_skin_lines_load_frm
--------------------------+---------------------------------------
Reporter: severach | Owner:

Type: defect | Status: new
Priority: minor | Milestone: Future Releases
Component: mc-core | Version: master
Resolution: | Keywords:

Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------+---------------------------------------

Comment (by severach):

Overzealous formatting has made the carets show superscript. Please
someone can edit the top post so `^@` and `^` show correctly.

--
Ticket URL: <http://www.midnight-commander.org/ticket/4498#comment:1>

Ticket System

unread,
Aug 22, 2023, 2:22:49 AM8/22/23
to mc.se...@spamgourmet.com, mc-...@googlegroups.com
#4498: Ascii mode broken by change to lines.c mc_tty_frm mc_skin_lines_load_frm
--------------------------+---------------------------------------
Reporter: severach | Owner:

Type: defect | Status: new
Priority: minor | Milestone: Future Releases
Component: mc-core | Version: master
Resolution: | Keywords:

Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------+---------------------------------------
Description changed by zaytsev:

Old description:

> `mc -a` shows ^@ for most box drawing elements. Some drawing elements
> only show as ^ as the @ is overwritten by other characters. "|" and "-"
> seem to be right but they aren't because they should show those ASCII
> characters instead of the UTF-8 characters showing now.
>
> Problem fixed by.
>
> git revert -n '6d639ce942db508e9cf20b6e4b446e46d6d05ce0'

New description:

`mc -a` shows `^@` for most box drawing elements. Some drawing elements
only show as `^` as the @ is overwritten by other characters. "|" and "-"
seem to be right but they aren't because they should show those ASCII
characters instead of the UTF-8 characters showing now.

Problem fixed by.

git revert -n '6d639ce942db508e9cf20b6e4b446e46d6d05ce0'

--

--
Ticket URL: <http://www.midnight-commander.org/ticket/4498#comment:2>

Ticket System

unread,
Aug 22, 2023, 2:31:46 AM8/22/23
to mc.se...@spamgourmet.com, mc-...@googlegroups.com
#4498: Ascii mode broken by change to lines.c mc_tty_frm mc_skin_lines_load_frm
--------------------------+---------------------------------------
Reporter: severach | Owner:

Type: defect | Status: new
Priority: minor | Milestone: Future Releases
Component: mc-core | Version: master
Resolution: | Keywords:

Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------+---------------------------------------

Comment (by zaytsev):

You can do it by clicking "Modify ticket".

--
Ticket URL: <http://www.midnight-commander.org/ticket/4498#comment:3>

Ticket System

unread,
Aug 22, 2023, 3:08:24 PM8/22/23
to mc.se...@spamgourmet.com, andrew....@gmail.com, mc-...@googlegroups.com
#4498: Ascii mode broken by change to lines.c mc_tty_frm mc_skin_lines_load_frm
--------------------------+--------------------------------
Reporter: severach | Owner: andrew_b
Type: defect | Status: accepted
Priority: minor | Milestone: 4.8.31
Component: mc-skin | Version: 4.8.29
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: on review | Votes for changeset:
--------------------------+--------------------------------
Changes (by andrew_b):

* status: new => accepted
* component: mc-core => mc-skin
* version: master => 4.8.29
* branch_state: no branch => on review
* milestone: Future Releases => 4.8.31
* owner: => andrew_b


Comment:

Thanks!

Branch: 4498_broken_stickchars
changeset:dba05b78ea293f63cbdd511210c95e402bad7984

--
Ticket URL: <http://www.midnight-commander.org/ticket/4498#comment:4>

Ticket System

unread,
Aug 22, 2023, 3:09:57 PM8/22/23
to mc.se...@spamgourmet.com, andrew....@gmail.com, mc-...@googlegroups.com
#4498: Ascii mode broken by change to lines.c mc_tty_frm mc_skin_lines_load_frm
-------------------------+-----------------------------------------

Reporter: severach | Owner: andrew_b
Type: defect | Status: accepted
Priority: minor | Milestone: 4.8.31
Component: mc-skin | Version: 4.8.29
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: approved | Votes for changeset: severach andrew_b
-------------------------+-----------------------------------------
Changes (by andrew_b):

* votes: => severach andrew_b
* branch_state: on review => approved


--
Ticket URL: <http://www.midnight-commander.org/ticket/4498#comment:5>

Ticket System

unread,
Aug 22, 2023, 3:12:57 PM8/22/23
to mc.se...@spamgourmet.com, andrew....@gmail.com, mc-...@googlegroups.com
#4498: Ascii mode broken by change to lines.c mc_tty_frm mc_skin_lines_load_frm
-------------------------+----------------------------------------
Reporter: severach | Owner: andrew_b
Type: defect | Status: closed
Priority: minor | Milestone: 4.8.31
Component: mc-skin | Version: 4.8.30
Resolution: fixed | Keywords:
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
-------------------------+----------------------------------------
Changes (by andrew_b):

* version: 4.8.29 => 4.8.30


--
Ticket URL: <http://www.midnight-commander.org/ticket/4498#comment:8>

Reply all
Reply to author
Forward
0 new messages