Re: [Midnight Commander] #1: savannah: mc's built-in samba library is out of date

0 views
Skip to first unread message

Ticket System

unread,
Sep 7, 2021, 2:28:53 PM9/7/21
to sp...@midnight-commander.org, slava...@gmail.com, mc-...@googlegroups.com, in...@metux.net
#1: savannah: mc's built-in samba library is out of date
----------------------------+----------------------------------------------
Reporter: spock | Owner: slavazanko
Type: enhancement | Status: accepted
Priority: major | Milestone: Future Releases
Component: mc-vfs | Version: 4.6.1
Resolution: | Keywords: samba
Blocked By: | Blocking: 40, 42, 88, 2281, 3938
Branch state: on rework | Votes for changeset:
----------------------------+----------------------------------------------

Comment (by andrew_b):

Ticket #4288 has been marked as a duplicate of this ticket.

--
Ticket URL: <http://www.midnight-commander.org/ticket/1#comment:24>
Midnight Commander <https://midnight-commander.org>
Midnight Development Center

Ticket System

unread,
Sep 7, 2021, 9:06:42 PM9/7/21
to sp...@midnight-commander.org, slava...@gmail.com, mc-...@googlegroups.com, in...@metux.net
#1: savannah: mc's built-in samba library is out of date
----------------------------+----------------------------------------------
Reporter: spock | Owner: slavazanko
Type: enhancement | Status: accepted
Priority: major | Milestone: Future Releases
Component: mc-vfs | Version: 4.6.1
Resolution: | Keywords: samba
Blocked By: | Blocking: 40, 42, 88, 2281, 3938
Branch state: on rework | Votes for changeset:
----------------------------+----------------------------------------------

Comment (by birdie):

What about adding a warning that only SMB1.0 protocol is supported? This
is a very fast fix for the obviously broken feature.

That will stop people from scratching their heads trying to understand why
it doesn't work, e.g.

https://unix.stackexchange.com/questions/668049/how-do-i-connect-to-a-smb-
samba-share-using-midnight-commander

--
Ticket URL: <http://www.midnight-commander.org/ticket/1#comment:25>

Ticket System

unread,
Sep 8, 2021, 3:53:08 AM9/8/21
to sp...@midnight-commander.org, slava...@gmail.com, mc-...@googlegroups.com, in...@metux.net
#1: savannah: mc's built-in samba library is out of date
----------------------------+----------------------------------------------
Reporter: spock | Owner: slavazanko
Type: enhancement | Status: accepted
Priority: major | Milestone: Future Releases
Component: mc-vfs | Version: 4.6.1
Resolution: | Keywords: samba
Blocked By: | Blocking: 40, 42, 88, 2281, 3938
Branch state: on rework | Votes for changeset:
----------------------------+----------------------------------------------

Comment (by zaytsev):

I'd rather remove the code completely - SMB support has already been
disabled in Debian for this very reason, but Fedora people have so far
ignored our advice to do the same.

It's been 13 years since it has been half-broken. If somebody needs it,
they should finish the branch by Slava... it's not too much work for
someone who has time (see sftp VFS).

Andrew, what do you think?

--
Ticket URL: <http://www.midnight-commander.org/ticket/1#comment:26>

Ticket System

unread,
Sep 8, 2021, 2:40:38 PM9/8/21
to sp...@midnight-commander.org, slava...@gmail.com, mc-...@googlegroups.com, in...@metux.net
#1: savannah: mc's built-in samba library is out of date
----------------------------+----------------------------------------------
Reporter: spock | Owner: slavazanko
Type: enhancement | Status: accepted
Priority: major | Milestone: Future Releases
Component: mc-vfs | Version: 4.6.1
Resolution: | Keywords: samba
Blocked By: | Blocking: 40, 42, 88, 2281, 3938
Branch state: on rework | Votes for changeset:
----------------------------+----------------------------------------------

Comment (by andrew_b):

Replying to [comment:26 zaytsev]:


> I'd rather remove the code completely

I agree.

--
Ticket URL: <http://www.midnight-commander.org/ticket/1#comment:27>

Ticket System

unread,
Sep 9, 2021, 7:38:56 AM9/9/21
to sp...@midnight-commander.org, slava...@gmail.com, mc-...@googlegroups.com, in...@metux.net
#1: savannah: mc's built-in samba library is out of date
----------------------------+----------------------------------------------
Reporter: spock | Owner: slavazanko
Type: enhancement | Status: accepted
Priority: major | Milestone: Future Releases
Component: mc-vfs | Version: 4.6.1
Resolution: | Keywords: samba
Blocked By: | Blocking: 40, 42, 88, 2281, 3938
Branch state: on rework | Votes for changeset:
----------------------------+----------------------------------------------

Comment (by birdie):

Where's the like button?

--
Ticket URL: <http://www.midnight-commander.org/ticket/1#comment:28>

Ticket System

unread,
Sep 11, 2021, 2:36:44 AM9/11/21
to sp...@midnight-commander.org, andrew....@gmail.com, mc-...@googlegroups.com, in...@metux.net
#1: savannah: mc's built-in samba library is out of date
----------------------------+----------------------------------------------
Reporter: spock | Owner: andrew_b
Type: enhancement | Status: accepted
Priority: major | Milestone: 4.8.28

Component: mc-vfs | Version: 4.6.1
Resolution: | Keywords: samba
Blocked By: | Blocking: 40, 42, 88, 2281, 3938
Branch state: on review | Votes for changeset:
----------------------------+----------------------------------------------
Changes (by andrew_b):

* owner: slavazanko => andrew_b
* branch_state: on rework => on review
* milestone: Future Releases => 4.8.28


Comment:

Branch: 1_smbfs_remove
Initial changeset: 781ad4c53c5d0752108257813736bf054f60bc60

--
Ticket URL: <http://www.midnight-commander.org/ticket/1#comment:29>

Ticket System

unread,
Sep 26, 2021, 3:09:39 AM9/26/21
to sp...@midnight-commander.org, andrew....@gmail.com, mc-...@googlegroups.com, in...@metux.net
#1: savannah: mc's built-in samba library is out of date
----------------------------+----------------------------------------------
Reporter: spock | Owner: andrew_b
Type: enhancement | Status: accepted
Priority: major | Milestone: 4.8.28
Component: mc-vfs | Version: 4.6.1
Resolution: | Keywords: samba
Blocked By: | Blocking: 40, 42, 88, 2281, 3938
Branch state: approved | Votes for changeset: andrew_b
----------------------------+----------------------------------------------
Changes (by andrew_b):

* votes: => andrew_b
* branch_state: on review => approved


--
Ticket URL: <http://www.midnight-commander.org/ticket/1#comment:30>

Ticket System

unread,
Sep 26, 2021, 3:11:24 AM9/26/21
to sp...@midnight-commander.org, andrew....@gmail.com, mc-...@googlegroups.com, in...@metux.net
#1: savannah: mc's built-in samba library is out of date
----------------------------+----------------------------------------------
Reporter: spock | Owner: andrew_b
Type: enhancement | Status: testing

Priority: major | Milestone: 4.8.28
Component: mc-vfs | Version: 4.6.1
Resolution: fixed | Keywords: samba

Blocked By: | Blocking: 40, 42, 88, 2281, 3938
Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------------
Changes (by andrew_b):

* status: accepted => testing
* votes: andrew_b => committed-master
* resolution: => fixed
* branch_state: approved => merged


Comment:

Merged to master: [6f676d06676cc5d271583754f15473af78a36ac4].

{{{
git log --pretty=oneline 30fbbe75b..6f676d066
}}}

--
Ticket URL: <http://www.midnight-commander.org/ticket/1#comment:31>

Ticket System

unread,
Sep 26, 2021, 3:12:55 AM9/26/21
to sp...@midnight-commander.org, andrew....@gmail.com, mc-...@googlegroups.com, in...@metux.net
#1: savannah: mc's built-in samba library is out of date
----------------------------+----------------------------------------------
Reporter: spock | Owner: andrew_b
Type: enhancement | Status: closed

Priority: major | Milestone: 4.8.28
Component: mc-vfs | Version: 4.6.1
Resolution: fixed | Keywords: samba
Blocked By: | Blocking: 40, 42, 88, 2281, 3938
Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------------
Changes (by andrew_b):

* status: testing => closed


--
Ticket URL: <http://www.midnight-commander.org/ticket/1#comment:32>

Reply all
Reply to author
Forward
0 new messages