[Midnight Commander] #4270: Prepare for release mc-4.8.28
Ticket System
-------------------------------+--------------------------
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.28
Component: adm | Version: master
Keywords: | Blocked By:
Blocking: | Branch state: no branch
Votes for changeset: |
-------------------------------+--------------------------
--
Ticket URL: <http://www.midnight-commander.org/ticket/4270>
Midnight Commander <https://midnight-commander.org>
Midnight Development Center
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.28
Component: adm | Version: master
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Comment (by andrew_b):
Branch: 4270_cleanup
Initial changeset:7341eeb52386ec1949bb184018adfaf7c9041fd3
--
Ticket URL: <http://www.midnight-commander.org/ticket/4270#comment:1>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.28
Component: adm | Version: master
Blocked By: | Blocking:
Branch state: merged | Votes for changeset:
------------------------+------------------------------
Changes (by andrew_b):
* branch_state: no branch => merged
Comment:
Merged to master: [eff779b246e667d3bdccb3a0ac2c6dca470ac624].
{{{
git lof ---pretty=oneline b8262f22e..eff779b24
}}}
--
Ticket URL: <http://www.midnight-commander.org/ticket/4270#comment:2>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.28
Component: adm | Version: master
Blocked By: | Blocking:
Branch state: merged | Votes for changeset:
------------------------+------------------------------
Comment (by andrew_b):
Branch: 4270_cleanup
Initial changeset:1a093a8125e109807c87280a4ef9ef458020a6a4
--
Ticket URL: <http://www.midnight-commander.org/ticket/4270#comment:3>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.28
Component: adm | Version: master
Blocked By: | Blocking:
Branch state: merged | Votes for changeset:
------------------------+------------------------------
Comment (by andrew_b):
mc-4270-remove-unused-macros.patch: applied.
mc-4270-replace-obsolete-ac_prog_cc_stdc.patch: applied.
Thanks!
--
Ticket URL: <http://www.midnight-commander.org/ticket/4270#comment:4>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.28
Component: adm | Version: master
Blocked By: | Blocking: 4330
Branch state: merged | Votes for changeset:
------------------------+------------------------------
Comment (by and):
I bump 4270_cleanup at scan.coverity.com to see was new in Coverity
2021.12.1 release.
Looks like coverity view defects login is still broken.
--
Ticket URL: <http://www.midnight-commander.org/ticket/4270#comment:6>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.28
Component: adm | Version: master
Blocked By: | Blocking: 4330
Branch state: merged | Votes for changeset:
------------------------+------------------------------
Comment (by andrew_b):
Thanks! Applied with some modifications.
--
Ticket URL: <http://www.midnight-commander.org/ticket/4270#comment:7>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.28
Component: adm | Version: master
Blocked By: | Blocking: 4330
Branch state: merged | Votes for changeset:
------------------------+------------------------------
Comment (by andrew_b):
Thanks! Applied.
--
Ticket URL: <http://www.midnight-commander.org/ticket/4270#comment:8>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.28
Component: adm | Version: master
Blocked By: | Blocking: 4330
Branch state: merged | Votes for changeset:
------------------------+------------------------------
Comment (by andrew_b):
Merged to master: [7fe3f4c898d029e87faa439ebd7297214059f710].
{{{
git --log --pretty=oneline cbcda8a28..7fe3f4c89
}}}
--
Ticket URL: <http://www.midnight-commander.org/ticket/4270#comment:9>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.28
Component: adm | Version: master
Blocked By: | Blocking:
Branch state: merged | Votes for changeset:
------------------------+------------------------------
Comment (by zaytsev):
Hi Andrew,
I get the following warning while building:
{{{
../../../src/viewer/coord_cache.c: In function ‘mcview_ccache_add_entry’:
../../../src/viewer/coord_cache.c:97:5: warning: ‘g_memdup’ is deprecated:
Use 'g_memdup2' instead [-Wdeprecated-declarations]
97 | cache->cache[pos] = g_memdup (entry, sizeof (*entry));
| ^~~~~
In file included from /usr/include/glib-2.0/glib.h:82,
from ../../../lib/global.h:66,
from ../../../src/viewer/coord_cache.c:57:
/usr/include/glib-2.0/glib/gstrfuncs.h:257:23: note: declared here
257 | gpointer g_memdup (gconstpointer mem,
| ^~~~~~~~
}}}
Yury
--
Ticket URL: <http://www.midnight-commander.org/ticket/4270#comment:11>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.28
Component: adm | Version: master
Blocked By: | Blocking:
Branch state: merged | Votes for changeset:
------------------------+------------------------------
Comment (by andrew_b):
{{{
g_memdup has been deprecated since version 2.68 and should not be used in
newly-written code.
Use g_memdup2() instead, as it accepts a gsize argument for byte_size,
avoiding the possibility of overflow in a gsize → guint conversion
}}}
It's not critical in this case, because sizeof (*entry) is significantly
less than SIZE_MAX.
Let's fix that after release.
--
Ticket URL: <http://www.midnight-commander.org/ticket/4270#comment:12>
Ticket System
Reporter: zaytsev | Owner:
Type: task | Status: new
Priority: major | Milestone: 4.8.28
Component: adm | Version: master
Blocked By: | Blocking:
Branch state: merged | Votes for changeset:
------------------------+------------------------------
Comment (by zaytsev):
Fine with me - another one from ossie:
{{{
> find.c: In function ‘find_cmd’:
> find.c:1837:28: warning: ‘start_dir_len’ may be used uninitialized in
this function [-Wmaybe-uninitialized]
> 1837 | p = name + (size_t) start_dir_len;
> | ^~~~~~~~~~~~~~~~~~~~~~
> find.c:1897:13: note: ‘start_dir_len’ was declared here
> 1897 | ssize_t start_dir_len;
> | ^~~~~~~~~~~~~
}}}
For the record.
--
Ticket URL: <http://www.midnight-commander.org/ticket/4270#comment:13>
Ticket System
Reporter: zaytsev | Owner: zaytsev
Type: task | Status: accepted
Priority: major | Milestone: 4.8.28
Component: adm | Version: master
Blocked By: | Blocking:
Branch state: merged | Votes for changeset:
------------------------+--------------------------------
Changes (by zaytsev):
* status: new => accepted
* owner: => zaytsev
Comment:
> prepare repository for release
> download PO-translations from Transifex.net
> store translations in git repo
> download the hint translations from Transifex.net
> store translations in git repo
> create new NEWS wiki page for next version with empty template
[[NEWS-4.8.29]]
> add content of current NEWS wiki page to the doc/NEWS file in git repo
> new version in Trac
> new milestone in Trac
> create new tag in git
> create tar.(bz2|xz) package files
done
> upload source packages and checksums to the special upload area
> developers should download tarballs, verify checksums, compile and
install locally
skipped
> upload source packages and checksums
> run command
> update Wiki start page with latest release number
done
--
Ticket URL: <http://www.midnight-commander.org/ticket/4270#comment:14>
Ticket System
Reporter: zaytsev | Owner: zaytsev
Type: task | Status: testing
Priority: major | Milestone: 4.8.28
Component: adm | Version: master
Blocked By: | Blocking:
Branch state: merged | Votes for changeset:
------------------------+-------------------------------
Changes (by zaytsev):
* status: accepted => testing
* resolution: => fixed
Comment:
> write an announcement: list user visible changes (bugs and features)
done
> create new ticket (type=task, component=adm) for the next release
#4357
> close ticket for release
> close current milestone
done
--
Ticket URL: <http://www.midnight-commander.org/ticket/4270#comment:15>
Ticket System
Reporter: zaytsev | Owner: zaytsev
Priority: major | Milestone: 4.8.28
Component: adm | Version: master
Blocked By: | Blocking:
Branch state: merged | Votes for changeset:
------------------------+-------------------------------
Changes (by zaytsev):
* status: testing => closed
--
Ticket URL: <http://www.midnight-commander.org/ticket/4270#comment:16>