[Midnight Commander] #3433: cd into zip file fail with "inconsistent extfs archive"
Ticket System
--------------------------------+----------------------------------
Reporter: fubbes | Type: defect
Status: new | Priority: major
Milestone: Future Releases | Component: mc-core
Version: 4.8.14 | Keywords: extfs uzip
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------------+----------------------------------
It's not possible to {{{cd}}} into some zip files. This happen only for
specific ones.
After some investigations it seems mc isn't able to handle zip files with
entries which have broken Unix file attributes. Whereas the zip file
itself can be extracted without any problem.
'''zip with valid Unix permissions'''
{{{
$ /usr/lib/mc/extfs.d/uzip list foo.zip
drwxrwxrwx 1 1000 1000 0 03/27/2015 04:39:26 addons/
}}}
{{{
$ zipinfo foo.zip | grep Unix
file system or operating system of origin: Unix
Unix file attributes (040777 octal): drwxrwxrwx
}}}
'''zip with invalid Unix permissions'''
{{{
$ /usr/lib/mc/extfs.d/uzip list foo_broken.zip
?rwsrwsrwt 1 1000 1000 0 03/27/2015 04:39:26 addons/
}}}
{{{
$ zipinfo foo_broken.zip | grep Unix
file system or operating system of origin: Unix
Unix file attributes (177777 octal): ?rwsrwsrwt
}}}
issue is also on github: https://github.com/MidnightCommander/mc/issues/55
--
Ticket URL: <http://www.midnight-commander.org/ticket/3433>
Midnight Commander <http://www.midnight-commander.org>
Midnight Development Center
Ticket System
Reporter: fubbes | Owner:
Type: defect | Status: new
Priority: major | Milestone: Future Releases
Resolution: | Keywords: extfs uzip
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Changes (by andrew_b):
* component: mc-core => mc-vfs
--
Ticket URL: <http://www.midnight-commander.org/ticket/3433#comment:1>
Ticket System
Reporter: fubbes | Owner:
Type: defect | Status: new
Priority: major | Milestone: Future Releases
Resolution: | Keywords: extfs uzip
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Comment (by and):
Thanks fubbes and/or SubOptimal for reporting.
unzip handled object as directory if filename ended with '/'
it will not depend on given file permission
So zipinfo can show strange perms but unzip can handle it.
patch attached.
--
Ticket URL: <http://www.midnight-commander.org/ticket/3433#comment:2>
Ticket System
Reporter: fubbes | Owner:
Type: defect | Status: new
Priority: major | Milestone: 4.8.16
Component: mc-vfs | Version: 4.8.14
Resolution: | Keywords: extfs uzip
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Changes (by and):
* milestone: Future Releases => 4.8.16
--
Ticket URL: <http://www.midnight-commander.org/ticket/3433#comment:3>
Ticket System
Reporter: fubbes | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.16
Component: mc-vfs | Version: 4.8.14
Blocked By: | Blocking:
Branch state: on review | Votes for changeset:
--------------------------+----------------------------------
Changes (by andrew_b):
* owner: => andrew_b
* status: new => accepted
* branch_state: no branch => on review
Comment:
Branch: 3433_zip_dir_perms
changeset:2e04dfd8f62557d345e813cc0f117490315473f6
--
Ticket URL: <http://www.midnight-commander.org/ticket/3433#comment:4>
Ticket System
Reporter: fubbes | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.16
Component: mc-vfs | Version: 4.8.14
Blocked By: | Blocking:
Branch state: approved | Votes for changeset: andrew_b
-------------------------+----------------------------------
Changes (by andrew_b):
* votes: => andrew_b
* branch_state: on review => approved
--
Ticket URL: <http://www.midnight-commander.org/ticket/3433#comment:5>
Ticket System
Reporter: fubbes | Owner: andrew_b
Type: defect | Status: testing
Priority: major | Milestone: 4.8.16
Component: mc-vfs | Version: 4.8.14
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
-----------------------+----------------------------------------
Changes (by andrew_b):
* status: accepted => testing
* votes: andrew_b => committed-master
* resolution: => fixed
* branch_state: approved => merged
Comment:
Merged to master: [2e04dfd8f62557d345e813cc0f117490315473f6].
--
Ticket URL: <http://www.midnight-commander.org/ticket/3433#comment:6>
Ticket System
Reporter: fubbes | Owner: andrew_b
Priority: major | Milestone: 4.8.16
Component: mc-vfs | Version: 4.8.14
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
-----------------------+----------------------------------------
Changes (by andrew_b):
* status: testing => closed
--
Ticket URL: <http://www.midnight-commander.org/ticket/3433#comment:7>