[Midnight Commander] #4464: FTBFS without ext2fs attributes support
Ticket System
--------------------------------+-----------------------------------
Reporter: karlson2k | Type: defect
Status: new | Priority: major
Milestone: Future Releases | Component: compilation
Version: master | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------------+-----------------------------------
Discovered when built on Solaris.
{{{
info.c: In function ‘info_show_info’:
info.c:269:50: warning: implicit declaration of function
‘chattr_get_as_str’ [-Wimplicit-function-declaration]
269 | tty_printf (_("Attributes: %s"), chattr_get_as_str
(attr));
| ^~~~~~~~~~~~~~~~~
info.c:269:50: warning: nested extern declaration of ‘chattr_get_as_str’
[-Wnested-externs]
In file included from info.c:38:
}}}
and then
{{{
Undefined first referenced
symbol in file
chattr_get_as_str ./.libs/libinternal.a(info.o)
ld: fatal: symbol referencing errors
}}}
I do not have any `ext2fs` library on Solaris, so mc is configured without
ext2fs attributes support.
The suggested fix: https://github.com/MidnightCommander/mc/pull/188
Alternative fix: https://github.com/MidnightCommander/mc/pull/189
--
Ticket URL: <http://www.midnight-commander.org/ticket/4464>
Midnight Commander <https://midnight-commander.org>
Midnight Development Center
Ticket System
Reporter: karlson2k | Owner:
Type: defect | Status: new
Priority: major | Milestone: Future Releases
Component: compilation | Version: master
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Comment (by karlson2k):
Function `chattr_cmd ` is declared in `src/filemanager/cmd.h` as
{{{
#ifdef ENABLE_EXT2FS_ATTR
/* chattr.c */
void chattr_cmd (WPanel * panel);
const char *chattr_get_as_str (unsigned long attr);
#endif
}}}
--
Ticket URL: <http://www.midnight-commander.org/ticket/4464#comment:1>
Ticket System
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Changes (by andrew_b):
* owner: => andrew_b
* status: new => accepted
* milestone: Future Releases => 4.8.30
--
Ticket URL: <http://www.midnight-commander.org/ticket/4464#comment:2>
Ticket System
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Blocked By: | Blocking:
Branch state: on review | Votes for changeset:
----------------------------+--------------------------------
Changes (by andrew_b):
* branch_state: no branch => on review
Comment:
Thanks!
Branch: 4464_FTBFS_without_ext2fs_attrs
changeset:cfe9ae814bd48876865966bb98d82797968a2558
--
Ticket URL: <http://www.midnight-commander.org/ticket/4464#comment:3>
Ticket System
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Blocked By: | Blocking:
Branch state: approved | Votes for changeset: andrew_b
----------------------------+--------------------------------
Changes (by andrew_b):
* votes: => andrew_b
* branch_state: on review => approved
--
Ticket URL: <http://www.midnight-commander.org/ticket/4464#comment:4>
Ticket System
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: testing
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------
Changes (by andrew_b):
* status: accepted => testing
* votes: andrew_b => committed-master
* resolution: => fixed
* branch_state: approved => merged
Comment:
Merged to master: [cc283df6dcb36473578f54427973942a50019eef].
--
Ticket URL: <http://www.midnight-commander.org/ticket/4464#comment:5>
Ticket System
Reporter: karlson2k | Owner: andrew_b
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------
Changes (by andrew_b):
* status: testing => closed
--
Ticket URL: <http://www.midnight-commander.org/ticket/4464#comment:6>
Ticket System
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: closed
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------
Comment (by karlson2k):
I've tested the git master. Now `dist` could be made (tested on Debian
Sid) and then mc could be built on Solaris.
However, there are a few compiler warnings, including the warning
introduced by this patch:
{{{
info.c: In function ‘info_show_info’:
info.c:264:27: warning: unused variable ‘attr’ [-Wunused-variable]
264 | unsigned long attr;
| ^~~~
}}}
The alternative patch could fix this warning as well.
--
Ticket URL: <http://www.midnight-commander.org/ticket/4464#comment:7>
Ticket System
Reporter: karlson2k | Owner: andrew_b
Type: defect | Status: closed
Priority: major | Milestone: 4.8.30
Component: compilation | Version: master
Blocked By: | Blocking:
Branch state: merged | Votes for changeset: committed-master
----------------------------+----------------------------------------
Comment (by andrew_b):
Replying to [comment:7 karlson2k]:
> However, there are a few compiler warnings, including the warning
introduced by this patch:
I've fixed that in the 4426_cleanup branch.
--
Ticket URL: <http://www.midnight-commander.org/ticket/4464#comment:8>