[Midnight Commander] #4502: VFS of compressed tar archives appears broken with GLib 2.77.3
Ticket System
--------------------------------+------------------------------
Reporter: sachahony | Type: defect
Status: new | Priority: major
Milestone: Future Releases | Component: mcview
Version: 4.8.30 | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------------+------------------------------
I have updated my glib2 from 2.77.2 to 2.77.3. After the update I can no
longer enter into tar.bz2 files. Reverting back 2.77.2 solves the issue.
Also the view archive shows a "binary" view rather than a "direcory" as if
the file is not recognised.
Changelog of glib:
https://download.gnome.org/sources/glib/2.77/glib-2.77.3.news
--
Ticket URL: <http://www.midnight-commander.org/ticket/4502>
Midnight Commander <https://midnight-commander.org>
Midnight Development Center
Ticket System
Reporter: sachahony | Owner:
Type: defect | Status: new
Priority: major | Milestone: Future Releases
Component: mcview | Version: 4.8.30
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Comment (by andrew_b):
Are any other regressions with glib-2.77.3 besides tar?
Why component is mcview?
--
Ticket URL: <http://www.midnight-commander.org/ticket/4502#comment:1>
Ticket System
Reporter: sachahony | Owner:
Type: defect | Status: new
Priority: major | Milestone: Future Releases
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Comment (by zaytsev):
Oh man, why they would handle escape sequences in INI files in the first
place o_O ?
Maybe we can just switch from `g_key_file_get_string` to
`g_key_file_get_value` API, because otherwise every stupid backslash would
have to be escaped and it will make a bloody hell out of our regexes.
--
Ticket URL: <http://www.midnight-commander.org/ticket/4502#comment:5>
Ticket System
Reporter: sachahony | Owner:
Type: defect | Status: new
Priority: major | Milestone: Future Releases
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Comment (by andrew_b):
Replying to [comment:5 zaytsev]:
> Maybe we can just switch from `g_key_file_get_string` to
`g_key_file_get_value` API, because otherwise every stupid backslash would
have to be escaped and it will make a bloody hell out of our regexes.
g_key_file_* API is used in mc indirectly via mcconfig engine. Changing
`g_key_file_get_string` to `g_key_file_get_value` in mcconfig may break
the handling of other INI files.
We already have INI files with escaped backslashes: mc.lib, Syntax (it is
not INI but nonetheless), probably some others. I think mc.ext.ini should
be consistent with them.
--
Ticket URL: <http://www.midnight-commander.org/ticket/4502#comment:7>
Ticket System
Reporter: sachahony | Owner:
Type: defect | Status: new
Priority: major | Milestone: Future Releases
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Comment (by zaytsev):
> it is a bit surprising that such a seemingly obvious bugfix has such
side effects. i guess mc does something ... "interesting"?
I'm not sure I would define this as "interesting". I think it's just
missing error handling, the usual C stuff.
> We already have INI files with escaped backslashes: mc.lib, Syntax (it
is not INI but nonetheless), probably some others. I think mc.ext.ini
should be consistent with them.
You are right, but exactly for this reason I find them to be disgusting
and actually see no reason why we should support escape sequences in the
configuration files. So I'd rather break everything while we are at it :-)
But it's up to you.
--
Ticket URL: <http://www.midnight-commander.org/ticket/4502#comment:8>
Ticket System
------------------------------+---------------------------------------
Reporter: sachahony | Owner:
Type: defect | Status: new
Priority: major | Milestone: Future Releases
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Comment (by andrew_b):
Probably the story isn't finished yet:
https://gitlab.gnome.org/GNOME/glib/-/issues/3095
--
Ticket URL: <http://www.midnight-commander.org/ticket/4502#comment:10>
Ticket System
------------------------------+---------------------------------------
Reporter: sachahony | Owner:
Priority: major | Milestone: Future Releases
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: no branch | Votes for changeset:
Comment (by zaytsev):
https://gitlab.gnome.org/GNOME/glib/-/issues/3094
--
Ticket URL: <http://www.midnight-commander.org/ticket/4502#comment:11>
Ticket System
------------------------------+--------------------------------
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.31
Component: mc-config-ini | Version: 4.8.30
Resolution: | Keywords:
Blocked By: | Blocking:
Branch state: approved | Votes for changeset: andrew_b
------------------------------+--------------------------------
Changes (by andrew_b):
* votes: => andrew_b
* branch_state: on review => approved
--
Ticket URL: <http://www.midnight-commander.org/ticket/4502#comment:19>