Re: [Midnight Commander] #400: Support for multiline search, and for searching for 0x0A bytes.
Ticket System
--------------------------+---------------------------------------
Reporter: Hubbitus | Owner:
Type: defect | Status: new
Priority: major | Milestone: Future Releases
Component: mc-search | Version: master
Resolution: | Keywords:
Blocked By: 3694 | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------+---------------------------------------
Comment (by andrew_b):
Ticket #4395 has been marked as a duplicate of this ticket.
--
Ticket URL: <http://www.midnight-commander.org/ticket/400#comment:14>
Midnight Commander <https://midnight-commander.org>
Midnight Development Center
Ticket System
--------------------------+---------------------------------------
Reporter: Hubbitus | Owner:
Type: defect | Status: new
Priority: major | Milestone: Future Releases
Component: mc-search | Version: master
Resolution: | Keywords:
Blocked By: 3694 | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------+---------------------------------------
Comment (by sxmboer2):
I submitted a fix as ticket #4395, but I probably should have added a
comment here and uploaded the bugfix by attaching the diff file here.
The diff file I am attaching fixes various search issue related to multi-
line searches and replacements; both in normal mode as well as in regex
search mode.
I changed the boundary conditions because testing in search and replaces
showed that the search consistently found the very end of the file as a
hit (when searching for "\n\n" even when only one newline exists at the
end of the file buffer.
--
Ticket URL: <http://www.midnight-commander.org/ticket/400#comment:15>
Ticket System
--------------------------+---------------------------------------
Reporter: Hubbitus | Owner:
Type: defect | Status: new
Priority: major | Milestone: Future Releases
Component: mc-search | Version: master
Resolution: | Keywords:
Blocked By: 3694 | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------+---------------------------------------
Comment (by andrew_b):
Replying to [comment:15 sxmboer2]:
> The diff file I am attaching fixes various search issue related to
multi-line searches and replacements; both in normal mode as well as in
regex search mode.
A tests in `tests/lib/search` are highly desirable for this patch.
--
Ticket URL: <http://www.midnight-commander.org/ticket/400#comment:16>
Ticket System
--------------------------+---------------------------------------
Reporter: Hubbitus | Owner:
Type: defect | Status: new
Priority: major | Milestone: Future Releases
Component: mc-search | Version: master
Resolution: | Keywords:
Blocked By: 3694 | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------+---------------------------------------
Comment (by sxmboer):
Test suite was a good idea, but it took me a significant amount of time to
figure out how to use the unit test system. The added source code includes
tests that are somewhat specific to this ticket.
It should be easy to add tests for the other search modes, whenever they
are relevant.
Adding patch test-search.diff
--
Ticket URL: <http://www.midnight-commander.org/ticket/400#comment:17>
Ticket System
--------------------------+--------------------------------
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.29
Component: mc-search | Version: master
Resolution: | Keywords:
Blocked By: 3694 | Blocking:
--------------------------+--------------------------------
Changes (by andrew_b):
* owner: => andrew_b
* status: new => accepted
* branch_state: no branch => on review
* milestone: Future Releases => 4.8.29
Comment:
Cool. Thanks!
Branch: 400_multiline_search
changeset:89bb5b60104178097b98e7c7fd2b28bfabc4ebbb
--
Ticket URL: <http://www.midnight-commander.org/ticket/400#comment:18>
Ticket System
--------------------------+--------------------------------
Reporter: Hubbitus | Owner: andrew_b
Type: defect | Status: accepted
Priority: major | Milestone: 4.8.29
Component: mc-search | Version: master
Resolution: | Keywords:
Blocked By: 3694 | Blocking:
--------------------------+--------------------------------
Changes (by andrew_b):
* votes: => andrew_b
* branch_state: on review => approved
--
Ticket URL: <http://www.midnight-commander.org/ticket/400#comment:19>
Ticket System
Reporter: Hubbitus | Owner: andrew_b
Type: defect | Status: testing
Priority: major | Milestone: 4.8.29
Component: mc-search | Version: master
Blocked By: 3694 | Blocking:
Branch state: merged | Votes for changeset: committed-master
--------------------------+----------------------------------------
Changes (by andrew_b):
* status: accepted => testing
* votes: andrew_b => committed-master
* resolution: => fixed
* branch_state: approved => merged
Comment:
Merged to master: [08cca8aae8c2f36e26ff99174f5cc40e551a98ab].
--
Ticket URL: <http://www.midnight-commander.org/ticket/400#comment:20>
Ticket System
--------------------------+----------------------------------------
Reporter: Hubbitus | Owner: andrew_b
Priority: major | Milestone: 4.8.29
Component: mc-search | Version: master
Resolution: fixed | Keywords:
Blocked By: 3694 | Blocking:
Branch state: merged | Votes for changeset: committed-master
--------------------------+----------------------------------------
Changes (by andrew_b):
* status: testing => closed
--
Ticket URL: <http://www.midnight-commander.org/ticket/400#comment:21>
Ticket System
--------------------------+---------------------------------------
Type: defect | Status: reopened
Priority: major | Milestone: Future Releases
Resolution: | Keywords:
Blocked By: 3694 | Blocking:
Branch state: no branch | Votes for changeset:
--------------------------+---------------------------------------
* status: closed => reopened
* votes: committed-master =>
* resolution: fixed =>
* branch_state: merged => no branch
* milestone: 4.8.29 => Future Releases
Comment:
Multi-line search has some bugs. See #4429 for details.
--
Ticket URL: <http://www.midnight-commander.org/ticket/400#comment:22>