[mbedmicro/pyOCD] Fix get_probe_with_id() for CMSIS-DAP (#621)
Chris Reed
Calling CMSISDAPProbe.get_probe_with_id() would always return an object even if there was no matching probe. This also caused the same method on DebugProbeAggregator to always return a CMSISDAPProbe even if the ID only matched an STLink.
Underlying this was original behaviour of DAPAccessCMSISDAP, where you could create an instance with any unique ID. It would only fail when you called open(). This patch changes this behaviour so it fails early. Attempting to construct a DAPAccessCMSISDAP with an unique ID that does not match a CMSIS-DAP interface will cause a DAPAccessIntf.DeviceError to be raised.
Another problem was in CMSISDAPProbe.get_probe_with_id(), where it always returned an instance even for invalid IDs. This specific behaviour broke DebugProbeAggregator.
Closes #617
You can view, comment on, or merge this pull request online at:
https://github.com/mbedmicro/pyOCD/pull/621
Commit Summary
- Fix get_probe_with_id() for CMSIS-DAP.
File Changes
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
Chris Reed
/morph test
Chris Reed
/morph test
Chris Reed
Merged #621 into master.