Pull request backlog

[Susurrus]

The recent discussion on the QGC mailing list brought up the mention of
a feature request for moving the RADIO message to common.xml from
ardupilot.xml as it is more general use than just for that platform.
This seems reasonable as this message is broadcast by the 3DR radios,
and since we just got a hold of them, that would be very useful.

This got me to browsing the issue queue for MAVLink to see if anyone has
filed a bug on this, and it appears that no one has, but that there are
also 8 outstanding pull requests. It doesn't seem worth contributing
code to this project when some of it has bitrot for up to 8 months still
pending comments from the MAVLink team. I know you all are busy, but
it's hard to get motivated to contribute code to the project when it's
just ignored and bitrots.

Also, moving forward, is this the right venue to bring up the issues on
an exceeding number of pull requests?

Additionally can members of the community help with triaging or
reviewing pending pull requests. I think a lot of pressure falls to the
MAVLink team even though the community could contribute here, even if
it's not directly merging in the code. While QGC has a contributor's
guide [http://www.qgroundcontrol.org/dev/contribute], there isn't one
for MAVLink, but there really should be, and I imagine it can reuse
pretty much that entire document. That document also specifies that the
mailing lists are the way to submit pull requests, so should that be how
I submit my pull requests to both the MAVLink and QGC projects? I've
never seen anyone do this nor tell me this was the proper method, so I
have been unaware (though I should have looked for such a document before).

Really I'd like to discuss a way to get the community able to push
patches for both MAVLink and QGC further along towards being merge-able
so that the limited time available to those with committer access can
spend that time actually merging code.

Bryant

[Meier Lorenz]

Hi Bryant,

Thanks for bringing this up and it indeed slipped, and it shouldn't have. Since I have been aware about the merge latency, I have changed the merge process and did a triage of the first set of pull requests.

If the requests are clean, small and well explained I can promise substantially faster merging. For changes that refactor the code or change other general things, it can still take some time to carefully review, but certainly not months.

Thanks for bringing this up. I think I've touched all pull requests, and we can take it from there. There is more cleanup to do in common.xml and the repository structure, and I will get back to those topics with separate emails tonight.

-Lorenz


------------------------------------------------------
Lorenz Meier
Institute for Visual Computing
ETH Zurich
http://www.inf.ethz.ch/personal/lomeier/

Am 24.04.2013 um 06:48 schrieb Susurrus <susu...@gmail.com<mailto:susu...@gmail.com>>
:

--
Sie haben diese Nachricht erhalten, weil Sie der Google Groups-Gruppe MAVLink beigetreten sind.
Um Ihr Abonnement für diese Gruppe zu beenden und keine E-Mails mehr von dieser Gruppe zu erhalten, senden Sie eine Email an mavlink+u...@googlegroups.com<mailto:mavlink+u...@googlegroups.com>.
Weitere Optionen: https://groups.google.com/groups/opt_out