SMART_BATTERY_INFO - revert and renumber BATTERY_INFO (370 to 372)
2 views
Skip to first unread message
Hamish Willee
Nov 13, 2024, 7:53:14 PM11/13/24
to ardupilot-gcs, MAVLink
SMART_BATTERY_INFO was replaced by BATTERY_INFO earlier in the year using the same ID, on the understanding that there were no smart battery implementations using this.
That was the wrong approach - we should have added a new message and deprecated the old one. We have since found out that there are some users of SMART_BATTERY_INFO. There is no indication the code is active, but given it will be harder to fix later than now, we're reverting SMART_BATTERY_INFO and moving BATTERY_INFO from ID 370 to 372. This has merged:
That was the wrong approach - we should have added a new message and deprecated the old one. We have since found out that there are some users of SMART_BATTERY_INFO. There is no indication the code is active, but given it will be harder to fix later than now, we're reverting SMART_BATTERY_INFO and moving BATTERY_INFO from ID 370 to 372. This has merged:
https://github.com/mavlink/mavlink/pull/2173
This should be a compile only change for flight stacks, ground stations and batteries.
The message is emitted with old ID in some flight stacks on request (e.g. PX4 v1.15) but as far as we can tell is never requested.
We don't think there are any affected smart batteries, but if there are, they will need to update firmware. Apologies.
This should be a compile only change for flight stacks, ground stations and batteries.
The message is emitted with old ID in some flight stacks on request (e.g. PX4 v1.15) but as far as we can tell is never requested.
We don't think there are any affected smart batteries, but if there are, they will need to update firmware. Apologies.
Reply all
Reply to author
Forward
0 new messages