ScalaContinuousCompileMojo and private

8 views
Skip to first unread message

Eric Peters

unread,
May 8, 2019, 12:35:41 PM5/8/19
to Maven and Scala
Hi ~

I've been poking around in bloop looking into java9+ support, and after upgrading the maven-scala plugin to 4.x it looks like a couple permission changes break how bloop was using ScalaContinuousCompileMojo 


Specifically "mainSourceDir", "testSourceDir", "mainOutputDir", "testOutputDir", "analysisCacheFile", "testAnalysisCacheFile" are now private (changed from protected in https://github.com/davidB/scala-maven-plugin/commit/fcade4c9507710ba5fe8cba662fb1f330d1a6e24#diff-fd6eb6d53c4f7700b0f9888f25c02096)

There aren't any getters for these individual variables.  Was the change intended?  Do you have a suggestion for how bloop would/should create their "extended" version?

Regards,

Eric

David Bernard

unread,
May 11, 2019, 4:06:11 AM5/11/19
to Maven and Scala
for future reference, the discussion was moved to the PR make by Peter see https://github.com/davidB/scala-maven-plugin/pull/340

--

---
You received this message because you are subscribed to the Google Groups "Maven and Scala" group.
To unsubscribe from this group and stop receiving emails from it, send an email to maven-and-sca...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/maven-and-scala/4b48778a-14a4-43e5-945d-15561e1bd7a3%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

David Bernard

unread,
May 11, 2019, 4:06:55 AM5/11/19
to Maven and Scala
typo s/Peter/Eric Peters/

Sorry
Reply all
Reply to author
Forward
0 new messages