Deadlock on windows

[ty wang]

Hi,

Seems that I got a deadlock. Conditions:

1. windows platform

2. openmp enabled

3. glut enabled(not sure if that's necessary)

I installed the library by vcpkg, but this also happens when compiled by mingw.

I know little about openmp, but seems it tries to do some initialization in other threads. But in dllmain threads can't be used.

[mathgl....@gmail.com]

Hi,

Yes, there can be deadlock. For the simple solution, just comment line 734. I'll try to fix a more general issue too.

вс, 14 нояб. 2021 г. в 21:45, ty wang <163...@gmail.com>:

--
You received this message because you are subscribed to the Google Groups "MathGL" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mathgl+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/mathgl/4a05eaa2-7c4a-44fd-a05f-e9373b84d9ean%40googlegroups.com.

--

Kind regards,
Alexey Balakin

[ty wang]

Hi, 

Is there any plan for update recently? I wrote a patch for vcpkg ( https://github.com/microsoft/vcpkg/pull/21411 ). If you don't mind, I can submit the patch to vcpkg as a temporary solution.

Best regards,

Tianyi

[Alexey Balakin]

Dear Tianyi,

Yes, I plan to make a release before the New Year or early. There are many changes from the last release. Now, I'm updating the documentation and try to fix minor issues.

About the patch. I do not quite understand what it is, and how I can include the patch into the MathGL sources.

16.11.2021 06:51, ty wang пишет:

To view this discussion on the web visit https://groups.google.com/d/msgid/mathgl/0e98019d-3fe8-466e-b7ce-45ac415ffa3bn%40googlegroups.com.

[ty wang]

Hi,

Thanks for your reply.

My patch is not directly for mathgl, it's for vcpkg. With that, for anyone who installs mathgl from vcpkg, vcpkg will fix the code for them. I wrote that because I didn't know next mathgl release will be available soon.

If you want to know what I've done to mathgl code in the patch. I just disabled openmp on windows as you said.

https://github.com/microsoft/vcpkg/blob/81d12c7b1423050e5129765683b581bb020cd17e/ports/mathgl/omp_deadlock_fix.patch

Also there are some other patches (*.patch) in vcpkg. It will be great if you could check them.

https://github.com/wtywtykk/vcpkg/tree/244/ports/mathgl

[Alexey Balakin]

Hi,

Thank you. I've added some of patches to the recent SVN version.

19.11.2021 10:11, ty wang пишет:

To view this discussion on the web visit https://groups.google.com/d/msgid/mathgl/653fb3b3-b7b9-4add-8e88-806db81f84b2n%40googlegroups.com.

[Hanle]

Excuse me   Whether MathGL can use the mouse to drag  any Angle to view the 3D image, do not need to Rotate the specific Angle of view

[Alexey Balakin]

Yes, udav and mgllab handle mouse to rotate/shift the image. Just press toolbutton .

вторник, 30 ноября 2021 г. в 15:28:48 UTC+3, Hanle:

[ty wang]

Hi, 

I'm trying to update the vcpkg port to v2.5. Still there seems to be some problems and I have to apply some patch to get it work.

The patches are in the following commit:

https://github.com/wtywtykk/vcpkg/commit/bf72f1f8fc78aa0cdddee79624ba602fdad085a8

(PR to vcpkg https://github.com/microsoft/vcpkg/pull/22081)

Could you look though those patches and check if they are ok?

Also please accept my apologize for my submitting the patch to vcpkg without asking for your opinion first. I was new to opensource projects and made a mistake.

fix_arma_sprintf.patch: fix sprintf name conflict with armadillo. VS implemented it's own sprintf in later version, so redirecting to _sprintf makes std::sprintf not working.
fix_attribute.patch: MGL_FUNC_INIT and MGL_FUNC_FINI not defined issue.
fix_default_graph_init.patch: mglDefaultGr is initialized in DllMain, so it causes the similar problem as the Font. I Fixed it by disabling mglDefaultGr initialize in DllMain, it will be initialized on first use. Not sure if this has any side effect since mglDefaultGr itself is also exported.

fix_mglDataList.patch: All dlls shares the MGL_EXPORT marco, but in widgets dlls they need to import the classes from mgl.dll. Other (inlined) classes only causes a redefinition(central part of the picture below), but mglDataList is not defined in widgets dlls, so msvc can't find it. This patch is a really dirty solution, but it changes least code.

For the last redefinition problem, I also tried to separate the marcos used in widgets dlls. Maybe that is cleaner, but it needs to change lots of files. 

https://github.com/wtywtykk/mathgl_export_fix

I'm still working on this repo so it may not work, but it basially shows the idea.

Tianyi

[Alexey Balakin]

Hi,

Thank you for fixes. I put most of them into MathGL (SVN rev.1693). Can you check if it is enough?

22.12.2021 09:05, ty wang пишет:

To view this discussion on the web visit https://groups.google.com/d/msgid/mathgl/1988ec6e-5c99-4f7c-afad-cfe32a16dbf1n%40googlegroups.com.

[ty wang]

Hi,

SVN rev.1693 works fine, except opemmp simd is still an experimental feature on MSVC, and is not enabled by default.

Can I submit those patches to vcpkg? I need your permission to do that.