Comment on revision r2557 in power-matchmaker

[power-ma...@googlecode.com]

mo.j...@gmail.com commented on revision r2557 in project power-matchmaker.
Details are at
http://code.google.com/p/power-matchmaker/source/detail?r=2557

Line-by-line comments:

File:
/branches/spobject-conversion/src/ca/sqlpower/matchmaker/TranslateGroupParent.java
(r2557)
===============================================================================

Line 186: public MatchMakerTranslateGroup getChildByUUID(String UU) {
-------------------------------------------------------------------------------
I think I'd still like the parameter to be called UUID.

Also, document this (particularly that it may return null)

File:
/branches/spobject-conversion/src/ca/sqlpower/matchmaker/dao/TimedGeneralDAO.java
(r2557)
===============================================================================

Line 48: private final String FILENAME = "/Users/Joe/Documents/out.html";
-------------------------------------------------------------------------------
Why on earth is this in here?

Line 127: public MatchMakerTranslateGroup findByOID(Long valueOf) {
-------------------------------------------------------------------------------
Is there a reason these return null?

Respond to these comments at
http://code.google.com/p/power-matchmaker/source/detail?r=2557
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings