Comment on revision r2477 in power-matchmaker

0 views
Skip to first unread message

power-ma...@googlecode.com

unread,
Sep 24, 2010, 2:53:37 PM9/24/10
to matchmaker...@googlegroups.com
ThomasOBrien95 commented on revision r2477 in project power-matchmaker.
Details are at
http://code.google.com/p/power-matchmaker/source/detail?r=2477


Line-by-line comments:

File:
/branches/spobject-conversion/src/ca/sqlpower/matchmaker/swingui/MatchMakerTreeMouseAndSelectionListener.java
(r2477)
===============================================================================

Line 453: Project m = (Project) f.getParent();
-------------------------------------------------------------------------------
If TableMergeRules can only be a child of a Project then you can override
getParent in TableMergeRules to return a Project instead of an SPObject.
This will reduce the need to cast values.

Respond to these comments at
http://code.google.com/p/power-matchmaker/source/detail?r=2477
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings

Reply all
Reply to author
Forward
0 new messages