Comment on revision r2447 in power-matchmaker

[power-ma...@googlecode.com]

ThomasOBrien95 commented on revision r2447 in project power-matchmaker.
Details are at
http://code.google.com/p/power-matchmaker/source/detail?r=2447

Line-by-line comments:

File:
/branches/spobject-conversion/src/ca/sqlpower/matchmaker/undo/MMOChangeUndoWatcher.java
(r2447)
===============================================================================

Line 115: logger.debug("Child: " + e.getChild() + " is inserted
into: " + e.getSource().toString());
-------------------------------------------------------------------------------
This method is a remove not an insert.

File:
/branches/spobject-conversion/src/ca/sqlpower/matchmaker/undo/MMOChildrenInsertUndoableEdit.java
(r2447)
===============================================================================

Line 54: if (!(undoEvent.getChild() instanceof
AbstractMatchMakerObject)) {
-------------------------------------------------------------------------------
Is there a reason we are casting to AbstractMatchMakerObject instead of
just MatchMakerObject?

Respond to these comments at
http://code.google.com/p/power-matchmaker/source/detail?r=2447
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings