Comment on revision r2473 in power-matchmaker
power-ma...@googlecode.com
Details are at
http://code.google.com/p/power-matchmaker/source/detail?r=2473
General Comment:
After looking at the use for getChildren I am realizing that we need to
start adding in explicit methods for getting the children of different
classes. There are benefits to being able to call a method named
getMungeStepOutputs over getChildren(MungeStepOutput.class). The first
benefit is if you are trying to get a list of children from an object if
there is a getter for each child list you can use Eclipse's auto-complete
rather than viewing the classes themselves to see their children. Also, if
a type of child is ever removed from a class you will have to remove the
child type's getter. If the getter for the specific child type is being
used you will be able to quickly clean up the change but if you are using
getChildren then you will continually run into errors at run time.
In the future avoid using getChildren if you can add in the explicit getter
for the child list. We will also want to add in the explicit getters in
other classes we change from now on and replace the getChildren methods
where we can.
Respond to these comments at
http://code.google.com/p/power-matchmaker/source/detail?r=2473
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings