Comment on revision r2498 in power-matchmaker
power-ma...@googlecode.com
Details are at
http://code.google.com/p/power-matchmaker/source/detail?r=2498
Line-by-line comments:
File:
/branches/spobject-conversion/src/ca/sqlpower/matchmaker/swingui/munge/MungePen.java
(r2498)
===============================================================================
Line 804:
((MungeProcess)e.getSource()).getMungeSteps().get(x).addSPListener(mungeStepListener);
-------------------------------------------------------------------------------
These "train-wreck" expressions make this code a bit unpleasant to read. I
think at the very least, assign ((MungeProcess)
e.getSource().getMungeSteps() to a local variable, and then you can reuse
it further down in the method.
Respond to these comments at
http://code.google.com/p/power-matchmaker/source/detail?r=2498
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings