Comment on revision r2495 in power-matchmaker

[power-ma...@googlecode.com]

mo.j...@gmail.com commented on revision r2495 in project power-matchmaker.
Details are at
http://code.google.com/p/power-matchmaker/source/detail?r=2495

Line-by-line comments:

File:
/branches/spobject-conversion/src/ca/sqlpower/matchmaker/munge/MungeStep.java
(r2495)
===============================================================================

Line 186: * Returns the mungeStepIntput children (the actual class
name is AbstractMungeStep.Input)
-------------------------------------------------------------------------------
typo at mungeStepIntput :)

Line 188: List<AbstractMungeStep.Input> getMungeStepInputs();
-------------------------------------------------------------------------------
I think it's really bad that the interface references an abstract
implementation of itself. It kinda ruins the point of having an interface
in the first place. This may be a sign that we need to move Input out of
AbstractMungeStep.

Respond to these comments at
http://code.google.com/p/power-matchmaker/source/detail?r=2495
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings