Comment on revision r2448 in power-matchmaker
power-ma...@googlecode.com
Details are at
http://code.google.com/p/power-matchmaker/source/detail?r=2448
Line-by-line comments:
File:
/branches/spobject-conversion/src/ca/sqlpower/matchmaker/swingui/engine/EngineSettingsPanel.java
(r2448)
===============================================================================
Line 143: public final SPListener engineStatusListener;
-------------------------------------------------------------------------------
This should be private or the listener should be its own class if the
listener is needed outside of this class.
As a style preference I find it is more readable if you define the methods
of the listener here instead of in the constructor. If all of the inner
classes were defined in the constructor it would become unreadable. Feel
free to discuss this.
Respond to these comments at
http://code.google.com/p/power-matchmaker/source/detail?r=2448
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings