Comment on revision r2501 in power-matchmaker
power-ma...@googlecode.com
Details are at
http://code.google.com/p/power-matchmaker/source/detail?r=2501
Line-by-line comments:
File:
/branches/spobject-conversion/src/ca/sqlpower/matchmaker/swingui/munge/MungePen.java
(r2501)
===============================================================================
Line 945: int childNum =
child.getMungeStepInputs().indexOf((AbstractMungeStep.Input)evt.getSource());
-------------------------------------------------------------------------------
Might be worth trying to refactor this and the common code in the previous
if-block. The main part that differs is the value of mso. Btw, it may also
be worth naming mso something more descriptive. I mean we already know it's
a MungeStepOutput, but why do we want that particular one?
Line 953: con.getParentCom().setConnectOutput(con.getParentNumber(),
false);
-------------------------------------------------------------------------------
Do we need to continue through the rest of the connections once we've found
one that matches? I wouldn't think so since it looks like we're looking for
a particular connection with a particular 'parent number' and 'child
number'. If not, might as well call break;
On a side note, I don't quite like the 'child number' and 'parent number'
terminologies in IOConnector. I think a more common term would be to
use 'index' instead of 'number'. Unless that's not what they really
represent, but that's what I can only guess from the available doc comments.
Respond to these comments at
http://code.google.com/p/power-matchmaker/source/detail?r=2501
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings