Comment on revision r2478 in power-matchmaker
power-ma...@googlecode.com
Details are at
http://code.google.com/p/power-matchmaker/source/detail?r=2478
General Comment:
The doc comment on the constructor for GenericNewValueMaker says:
@param root
The absolute root object of the new value maker. All SPObjects
made by this class must be attached to this root object in
some way so they can be traversed by tests. The objects
created by this test do not have to be an immediate child of
the root for cases where they may need a specific type of
parent or ancestor which can be a child of the root. This object
must be able to accept children of any type that can be produced by
this new value maker.
This doc comment is not on both constructors and may not be visible enough
so feel free to move it to a more obvious place. With the comment your
objects made by the makeNewValue method must in some way be a child of the
root or else the persistence tests will not pass.
Respond to these comments at
http://code.google.com/p/power-matchmaker/source/detail?r=2478
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings