Comment on revision r2639 in power-matchmaker
power-ma...@googlecode.com
Details are at
http://code.google.com/p/power-matchmaker/source/detail?r=2639
Line-by-line comments:
File:
/branches/spobject-conversion/regress/ca/sqlpower/matchmaker/munge/TranslateWordMungeStepTest.java
(r2639)
===============================================================================
Line 72: step.setTranslateGroup((MatchMakerTranslateGroup)
session.getTranslations().getChildren().get(0));
-------------------------------------------------------------------------------
It would be much better for this test if you made a method called
getTranslateGroups in TranslateGroupParent and used it here and in the
other places changed in this class instead. Using an explicit
getTranslateGroups helps because you don't have to do a cast for one. You
will also know that the objects returned by the list contains the translate
groups, at current if a final child was added as the first object returned
by the list the tests would fail when they don't have to. Also, using an
explicit getter will let us find what tests are actually trying to retrieve
the translate groups in case they get moved in the future.
File:
/branches/spobject-conversion/src/ca/sqlpower/matchmaker/munge/TranslateWordMungeStep.java
(r2639)
===============================================================================
Line 162: translateGroup =
getSession().getTranslations().getChildren(MatchMakerTranslateGroup.class).get(0);
-------------------------------------------------------------------------------
This would be better if it was explicitly calling a getTranslateGroups
method.
Respond to these comments at
http://code.google.com/p/power-matchmaker/source/detail?r=2639
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings