Comment on revision r2678 in power-matchmaker

[power-ma...@googlecode.com]

ThomasOBrien95 commented on revision r2678 in project power-matchmaker.
Details are at
http://code.google.com/p/power-matchmaker/source/detail?r=2678

Line-by-line comments:

File:
/trunk/src/ca/sqlpower/matchmaker/enterprise/MatchMakerClientSideSession.java
(r2678)
===============================================================================

Line 98: securitySessions = new HashMap<String,
MatchMakerClientSideSession>();
-------------------------------------------------------------------------------
Since this static block only sets the securitySessions we can clean it up
by removing the static block and assign the securitySessions when we define
the variable. We should also group the static variables at the top of the
class.

Line 235:
delegateSession.createUserPrompterFactory().createUserPrompter("Cannot load
DDL settings due to missing class " + ddlgClass,
-------------------------------------------------------------------------------
The user prompter created never has promptUser called on it so it never
gets displayed.

Line 276: try {
-------------------------------------------------------------------------------
This try is unnecessary. If we can't rely on our logging to not cause an
error when logging then we are stuck anyways.

Line 279:
delegateSession.createUserPrompterFactory().createUserPrompter("Cannot
access the server to close the server session",
-------------------------------------------------------------------------------
This user prompter also does not get displayed.

Line 298: for (DomainCategory cat :
getSystemWorkspace().getChildren(DomainCategory.class)) {
-------------------------------------------------------------------------------
We do not have domain categories in MatchMaker.

Respond to these comments at
http://code.google.com/p/power-matchmaker/source/detail?r=2678
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings