Comment on revision r2551 in power-matchmaker

[power-ma...@googlecode.com]

mo.j...@gmail.com commented on revision r2551 in project power-matchmaker.
Details are at
http://code.google.com/p/power-matchmaker/source/detail?r=2551

Line-by-line comments:

File:
/branches/spobject-conversion/regress/ca/sqlpower/matchmaker/MatchMakerTestCase.java
(r2551)
===============================================================================

Line 359: if(tableIndex.getTableIndex() == null) {
-------------------------------------------------------------------------------
Add a space between if and '('

File:
/branches/spobject-conversion/src/ca/sqlpower/matchmaker/CachableTable.java
(r2551)
===============================================================================

Line 58: * sourceTable, xrefTable, or resultTable).
-------------------------------------------------------------------------------
I would probably also update the docs here, particularly to not
use 'property'

File:
/branches/spobject-conversion/src/ca/sqlpower/matchmaker/TableIndex.java
(r2551)
===============================================================================

Line 49: private String indexRole;
-------------------------------------------------------------------------------
Document this

Line 70: public String getIndexRole() {
-------------------------------------------------------------------------------
Document this too

File:
/branches/spobject-conversion/src/ca/sqlpower/matchmaker/munge/AbstractMungeStep.java
(r2524)
===============================================================================

Line 250: Class getDefaultInputClass(Class defaultInputClass) {
-------------------------------------------------------------------------------
Wow, I think this should go in the 'steaming pile of code' hall of fame

File:
/branches/spobject-conversion/src/ca/sqlpower/matchmaker/swingui/ProjectActionNode.java
(r2551)
===============================================================================

Line 49: String name;
-------------------------------------------------------------------------------
Why are these given package-level privacy?

Respond to these comments at
http://code.google.com/p/power-matchmaker/source/detail?r=2551
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings