Comment on revision r2524 in power-matchmaker

[power-ma...@googlecode.com]

mo.j...@gmail.com commented on revision r2524 in project power-matchmaker.
Details are at
http://code.google.com/p/power-matchmaker/source/detail?r=2524

Line-by-line comments:

File:
/branches/spobject-conversion/src/ca/sqlpower/matchmaker/munge/AbstractMungeStep.java
(r2524)
===============================================================================

Line 267: fireChildAdded(MungeStepInput.class, in, index);
-------------------------------------------------------------------------------
It seems that the 'canAddInput' bit had a purpose there. Without it, how do
you prevent someone from adding an input if canAddInput is supposed to
return false?

Respond to these comments at
http://code.google.com/p/power-matchmaker/source/detail?r=2524
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings

[power-ma...@googlecode.com]

gtc.cole commented on revision r2524 in project power-matchmaker.

Details are at
http://code.google.com/p/power-matchmaker/source/detail?r=2524

Score: Neutral

General Comment:
It turns out that this code is indeed getting in the way. MungeStep objects
need to be able to add their "default" inputs. e.g. UpperCaseMungeStep has
one input but can't add any more. The way that it is checking instead is
that the MungeSteps override addInput() and throw an error there.