Comment on revision r2484 in power-matchmaker
power-ma...@googlecode.com
Details are at
http://code.google.com/p/power-matchmaker/source/detail?r=2484
Line-by-line comments:
File:
/branches/spobject-conversion/regress/ca/sqlpower/matchmaker/TestingMatchMakerContext.java
(r2484)
===============================================================================
Line 64: throw new RuntimeException(e.getMessage());
-------------------------------------------------------------------------------
When wrapping an exception it is better if you pass the exception directly
instead of passing the message with it. If you pass the message then you
will get only the exception and its text which may be limited
to "NullPointerException". If you pass the whole exception you will get the
full stack trace from the inner exception.
File:
/branches/spobject-conversion/src/ca/sqlpower/matchmaker/MatchMakerSession.java
(r2484)
===============================================================================
Line 287: public List<UserDefinedSQLType> getSQLTypes();
-------------------------------------------------------------------------------
These new methods are added in the core session interface but the hibernate
session that extends this has not been modified in this commit. Is there
something missing?
Respond to these comments at
http://code.google.com/p/power-matchmaker/source/detail?r=2484
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings