Comment on revision r2488 in power-matchmaker

[power-ma...@googlecode.com]

mo.j...@gmail.com commented on revision r2488 in project power-matchmaker.
Details are at
http://code.google.com/p/power-matchmaker/source/detail?r=2488

Line-by-line comments:

File:
/branches/spobject-conversion/src/ca/sqlpower/matchmaker/munge/AbstractMungeStep.java
(r2488)
===============================================================================

Line 726: }
-------------------------------------------------------------------------------
It might be nice to mention that the Lists being returned will not be
modifiable.

File:
/branches/spobject-conversion/src/ca/sqlpower/matchmaker/munge/MungeProcess.java
(r2488)
===============================================================================

Line 303: throw new IllegalArgumentException();
-------------------------------------------------------------------------------
I would add a message in the IAE constructor explaining that result steps
are not acceptable.

Respond to these comments at
http://code.google.com/p/power-matchmaker/source/detail?r=2488
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings