Re: Issue 37 in marginalia: Beta 8 patch failing on Moodle 2.4.3

[margi...@googlecode.com]

Updates:
Summary: Beta 8 patch failing on Moodle 2.4.3
Status: WontFix

Comment #1 on issue 37 by geof.gl...@gmail.com: Beta 8 patch failing on
Moodle 2.4.3
http://code.google.com/p/marginalia/issues/detail?id=37

Unfortunately Moodle is a moving target. If the Moodle developers change a
line too close to where the patch makes changes the patch will fail. If I
update the patch to work with a newer Moodle release, it may fail for older
versions of Moodle. It's not practical for me to maintain additional
patches for each Moodle release. The current patch works for Moodle 2.5.

There are two ways you might deal with this:

1) Apply the patch by hand. This should be pretty easy if you understand
how patches work.

2) In most cases, you should be able to run a newer version of Marginalia
with an older version of the patch. Use the Beta 9 version of Marginalia
(Beta 8 was missing files, the version are otherwise the same), but take
the patch (and only the patch) from the Beta 7 distribution. I suspect this
will work fine.

The problem arises because Moodle does not have built-in hooks for what
Marginalia needs to do. With the release of Marginalia for Moodle 2, I
restructured Marginalia so that the patch would seldom change and would
touch as few points in the Moodle code as possible. Patching by hand is
almost always trivial. (I only recall two exceptions. One took some minor
programming; the other was the big move to Moodle 2.)

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[margi...@googlecode.com]

Comment #2 on issue 37 by commonco...@gmail.com: Beta 8 patch failing on
Moodle 2.4.3
http://code.google.com/p/marginalia/issues/detail?id=37

Yeah they are constantly changing these files and affecting the line
numbers called in the patch.

I had tried manually applying the patch for beta 8 without any luck.

I ended up going with your suggestion which was using beta 9 with the beta
7 patch and that worked great. Thanks so much for the response.

[margi...@googlecode.com]

Comment #3 on issue 37 by Kenwood...@gmail.com: Beta 8 patch failing on