Issue 36 in marginalia: Does not work with Moodle 2.4+

[margi...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 36 by daniel.k...@gmail.com: Does not work with Moodle 2.4+
http://code.google.com/p/marginalia/issues/detail?id=36

What steps will reproduce the problem?
1. Install 2.4.3 (latest moodle version)
2. Install Marginalia
3. Attempt to add a forum or add a topic to a pre-existing forum.

What is the expected output? What do you see instead?
I would expect to see the forum page after creating it or the forum page
upon entering a forum. Instead it presents an error message.

What version of the product are you using? On what browser?
Moodle 2.4.3 on Google Chrome.

Please provide any additional information below.

Error from debugging:

Strict Standards: Declaration of
mia_profile_forum_compose::get_object_type() should be compatible with that
of mia_page_profile::get_object_type() in
/www/playground2.learninghouse.com/wwwroot/243roles/blocks/marginalia/moodle_marginalia.php
on line 475 Strict Standards: Declaration of
mia_profile_forum_compose::get_object_id() should be compatible with that
of mia_page_profile::get_object_id() in
/www/playground2.learninghouse.com/wwwroot/243roles/blocks/marginalia/moodle_marginalia.php
on line 475 Strict Standards: Declaration of
mia_profile_js::get_object_type() should be compatible with that of
mia_page_profile::get_object_type() in
/www/playground2.learninghouse.com/wwwroot/243roles/blocks/marginalia/moodle_marginalia.php
on line 521 Strict Standards: Declaration of
mia_profile_js::get_object_id() should be compatible with that of
mia_page_profile::get_object_id() in
/www/playground2.learninghouse.com/wwwroot/243roles/blocks/marginalia/moodle_marginalia.php
on line 521

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[margi...@googlecode.com]

Comment #1 on issue 36 by theclair...@gmail.com: Does not work with Moodle
2.4+
http://code.google.com/p/marginalia/issues/detail?id=36

I encountered the same issue. It's a simple issue with the class
inheritance. Neither offending function leverages the offending argument.
The patch resolves the inheritance and removes the argument from the
references in annotate.php.

Just use "patch" to apply it and hopefully it gets included in the next
release.

Attachments:
issue_36.patch 1.5 KB