Re: [mapsforge] Cluster-Marker Example (#625)

371 views
Skip to first unread message

Ludwig

unread,
Jun 10, 2015, 12:39:31 AM6/10/15
to mapsforge/mapsforge, mapsfo...@googlegroups.com
Thanks for your contribution, these are always welcome.

To review your code, it would be good if your changes could be as small as possible against the current mapsforge dev.

Is that possible that you rebase your code on current mapsforge dev and generate a pull request from that?

Depending on how you manage your code base, it could be as easy as pulling from origin and then rebase. 

Ludwig



On 9 June 2015 at 20:34, vennekamp <notifi...@github.com> wrote:

Hi, I've created an example for clustering markers. It's working and I did not experience an bugs :-) Nevertheless, code might still need some improvements, since I'm not a professional programmer.

From my point of view, the software is working and I stopped working on this. Thus, I would like to hand it back to you and I like to remove my fork.

Regards, Martin Vennekamp

You can view, comment on, or merge this pull request online at:

  https://github.com/mapsforge/mapsforge/pull/625

Commit Summary

  • Version Numbers: reset to 0.5.0-SNAPSHOT after merging in dev
  • Trees: remove them from all render themes and also from map writer
  • AwtBitmap: scaleTo implementation
  • AwtBitmap: setBackgroundColor implementation
  • AwtBitmap: use bilinear interpolation at scale
  • Git: ignore IntelliJ files (Jordan Black)
  • MyLocationOverlay: clarify constructor javadoc (Jordan Black)
  • Android touch: add onActionDown handler (Jordan Black)
  • Way Labelling: fixes for tile clipping, overwriting with other way labels/symbols, by treating way texts similarly to other map elements. Added LineSegment class.
  • Rendertheme V4: added "auto" position and default implementation (for now) as the same as "below". The default position also changed to "auto".
  • Rendertheme V4: add "center" position at xsd
  • LayerManager: remove canvas fill with transparency
  • Samples: move attribution text to center for better visibility in all
  • Cache: increase minimum cache size by one row/column to ensure that a TileLayer will never render more tiles than fit into the cache.
  • Swing MapView: add more cleaning calls in destroy
  • Git: more in .gitignore
  • MapElementContainer: fix for clash when labels are equal (any container will clash with itself, avoids multiple drawing)
  • Tile: added convenience function for relative boundary
  • LineSegment: added heuristic function for intersection detection with rectangle
  • FileSystemTileCache: threaded version that pushes writing onto a lower priority thread
  • FileSystemCache: catching all exceptions to avoid crashing the storage thread. Made non-threaded version work.
  • FileSystemTileCache: added method to get queue length in order to facilitate testing
  • FileSystemTileCache: added non-threaded option (mainly to facilitate testing)
  • AndroidCanvas: enable anti-aliasing at drawBitmap
  • Speedup/DatabaseRenderer: filtering out POIs that lie outside the current tile
  • Speedup/map-reader: filtering results to only contain data that intersects requested tile. (Implementation for POIs was moved into MapReader from renderer code)
  • FileSystemTileCache: thread-safe queueLength() operation
  • Samples: allow full zoom range (0-24) in the BasicMapViewer (and derived), better for testing
  • Tile: correct bbox computations at all zoomlevels
  • BoundingBox: add method to extend bbox by percentage of size
  • Reader/MapDatabase: extend size of bbox used for filtering results (to avoid clipping lines that lie outside of tile)
  • Tile/Test: added more tests
  • MapDatabase/Filtering: changed boundingBox extension to 20m (instead of relative tile size)
  • MapDatabase/Filtering: made wayfiltering optional/configurable via public static variables.
  • Samples/Wayfiltering: added configuratio for way filtering to Settings
  • FileSystemTileCache: made threading configurable and added configuration to Samples app
  • Debug Timing: made configurable and added in Settings for Samples app.
  • AndroidUtils: tile cache size computation will return minimum of 4 tiles.
  • Samples/DualOverviewMapViewer: fixed screenRatios to ensure tile cache sizes are correct
  • Code Quality: fixed several Sonar issues (no functionality change)
  • Code Quality: removed some unused memory management functions (no functionality change)
  • Code Quality: fixed various Sonar violations (no functionality change)
  • Code Quality: fixed more Sonar violations and turned some warnings off (no functionality change)
  • InMemoryTileCache size/AndroidUtil: made the in memory tile cache a bit smaller (remove ceil op), for less memory use.
  • Code quality: fixed some sonar violations, no functionality change
  • Release Candidate 1 0.5.0-rc1
  • Osmarender: advance to render theme v4, improvements to label positions
  • Osmarender: introduce more symbols
  • TileCache: synchronized setWorkingSet to avoid concurrent modification
  • Samples TileStoreLayerViewer: use store's fixed tile size
  • Rendertheme V4: fixed bug for bitmap tiling, added better tiling example in RenderthemeV4 in Samples app
  • Samples: rename an svg icon to comply with its png
  • DisplayModel/TileSize: clamping tile size by default to multiple of 64 to aid symbol development
  • tag-mapping schema: extend documentation, improve formatting (Alexander
  • Gradle/PMD: upgrade to Gradle 2.1, Android plugin 0.13 and connected required changes to PMD ruleset
  • Area Shaders: implement shifting so that all bitmaps always tile (only Android, AWT missing)
  • Samples/RenderthemeV4: make more example use of area shader tiling
  • Area Shaders: clean up implementation/interface (no functionality change)
  • Area Shaders: implement shifting so that all bitmaps always tile (AWT)
  • Rendertheme V4: compute aspect ratio for SVG symbol scaling where only one of width/height is set.
  • Rendertheme V4: removed the tiling instruction for area shaders and related now unneeded functions
  • Release Candidate 2 0.5.0-rc2
  • Shader Tiling: added tiling to shaders for lines (thanks Maki), removed unneeded null check
  • Samples Rendertheme V4: cleaned up rendertheme-v4.xml
  • Samples Rendertheme V4: reorganized code somewhat to base most samples on Rendertheme V4
  • Samples Rendertheme V4: fix for a missing symbol
  • Samples symbols: add missing png from their original svg
  • Samples App Refactoring: move core structure into mapsforge-map-android/util/MapViewerTemplate and refactor samples
  • Gradle: update to SDK 20 and fix deprecated syntax
  • Samples app: change application label to indicate Mapsforge
  • Gradle/Maven: upgrade to Android SDK 21 (5.0, Lollipop)
  • Android project build target: upgrade to Android SDK 21 (5.0, Lollipop)
  • LatLongUtils: fix / improve zoom level calculation for BoundingBox
  • SwingMapViewer: increase memory tile cache
  • AwtPaint: replace JOIN_MITER value with its proper name
  • Samples App refactoring: MapViewerTemplate now supports only one MapView, dual cases handled in Samples directly, cleanup and simplification.
  • Samples App Refactoring: added missing class
  • Samples/Robotium: upgrade to robotium 5.2.1 and removed one test. Run from Samples directory.
  • Android Lifecycle cleanup: layer creation moved into onCreate/onDestroy, additional method to safely restart activity
  • AndroidUtil: fix android lint violation (TargetApi)
  • Grid layer added (first cut, no labels)
  • MapReader: increase limit for max way length which causes empty tiles
  • SVG Bitmap Store: caught (and ignored) another exception that can be the result of a race conditionSVG Bitmap Store: caught (and ignored) another exception that can be the result of a race condition.
  • Fix for #308
  • Maven: update POM developers
  • Maven: update POM developers
  • Maven: ignore Java 8 DocLint exit codes
  • Docs: added consolidated wiki files from Google Code under /docs in markdown format.
  • Docs: remove duplicated document
  • Docs: fixed links in mapsforge applications list
  • FileSystemTileCache: check for NPE in deleteDirectory
  • Docs: added README.md
  • Writer: fix to area detection heuristic issue #526
  • Writer: fix to c9e724f98950eb, fixes issue #526
  • MapViewerTemplate: added fix for when map file has start position, but no start zoom level
  • Samples/RenderthemeV4: added another base layer to display topographic info (cat natural in rendertheme-v4.xml)
  • Docs: added changes suggested by mvglasow, fixes #507
  • AWT: respect alpha, make some classes accessible (Develar)
  • Docs: moved README.md to top level, added screenshots and fixed links
  • Writer/TagMapping: removed duplicate entry
  • Writer: clipping MultiPolygons to tile for much smaller geometries/file size
  • RenderthemeV4: added display directive to force display of elements regardless of space
  • Samples/ChangingBitmaps: create layer before they are added to view.
  • RenderthemeV4: fix to display directive, drawing all elements in priority order
  • Update Getting-Started-Map-Writer.md
  • Update Downloads.md
  • Update README.md
  • Tile sources: fix parameter name
  • RenderthemeV4: added map-background-outside directive to blank out all areas outside map
  • AwtCanvas: implement inverse clip
  • Docs: added old presentations and fixed links
  • RenderthemeV4: map-background-outside directive for transparent layers results in transparency outside map area
  • Samples: added TwoMaps that renders two map files on top of each other
  • AndroidUtil: compute the minimum cache size using the size of the map
  • Release Candidate 0.5.0-rc3
  • Docs: latest changes, preparation for release 0.5.0
  • Docs: updates mostly in preparation for 0.5.0 release
  • License: added official LGPLv3 license text at top-level.
  • MapFileWriter: reduced logging for large polygons
  • Samples: delete now unneeded renderthemes
  • MapWriter/Renderthemes: update tag-mapping.xml and core renderthemes to conform to new standard for land/sea encoding.
  • RenderthemeV4, #549: changed drawing order so that higher-priority items are drawn on top of lower priority items (thanks @ystsoi).
  • MapWriter/#332: fix to invalid polygons
  • Release Candidate 0.5.0-rc4
  • Update Rendertheme.md
  • Update Rendertheme.md
  • Release Candidate 0.5.0-rc4 documentation updates
  • Release 0.5.0 documentation update
  • 0.5.0 Release
  • Fix some typos in "Getting Started Android App"
  • Fix formatting in "Getting Started Android App"
  • Merge pull request #569 from SyntaxBlitz/patch-1
  • Revert "Fix some typos in "Getting Started Android App""
  • Merge pull request #570 from mapsforge/revert-569-patch-1
  • Move LabelLayer.md in docs
  • Update Getting-Started-Developers.md
  • Update Getting-Started-Map-Writer.md
  • Update links for new site
  • Update Downloads.md
  • Eclipse code style: format source code changes only
  • Update Getting-Started-Map-Writer.md
  • Merge pull request #559 from borisbsu/patch-2
  • Update Getting-Started-Map-Writer.md
  • Merge pull request #562 from kcwu/patch-1
  • Update Specification-Binary-Map-File.md
  • Rename incorrect variable name enlargementInPixel
  • Merge pull request #563 from kcwu/patch-2
  • Merge pull request #564 from kcwu/patch-3
  • Update Rendertheme.md
  • Merge pull request #566 from kcwu/patch-1
  • Maven: advance to Android 5.0.1
  • Gradle: upgrade to 2.2.1 and Android plugin 0.14, Android Studio support for 1.0
  • Android Gradle Plugin: upgrade to v 1.0.0 and build-tools 21.1.1
  • Docs: added explications for render theme styles
  • Update Getting-Started-Android-App.md
  • Update Mapsforge-Applications.md
  • Update Mapsforge-Applications.md
  • MapReader: introduction of MapDataStore interface and MultiMapDataStore for combining map sources. See docs/MapDataStore.md for details.
  • Code quality: fixes, no functionality change
  • MapFile: fix NPE at close file
  • Rendertheme Handling: move parsing of rendertheme into TileRendererLayer/RendererJob
  • Rendertheme Handling: rendertheme parsing now done as a future, moving it off the UI thread
  • Persistent Cache: cleaned up version
  • Persistent cache: Improvements based on feedback
  • Further persistent-cache improvements
  • Persistent Cache: move reading of cache into separate thread
  • Persistent Cache: integration into Samples app
  • Persistent Cache: complete methods for tile cache creation
  • Samples: add a small fix to purge cache when settings change.
  • FileSystemTileCache: remove possible NPE
  • Debug layers: make painting configurable
  • Removed zoom-level check from map data read operation, partially resolves #572
  • Map TestUtils: add not equals test
  • DisplayModel: implement hashCode and equals
  • RenderThemeV4 XML Schema Definition: improvements and fixes
  • RenderThemeV4 xml: some fixes
  • RenderThemeV4 xsd: structural improvements
  • RenderThemeV4 xsd: more improvements
  • Fix for #578: Polyline Overlay with BitmapShader: strange visual effects
  • Further fixes for #578, applying required changes to Circle, Polygon and FixedPixelCircle. Added to OverlayMapViewer in Samples.
  • MapWriter: added method to release thread pool (thanks Andre)
  • Update links for new site
  • MapFile: add default start zoom level
  • MultiMapDataStore: start position checks also the bounding box
  • Osmarender: add map-background-outside directive
  • Update Getting-Started-Android-App.md
  • Update Getting-Started-Android-App.md
  • Update Getting-Started-Android-App.md
  • Labels: change master labels to master-SNAPSHOT
  • LabelsLayer: fix for #583 (priority drawing)
  • Rendering Dy fix for #580: dy scales with in sync with scaling of line width
  • Renderer dy for PathText and LineSymbol additional fix for #580
  • Samples: Map rotation (external) example
  • Samples: show Toast on overlays tap / long press events
  • Map Rotation (external): minor improvements
  • SymbolContainer fix for #550: translation with int values in draw
  • Geographic Grid: add default painting
  • Geographic Grid: fix line painting
  • Mapwriter fix for #458: not all closed ways are treated as polygons with reverted ways
  • Release Candidate 0.5.1-rc1
  • 0.5.1-rc1: update of Readme.md
  • Update Downloads.md
  • Update Getting-Started-Android-App.md
  • Update Downloads.md
  • FileSystemTileCache fix for #584: NPE during cache dir delete
  • Release Candidate 0.5.1-rc2
  • Release Candidate 0.5.1-rc2: doc updates
  • Update Changelog.md
  • Java SVG support #575: use of SVG Salamander
  • Osmarender: integrate SVG symbols
  • Resource memory / file cache: common clear methods in Android and Java
  • Update Getting-Started-Android-App.md
  • Update Getting-Started-Developers.md
  • Update Getting-Started-Developers.md
  • Update Rendertheme.md
  • Release Candidate 0.5.1-rc3
  • Update Downloads.md
  • SwingMapViewer: Gradle fix for jar signature mismatch
  • Release Candidate 0.5.1-rc4
  • Update Downloads.md
  • Update README.md
  • Docs: changed ReleaseProcedures.md to reflect change to javadoc
  • Android Maven: ignore consume-aar in Eclipse (it has no influence on the
  • Android Maven: advance target JDK to 1.7
  • Persistent cache: change @since version at docs
  • Gradle / Maven: upgrade to Android 5.1 (API 22)
  • Release 0.5.1
  • Update Getting-Started-Map-Writer.md
  • Update Changelog.md
  • Initial Commit (copy from my own APP - already working, not heavily tested...)
  • Documentation adapted.

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub.


Reply all
Reply to author
Forward
0 new messages