RenderTheme not found (maybe) when minifyEnabled is enable

[Paolo Dozio]

Hi at all,

I used the mapsforge intergration in the OSMdroid library.

Everything is fine when I use the app in debug mode.

but when I create the APK for release with "minifyEnabled true" in the build.gradle file it seems that the render theme is not found and the map is always yellow.

Maybe some code obfuscation "damage" the assets or the link to theme.

How is possible to solve this problem?

Thanks.

Paolo. 

[Emux]

Have not seen such case so far using the native Mapsforge and cannot know how third-party libraries use it.

Can try some ProGuard options:

-keep class org.mapsforge.** { *; }
-dontwarn org.mapsforge.**

Or something similar or debug the apk to see what classes are actually enter in it.

--
Emux

[Paolo Dozio]

Thanks.

I will try to do your suggestion.

I will let you know.

Thanks for your quick answer.

[Paolo Dozio]

In order to use your library I need to add these libraries

    

   implementation 'net.sf.kxml:kxml2:2.3.0'
   implementation 'com.caverock:androidsvg:1.3'   
   implementation 'org.osmdroid:osmdroid-mapsforge:6.0.3'

   implementation 'org.mapsforge:mapsforge-core:0.10.0'
   implementation 'org.mapsforge:mapsforge-map:0.10.0'
   implementation 'org.mapsforge:mapsforge-map-reader:0.10.0'
   implementation 'org.mapsforge:mapsforge-themes:0.10.0'
   implementation 'org.mapsforge:mapsforge-map-android:0.10.0'

When I execute the proguard in order to generate the APK release I have this error

Reading library jar [/Users/paolodozio/Library/Android/sdk/platforms/android-26/android.jar]

Note: duplicate definition of library class [org.xmlpull.v1.XmlSerializer]

Note: duplicate definition of library class [org.xmlpull.v1.XmlPullParserException]

Note: duplicate definition of library class [org.xmlpull.v1.XmlPullParserFactory]

Note: duplicate definition of library class [org.xmlpull.v1.XmlPullParser]

Reading library jar [/Users/paolodozio/Library/Android/sdk/build-tools/28.0.3/core-lambda-stubs.jar]

Reading library jar [/Users/paolodozio/Library/Android/sdk/platforms/android-26/optional/org.apache.http.legacy.jar]

Note: there were 4 duplicate class definitions.

      (http://proguard.sourceforge.net/manual/troubleshooting.html#duplicateclass)

If you see this suggested link https://www.guardsquare.com/en/products/proguard/manual/troubleshooting#duplicateclass

it says

 You should also not add libraries to your application that are already part of the Android runtime (notably org.w3c.dom, org.xml.sax, org.xmlpull.v1, org.apache.commons.logging.Log, org.apache.http, and org.json).

So I think there is a double inclusion of the Android libraries.

I tried to add one implementation at time

with this

implementation 'org.mapsforge:mapsforge-core:0.10.0'

the proguard terminate correctly

If I add also the map library 

implementation 'org.mapsforge:mapsforge-core:0.10.0'
implementation 'org.mapsforge:mapsforge-map:0.10.0'

I got the above error

I already tried to use

-dontnote org.xmlpull.v1.**

but the error is the same.

Do you have any suggestions?

Thanks.

Paolo.

[Paolo Dozio]

I understood what was..

The rule

-dontnote org.xmlpull.v1.**

was in the correct file, but not in the correct folder.

Now it works.

Sorry for this.