one-to-one

Tim Pigden

unread,

Jul 21, 2013, 6:35:42 AM7/21/13

to mapp...@googlegroups.com

Hi I'm struggling with an optional one-to-one mapping something like this (to make it close to your example - I've modified names and typed it in - haven't constructed a test program with these tables

since you've done that in your test framework previously.

case class Product(id: Int, inventory: Option[Inventory])

case class Inventory(stock: Int)

case class Catalogue(id: Int, products: Set[Product])

object CatalogueEntity extends Entity[Int, NaturalIntId, Catalogue] {

val id = key("id") to (_.id)

val products = onetomany(ProductEntity) to (_.products)

def constructor(implicit j: ValuesMap) = new Catalogue(id, products) with Stored

object ProductEntity extends Entity[Int, NaturalIntId, Product] {

val id = key("id") to (_.id)

val inventory = onetoone(InventoryEntity) option(_.inventory)

def constructor(implicit j: ValuesMap) = new Product(id, inventory) with Stored

object InventoryEntity extends Entity[Int, NaturalIntId, Product] {

val id = key("id") to (_.id)

val stock = column("stock") to (_.stock)

create table dw.stock (

id int primary key

);

create table dw.product (

id int primary key,

stock_id int not null,

constraint fk_stock foreign key(stock_id) references dw.stock(id)

create table dw.inventory (

id int primary key,

product_id int,

stock int not null,

constraint fk_inventory foreign key(inventory_id) references dw.product(id)

this is with RC21 for 10.0.1

In my code Plan is like stock, product is scheduleItem and inventory is visit - hence different names.

Note it's definitely the last field that cause sht problem but that if I get rid of Option and just have straight link I get same problem.

An error occured during select of entity PlanEntity$(Plan,com.optrak.bi.etl.Projects$Plan) and primary keys List(2)
null
com.googlecode.mapperdao.exceptions.QueryException: An error occured during select of entity PlanEntity$(Plan,com.optrak.bi.etl.Projects$Plan) and primary keys List(2)
null
	at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl$$anonfun$selectInner$1.apply(MapperDaoImpl.scala:180)
	at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl$$anonfun$selectInner$1.apply(MapperDaoImpl.scala:180)
	at com.googlecode.mapperdao.internal.EntityMap$$anonfun$get$1.apply(EntityMap.scala:46)
	at com.googlecode.mapperdao.internal.EntityMap$$anonfun$get$1.apply(EntityMap.scala:45)
	at com.googlecode.mapperdao.internal.EntityMap.get(EntityMap.scala:45)
	at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl.selectInner(MapperDaoImpl.scala:179)
	at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl.select0(MapperDaoImpl.scala:165)
	at com.googlecode.mapperdao.MapperDao$class.select(MapperDao.scala:245)
	at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl.select(MapperDaoImpl.scala:31)
	at com.googlecode.mapperdao.MapperDao$class.select(MapperDao.scala:230)
	at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl.select(MapperDaoImpl.scala:31)
	at com.optrak.bi.etl.TestDataConnections$$anonfun$1$$anonfun$apply$3.apply(TestDataConnections.scala:66)
	at com.optrak.bi.etl.TestDataConnections$$anonfun$1$$anonfun$apply$3.apply(TestDataConnections.scala:65)
Caused by: java.lang.NullPointerException
	at com.googlecode.mapperdao.sqlbuilder.SqlBuilder$WhereBuilder.toSql(SqlBuilder.scala:281)
	at com.googlecode.mapperdao.sqlbuilder.SqlBuilder$SqlSelectBuilder.toSql(SqlBuilder.scala:388)
	at com.googlecode.mapperdao.sqlbuilder.SqlBuilder$SqlSelectBuilder.result(SqlBuilder.scala:368)
	at com.googlecode.mapperdao.drivers.Driver.doSelect(Driver.scala:156)
	at com.googlecode.mapperdao.plugins.OneToOneEntityLazyLoader.apply(OneToOneEntityLazyLoader.scala:27)
	at com.googlecode.mapperdao.ValuesMap.valueOf(ValuesMap.scala:79)
	at com.googlecode.mapperdao.ValuesMap.valueOf(ValuesMap.scala:56)
	at com.googlecode.mapperdao.ValuesMap.apply(ValuesMap.scala:112)
	at com.googlecode.mapperdao.Entity.columnOneToOneOption(Entity.scala:318)
	at com.optrak.bi.etl.BIPersist$ScheduleItemEntity$$anon$5.<init>(BIPersist.scala:208)
	at com.optrak.bi.etl.BIPersist$ScheduleItemEntity$.constructor(BIPersist.scala:185)
	at com.optrak.bi.etl.BIPersist$ScheduleItemEntity$.constructor(BIPersist.scala:159)
	at com.googlecode.mapperdao.Entity.constructor(Entity.scala:83)
	at com.googlecode.mapperdao.Entity$$anonfun$2.apply(Entity.scala:94)
	at com.googlecode.mapperdao.Entity$$anonfun$2.apply(Entity.scala:92)
	at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl$$anonfun$toEntities$1$$anonfun$apply$1.apply(MapperDaoImpl.scala:265)
	at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl$$anonfun$toEntities$1$$anonfun$apply$1.apply(MapperDaoImpl.scala:248)
	at com.googlecode.mapperdao.internal.EntityMap$$anonfun$get$1.apply(EntityMap.scala:46)
	at com.googlecode.mapperdao.internal.EntityMap$$anonfun$get$1.apply(EntityMap.scala:45)
	at com.googlecode.mapperdao.internal.EntityMap.get(EntityMap.scala:45)
	at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl$$anonfun$toEntities$1.apply(MapperDaoImpl.scala:248)
	at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl$$anonfun$toEntities$1.apply(MapperDaoImpl.scala:231)
	at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl.toEntities(MapperDaoImpl.scala:230)
	at com.googlecode.mapperdao.plugins.OneToManyEntityLazyLoader.apply(OneToManyEntityLazyLoader.scala:36)
	at com.googlecode.mapperdao.plugins.OneToManyEntityLazyLoader.apply(OneToManyEntityLazyLoader.scala:14)
	at com.googlecode.mapperdao.ValuesMap.valueOf(ValuesMap.scala:79)
	at com.googlecode.mapperdao.ValuesMap.valueOf(ValuesMap.scala:56)
	at com.googlecode.mapperdao.ValuesMap.apply(ValuesMap.scala:118)
	at com.googlecode.mapperdao.Entity.columnTraversableOneToManySet(Entity.scala:247)
	at com.optrak.bi.etl.BIPersist$PlanEntity$$anon$2.<init>(BIPersist.scala:156)
	at com.optrak.bi.etl.BIPersist$PlanEntity$.constructor(BIPersist.scala:156)
	at com.optrak.bi.etl.BIPersist$PlanEntity$.constructor(BIPersist.scala:151)
	at com.googlecode.mapperdao.Entity.constructor(Entity.scala:83)
	at com.googlecode.mapperdao.Entity$$anonfun$2.apply(Entity.scala:94)
	at com.googlecode.mapperdao.Entity$$anonfun$2.apply(Entity.scala:92)
	at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl$$anonfun$toEntities$1$$anonfun$apply$1.apply(MapperDaoImpl.scala:265)
	at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl$$anonfun$toEntities$1$$anonfun$apply$1.apply(MapperDaoImpl.scala:248)
	at com.googlecode.mapperdao.internal.EntityMap$$anonfun$get$1.apply(EntityMap.scala:46)
	at com.googlecode.mapperdao.internal.EntityMap$$anonfun$get$1.apply(EntityMap.scala:45)
	at com.googlecode.mapperdao.internal.EntityMap.get(EntityMap.scala:45)
	at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl$$anonfun$toEntities$1.apply(MapperDaoImpl.scala:248)
	at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl$$anonfun$toEntities$1.apply(MapperDaoImpl.scala:231)
	at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl.toEntities(MapperDaoImpl.scala:230)
	at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl$$anonfun$selectInner$1.apply(MapperDaoImpl.scala:215)
	... 12 more

Tim Pigden

unread,

Jul 21, 2013, 6:39:38 AM7/21/13

to mapp...@googlegroups.com

addendum - it also fails in same way if I change it to manytoone

--
You received this message because you are subscribed to the Google Groups "mapperdao" group.
To unsubscribe from this group and stop receiving emails from it, send an email to mapperdao+...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
Tim Pigden
Optrak Distribution Software Limited
+44 (0)1992 517100
http://www.linkedin.com/in/timpigden
http://optrak.com
Optrak Distribution Software Ltd is a limited company registered in England and Wales.
Company Registration No. 2327613 Registered Offices: Orland House, Mead Lane, Hertford, SG13 7AT England
This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Optrak Distribution Software Ltd. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error.

Tim Pigden

unread,

Jul 21, 2013, 6:40:59 AM7/21/13

to mapp...@googlegroups.com

sorry missed this line out of all the entities

override val databaseSchema = DefaultPersist.dwSchema

and elsewhere

val dwSchema = Some(Schema(dwName.get))

Konstantinos Kougios

unread,

Jul 21, 2013, 7:39:16 AM7/21/13

to mapp...@googlegroups.com

ok Tim, I assume it is all ok now.

Cheers

Tim Pigden

unread,

Jul 21, 2013, 8:26:08 AM7/21/13

to mapp...@googlegroups.com

no - sorry you misunderstood. I missed it out of the description in my first email.

The problem still exists.

Konstantinos Kougios

unread,

Jul 21, 2013, 11:53:55 AM7/21/13

to mapp...@googlegroups.com

seems like a where clause is null. You get this when calling mapperDao.select, right? But how do you call it?

Tim Pigden

unread,

Jul 21, 2013, 12:17:48 PM7/21/13

to mapp...@googlegroups.com

I call it like this

val plan = DefaultPersist.mapperDao.select(PlanEntity, 2).get

but if I don't have the onetoone (or manytoone) there's no problem. As far as I can tell it's in the internally generated sql for the lower level objects but that's just from tracing through and guessing.

Konstantinos Kougios

unread,

Jul 21, 2013, 1:10:45 PM7/21/13

to mapp...@googlegroups.com

ok, probably I would have to write a small testcase, but let me understand your model a bit better. I believe we can skip the Catalogue as the error should occur before that.

case class Product(id: Int, inventory: Option[Inventory])
case class Inventory(stock: Int)

I am unclear on "Plan is like stock" as the stock is just an int and also you got stock table but the domain references inventory. So how would you fill the domain model above to simulate yours?

Cheers

Tim Pigden

unread,

Jul 21, 2013, 1:22:08 PM7/21/13

to mapp...@googlegroups.com

sorry, I was unclear "plan is like stock" was because the stack trace messages referred to "Plan"

The domain model above is correct. We expect products to maybe have inventory record associated (they don't if it is not a stocked product).

We want to get a catalogue consisting of many products, some of which will have associated stock records.

Oops looks like I screwed up on the database. The inventory record is keyed on the product_id field which is also the foreign key onto the product table.

create table dw.product (

id int primary key,

stock_id int not null,

constraint fk_stock foreign key(stock_id) references dw.stock(id)

create table dw.inventory (

product_id int primary key

stock int not null,

constraint fk_inventory foreign key(product_id) references dw.product(id)

Konstantinos Kougios

unread,

Jul 21, 2013, 1:27:52 PM7/21/13

to mapp...@googlegroups.com

ok thanks Tim, what is the stock_id? You have a table dw.stock but you don't reflect that in the domain model?

Tim Pigden

unread,

Jul 21, 2013, 2:31:59 PM7/21/13

to mapp...@googlegroups.com

sorry I've made a real mess of this haven't I? We're moving office this weekend and I've been distracted.

Stock is Catalogue.

So stock is the outer group - stock consists of many products, for some of which we have inventory.

So

one "stock" contains many "products". Each product may or may not be an inventory item.

I should have used "catalogue" as a better name than stock.

Konstantinos Kougios

unread,

Jul 21, 2013, 3:26:23 PM7/21/13

to mapp...@googlegroups.com

ok, wrote a test (without options for a start because currently onetoonereverse doesn't support them but will add support soon). It might be that you need onetoonereverse instead of onetoone. DO you think this test matches your code? The test passes ok.

(using Catalog instead of Stock)

           val catalog = Catalog(
                1,
                List(
                    Product(5, Inventory(1)),
                    Product(6, null)
                )
            )
            mapperDao.insert(CatalogEntity, catalog)

            mapperDao.select(CatalogEntity, 1).get should be(catalog)

    case class Catalog(id: Int, products: List[Product])

    case class Product(id: Int, inventory: Inventory)

    case class Inventory(stock: Int)

    object InventoryEntity extends Entity[Int, NoId, Inventory]
    {

val stock = column("stock") to (_.stock)

def constructor(implicit m: ValuesMap) = new Inventory(stock) with Stored

    }

    object ProductEntity extends Entity[Int, NaturalIntId, Product]
    {
        val id = key("id") to (_.id)

        val inventory = onetoonereverse(InventoryEntity) to (_.inventory)

        def constructor(implicit m: ValuesMap) = new Product(id, inventory) with Stored
    }

    object CatalogEntity extends Entity[Int, NaturalIntId, Catalog]

    {
        val id = key("id") to (_.id)
        val products = onetomany(ProductEntity) to (_.products)

def constructor(implicit m: ValuesMap) = new Catalog(id, products) with Stored
}

...

[ddl]
create table catalog (

id int primary key
)
;

create table product (
    id int primary key,
    catalog_id int not null,
    constraint fk_catalog foreign key(catalog_id) references catalog(id)
)
;
create table inventory (
    product_id int primary key,
    stock int not null,
    constraint fk_inventory foreign key(product_id) references product(id)
)

Tim Pigden

unread,

Jul 21, 2013, 4:11:40 PM7/21/13

to mapp...@googlegroups.com

Hi

Yes that looks right. So I tried to use onetoonereverse but it didn't seem to work and I had option (which you've confirmed not implemented).

Probably a little bit more explanation on when to use onetoone and when to use the reverse would help. I'm not clear on the distinction - but obviously they are different cases.

Can i use onetomanyreverse or something like that until you implement it (otherwise what is the timescale for a fix?)

Konstantinos Kougios

unread,

Jul 21, 2013, 5:58:30 PM7/21/13

to mapp...@googlegroups.com

On 21/07/13 21:11, Tim Pigden wrote:

Hi
Yes that looks right. So I tried to use onetoonereverse but it didn't seem to work and I had option (which you've confirmed not implemented).

I have uploaded a snapshot with the option for onetoonereverse been available. But also do you mean you still get a runtime exception? In that case, do you know what's the difference of your code and my test so that I can replicate?

(note the snapshot has some broken tests)

Probably a little bit more explanation on when to use onetoone and when to use the reverse would help. I'm not clear on the distinction - but obviously they are different cases.

onetoone is for the entity which table contains the FK. the reverse is for the "main" entity which doesn't contain the FK. Naming is a bit confusing, I'll have to figure out a better naming for that mapping.

Can i use onetomanyreverse or something like that until you implement it (otherwise what is the timescale for a fix?)

I am afraid that method doesn't exist. the reverse of onetomany is manytoone and using it probably will create a bit of complexity for your code. It might work. Effectivelly indeed onetoone is a trimmed down onetomany.

Cheers

Tim Pigden

unread,

Jul 22, 2013, 4:27:21 AM7/22/13

to mapp...@googlegroups.com

Hi - where do I get the snapshot?

i've got

resolvers += "SS" at "http://oss.sonatype.org/content/repositories/snapshots/"

but variations on

"com.googlecode.mapperdao" % "mapperdao" % "1.0.0-2.10.0-SNAPSHOT",

don't seem to work.

Tim Pigden

unread,

Jul 22, 2013, 4:49:28 AM7/22/13

to mapp...@googlegroups.com

sorry looks like I'm behind on versions. Been to check out the snapshots repository and got the right name (didn't think to look there before).

Konstantinos Kougios

unread,

Jul 22, 2013, 4:51:29 AM7/22/13

to mapp...@googlegroups.com

sorry forgot to mention the version number, 1.0.0.rc24-2.10.2-SNAPSHOT

Should be compatible with all 2.10 scala versions

https://oss.sonatype.org/content/repositories/snapshots/com/googlecode/mapperdao/mapperdao/1.0.0.rc24-2.10.2-SNAPSHOT/

Cheers

Tim Pigden

unread,

Jul 22, 2013, 6:53:10 AM7/22/13

to mapp...@googlegroups.com

Hi

Snapshot doesn't work properly I'm afraid. I got a simpler test - without the one-to-one on previous version and now am running that test against new version.

I get this error

An error occured during select of entity PlanEntity$(Plan,com.optrak.bi.etl.Projects$Plan) and primary keys List(0)

key not found: EntityType(Plan)

which implies it can't find the main record. but it found it before. so there seems to be some sort of regression problem. Plan is my top level entity. (I just backed out to rc21 and the test ran fine).

An error occured during select of entity PlanEntity$(Plan,com.optrak.bi.etl.Projects$Plan) and primary keys List(0)

key not found: EntityType(Plan)

com.googlecode.mapperdao.exceptions.QueryException: An error occured during select of entity PlanEntity$(Plan,com.optrak.bi.etl.Projects$Plan) and primary keys List(0)

key not found: EntityType(Plan)

at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl$$anonfun$selectInner$1.apply(MapperDaoImpl.scala:179)

at com.googlecode.mapperdao.internal.EntityMap$$anonfun$get$1.apply(EntityMap.scala:46)

at com.googlecode.mapperdao.internal.EntityMap$$anonfun$get$1.apply(EntityMap.scala:45)

at com.googlecode.mapperdao.internal.EntityMap.get(EntityMap.scala:45)

at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl.selectInner(MapperDaoImpl.scala:178)

at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl.select0(MapperDaoImpl.scala:163)

at com.googlecode.mapperdao.MapperDao$class.select(MapperDao.scala:245)

at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl.select(MapperDaoImpl.scala:29)

at com.googlecode.mapperdao.MapperDao$class.select(MapperDao.scala:230)

at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl.select(MapperDaoImpl.scala:29)

at com.optrak.bi.etl.TestDataConnections$$anonfun$1$$anonfun$apply$3.apply(TestDataConnections.scala:66)

at com.optrak.bi.etl.TestDataConnections$$anonfun$1$$anonfun$apply$3.apply(TestDataConnections.scala:65)

Caused by: java.util.NoSuchElementException: key not found: EntityType(Plan)

at com.googlecode.mapperdao.TypeRegistry.persistDetails(TypeRegistry.scala:46)

at com.googlecode.mapperdao.state.recreation.MockFactory.createMock(MockFactory.scala:31)

at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl$$anonfun$toEntities$1$$anonfun$apply$1.apply(MapperDaoImpl.scala:253)

at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl$$anonfun$toEntities$1$$anonfun$apply$1.apply(MapperDaoImpl.scala:251)

at com.googlecode.mapperdao.internal.EntityMap$$anonfun$get$1.apply(EntityMap.scala:46)

at com.googlecode.mapperdao.internal.EntityMap$$anonfun$get$1.apply(EntityMap.scala:45)

at com.googlecode.mapperdao.internal.EntityMap.get(EntityMap.scala:45)

at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl$$anonfun$toEntities$1.apply(MapperDaoImpl.scala:251)

at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl$$anonfun$toEntities$1.apply(MapperDaoImpl.scala:234)

at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl.toEntities(MapperDaoImpl.scala:233)

at com.googlecode.mapperdao.jdbc.impl.MapperDaoImpl$$anonfun$selectInner$1.apply(MapperDaoImpl.scala:218)

... 12 more

Konstantinos Kougios

unread,

Jul 22, 2013, 7:08:27 AM7/22/13

to mapp...@googlegroups.com

Hi Tim, in the newer mapperdao versions, registering entities is mandatory,when you setup mapperdao make sure all entities are registered (even simple types). This change was necessary to internally locate entities where as in the past mapperdao was more relaxed if you didn't register an entity or two.

After you do that, do you still get issues?

Cheers

Tim Pigden

unread,

Jul 22, 2013, 7:26:00 AM7/22/13

to mapp...@googlegroups.com

That problem goes away.

But still got an exception

Testing started at 12:24 ...

sample plan should

An error occured during select of entity PlanEntity$(Plan,com.optrak.bi.etl.Projects$Plan) and primary keys List(3)

null

com.googlecode.mapperdao.exceptions.QueryException: An error occured during select of entity PlanEntity$(Plan,com.optrak.bi.etl.Projects$Plan) and primary keys List(3)