[Bug 674949] Provide an app menu

1 view
Skip to first unread message

system-monitor

unread,
Aug 11, 2012, 3:54:34 PM8/11/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=674949
system-monitor | general | 3.4.x

Robert Roth <evfool> changed:

What |Removed |Added
----------------------------------------------------------------------------
Depends on| |351087

--- Comment #4 from Robert Roth <evf...@yahoo.com> 2012-08-11 19:54:28 UTC ---
I guess this is blocked on bug 351087, aka porting to GtkApplication.

--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

system-monitor

unread,
Sep 19, 2012, 7:09:04 PM9/19/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=674949
system-monitor | general | 3.4.x

Stefano Facchini <stefano.facchini> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |stefano....@gmail.com

system-monitor

unread,
Sep 19, 2012, 7:10:40 PM9/19/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=674949
system-monitor | general | 3.4.x

--- Comment #5 from Stefano Facchini <stefano....@gmail.com> 2012-09-19 23:10:36 UTC ---
Created an attachment (id=224788)
View: https://bugzilla.gnome.org/attachment.cgi?id=224788
Review: https://bugzilla.gnome.org/review?bug=674949&attachment=224788

Port to Application menu

The menubar is removed and the application-wide actions are made
available in the Application menu. Actions in the "view" menu
related to the "Processes" tab are accomodated in a menu button
inside the tab itself.

---

Depends on the patch at bug 351087

GIMP

unread,
Sep 19, 2012, 10:38:36 PM9/19/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=675124
GIMP | User Interface | unspecified

Magnus <ale.carrazzoni> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |ale.car...@gmail.com

--- Comment #4 from Magnus <ale.car...@gmail.com> 2012-09-20 02:38:33 UTC ---
Please implement a fallback menu that makes sense for those who don't use GNOME
Shell. The default fallback app menu is an usability disaster. It shouldn't be
on ANY application.

system-monitor

unread,
Sep 20, 2012, 1:46:41 PM9/20/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=674949
system-monitor | general | 3.4.x

Robert Roth <evfool> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #224788|none |needs-work
status| |

--- Comment #6 from Robert Roth <evf...@yahoo.com> 2012-09-20 17:46:34 UTC ---
Review of attachment 224788:
--> (https://bugzilla.gnome.org/review?bug=674949&attachment=224788)

Please also update the configure.ac to require the gtk+ version introducing
gtkmenubutton.

system-monitor

unread,
Sep 20, 2012, 3:05:35 PM9/20/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=674949
system-monitor | general | 3.4.x

Stefano Facchini <stefano.facchini> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #224788|0 |1
is obsolete| |

--- Comment #7 from Stefano Facchini <stefano....@gmail.com> 2012-09-20 19:05:28 UTC ---
Created an attachment (id=224851)
View: https://bugzilla.gnome.org/attachment.cgi?id=224851
Review: https://bugzilla.gnome.org/review?bug=674949&attachment=224851

Port to Application menu

The menubar is removed and the application-wide actions are made
available in the Application menu. Actions in the "view" menu
related to the "Processes" tab are accomodated in a menu button
inside the tab itself.

system-monitor

unread,
Sep 22, 2012, 9:24:26 AM9/22/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=674949
system-monitor | general | 3.4.x

Robert Roth <evfool> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #224851|none |needs-work
status| |

--- Comment #8 from Robert Roth <evf...@yahoo.com> 2012-09-22 13:24:23 UTC ---
Review of attachment 224851:
--> (https://bugzilla.gnome.org/review?bug=674949&attachment=224851)

The patch references menus.ui from the makefile and the sources, however the
file itself is not included in the patch, please add it.

system-monitor

unread,
Sep 22, 2012, 11:39:57 AM9/22/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=674949
system-monitor | general | 3.4.x

Stefano Facchini <stefano.facchini> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #224851|0 |1
is obsolete| |

--- Comment #9 from Stefano Facchini <stefano....@gmail.com> 2012-09-22 15:39:53 UTC ---
Created an attachment (id=224984)
View: https://bugzilla.gnome.org/attachment.cgi?id=224984
Review: https://bugzilla.gnome.org/review?bug=674949&attachment=224984

Port to Application menu

The menubar is removed and the application-wide actions are made
available in the Application menu. Actions in the "view" menu
related to the "Processes" tab are accomodated in a menu button
inside the tab itself.



Opss, sorry :) not it should be there

system-monitor

unread,
Sep 22, 2012, 5:11:51 PM9/22/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=674949
system-monitor | general | 3.4.x

Robert Roth <evfool> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #224984|none |needs-work
status| |

--- Comment #10 from Robert Roth <evf...@yahoo.com> 2012-09-22 21:11:47 UTC ---
Review of attachment 224984:
--> (https://bugzilla.gnome.org/review?bug=674949&attachment=224984)

Thanks for the quick responses. This one looks better, checked it, and does
what it should, appmenu works, refresh and view menu integrated in processes
tab works. However the menus.ui isn't marked for translation in the
po/POTFILES.in. Please mark it as translatable with the proper type, and I
think if that's done, it'll be OK, I will not have anything else against the
patch.
Reply all
Reply to author
Forward
0 new messages